From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF9B5C433FE for ; Tue, 26 Apr 2022 18:47:53 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 163D383BDB; Tue, 26 Apr 2022 20:47:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="tAe7Ulmv"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E641083D9C; Tue, 26 Apr 2022 20:47:47 +0200 (CEST) Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9BE9E806B7 for ; Tue, 26 Apr 2022 20:47:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x733.google.com with SMTP id n185so1409087qke.5 for ; Tue, 26 Apr 2022 11:47:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=F5ePLUYWGKu5L38ytV/4o3sf1nwcK5soZVhE4zrt+wY=; b=tAe7Ulmvknl02Wlwb7iC1NF5aQlDcaVmlDZLK50oSin/On+PhKnSA4EDDDcBHUbfFi 5hHffzVfGwFASNYFk/EvWbQsM7zKP0octlg/BHpCuDI7uUgn3Sz7jrZgd/TANUhiVFzL do9KwLMWGYNlJBkAXPJ/sIQGTACeZ7MBi0blk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=F5ePLUYWGKu5L38ytV/4o3sf1nwcK5soZVhE4zrt+wY=; b=thx91IcU987+OXbiOgFcre/9plA9M+L+awqDReSh9rN1Ef5WECyMAiiaUSf/6oM1Kh Qihn2A6tqeRGK4R8dhHoiJjytFTti0pBWtkTbzHBqc1Q4lFsC6tpJ7ThD/g95XAgVuQP BL3WGxMF+eFs07nnNTm55b0gStMY/bGsUlsRyXmjbF38zlmiRQg1uP1cCqsOgIAPoUxC f7XqBcxttIMmm1UlHCxoJqrn4usKz+FA7X48ONPz/K3COer76bvrjbdf4eWD1duWE8Yj JevE3+3jf+ERjs5biSP03lqOQXqVDoge68gks+zw1p2ivjdkN9lPIUq5r2BYWAU7+JXq xz3A== X-Gm-Message-State: AOAM532IjrCvPwUXRh+q25rhP/XAs0nHLdrR1Z8PxnXC9pzxosQfvCrU HOIoZkQzQ+SWT/yovRCdodusOg== X-Google-Smtp-Source: ABdhPJz8me5C4F6EXvT2Y/AxEUrnjXxusnD8GcNag2VXDxEarAEggxJK7hypTJgYKQZEz8KEbRc/gQ== X-Received: by 2002:a05:620a:438e:b0:69f:5296:fac with SMTP id a14-20020a05620a438e00b0069f52960facmr7141580qkp.719.1650998863368; Tue, 26 Apr 2022 11:47:43 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-4d8f-c477-6f29-9e62.res6.spectrum.com. [2603:6081:7b01:cbda:4d8f:c477:6f29:9e62]) by smtp.gmail.com with ESMTPSA id h20-20020a05620a13f400b0069e7ed38857sm6719458qkl.103.2022.04.26.11.47.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:47:42 -0700 (PDT) Date: Tue, 26 Apr 2022 14:47:40 -0400 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Priyanka Jain , Sinan Akman , u-boot@lists.denx.de Subject: Re: Suggestion: Revert commit c7fad78ec0ee ("Convert CONFIG_SYS_BR0_PRELIM et al to Kconfig") Message-ID: <20220426184740.GE7271@bill-the-cat> References: <20220426181740.o2n7xfg46ytljcdx@pali> <20220426182348.GD7271@bill-the-cat> <20220426183526.2wf3buag5pv2rilf@pali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="so9zsI5B81VjUb/o" Content-Disposition: inline In-Reply-To: <20220426183526.2wf3buag5pv2rilf@pali> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --so9zsI5B81VjUb/o Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 26, 2022 at 08:35:26PM +0200, Pali Roh=E1r wrote: > On Tuesday 26 April 2022 14:23:48 Tom Rini wrote: > > On Tue, Apr 26, 2022 at 08:17:40PM +0200, Pali Roh=E1r wrote: > >=20 > > > Hello! I would suggest to revert commit c7fad78ec0ee ("Convert > > > CONFIG_SYS_BR0_PRELIM et al to Kconfig"). > > >=20 > > > The reason is that this commit made configuration, understanding, > > > maintenance and debugging of the powerpc/mpc85xx Local Bus Controller > > > hard, mainly impossible. > > >=20 > > > This commit completely removed usage of named macros, to easily check > > > address and size of the LBC memory banks. Removal was done also for > > > explaining comments of configuration options. > > >=20 > > > It is just a mess what this commit introduced and took me really long > > > time to debug and understand what is happening here... until I revert= ed > > > this commit manually in my tree. > > >=20 > > > Any opinions? > > >=20 > > > Btw, current values are wrong. > >=20 > > AFAICT, the current values match what was in use prior. >=20 > I'm not going to verify that these values really match as playing with > those magic numbers is a pain. Right. It's been a while since I linked it, but: https://patchwork.ozlabs.org/project/uboot/patch/1500407318-7977-1-git-send= -email-trini@konsulko.com/ is what I use for migrating non-obvious values to Kconfig. So I used that to print out all of these, I'm pretty sure before and after. > But some of these values were wrong even before that commit. And this > can be verified easier (just checking that size does not match to > expected value in DTS or documentation). So some bitrot, probably then, sigh. > > But, these should probably not be in CONFIG namespace at all >=20 > Well, they do not belong to defconfig. These values are not user > configurable and are board wiring dependent. So should have never > appeared in menu config. So they shouldn't be asked and should be: config SYS_FOO hex default 0xBEEF in the board Kconfig files. And the help part of drivers/ddr/fsl/Kconfig updated to explain where/how to figure out or find the appropriate values. --=20 Tom --so9zsI5B81VjUb/o Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmJoPkMACgkQFHw5/5Y0 tyxCOQv+OEuzD1jgVin711wCRtd0W1I80nFVtN6Cu9b6qb54naFvTU72uCmmKLqg ehn5ukCXbLvk8YFEjK4J+kpG08niJHQdy2bzqUA8wjrfQIKV9Qc3TgXY7+d4dEgU xqLERQZiOmztvOaHD2TQpG6OBPPy6BjsqAUFX3YOaGWEUsCf2oeSvlcQZ480GxV9 Yo/SxeFXJDaJBCZSgBfRndU2sycHpnVci9HzIknHZj+dkcLUMzmP71HeZbtNxGcW 7zejSiJMLEx3k5NxFVQJNlIl3Zb9VS/n06HDabZvRBb6Sx2cWnRT8dlYlkBtspaQ arnT5XyNawJxpGOoTILBdnuMfhjbgu4ZzFHbaL5PzZ/Fu/pn+B896Y8AgBUiz4Kp q5uFPXITvkUpO1F7/GrP+/MSuFpnib0LXHl2Um5CQccY/JIlmB/jnj25NBRtDm2t nCOOSfntYozrdvYMInW2SoE9wWvQD0nhv7R62JVmmuys2aLJwhKW+KjPMT5ZbIJx tgDgHiXx =dygW -----END PGP SIGNATURE----- --so9zsI5B81VjUb/o--