All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: fstests@vger.kernel.org
Cc: "Theodore Ts'o" <tytso@mit.edu>
Subject: [PATCH] ext4/054,ext4/055: don't run when using DAX
Date: Tue, 26 Apr 2022 20:52:09 -0400	[thread overview]
Message-ID: <20220427005209.4188220-1-tytso@mit.edu> (raw)

The ext4/054 and ext4/055 tests create a scratch file system with a 1k
block size.  This is not compatible with mounting with the DAX option,
which requires a block size equal to the page size (which is 4k on
x86).

Also, the ext4/054 test doesn't use the test device, so remove the
_require_test declaration.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---
 tests/ext4/054 | 2 +-
 tests/ext4/055 | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/tests/ext4/054 b/tests/ext4/054
index 9a11719f..6c722f32 100755
--- a/tests/ext4/054
+++ b/tests/ext4/054
@@ -19,8 +19,8 @@ _begin_fstest auto quick dangerous_fuzzers
 
 # real QA test starts here
 _supported_fs ext4
-_require_test
 _require_scratch_nocheck
+_exclude_scratch_mount_option dax
 _require_xfs_io_command "falloc"
 _require_xfs_io_command "pwrite"
 _require_xfs_io_command "fsync"
diff --git a/tests/ext4/055 b/tests/ext4/055
index 8f466f1b..1ae42b89 100755
--- a/tests/ext4/055
+++ b/tests/ext4/055
@@ -17,8 +17,9 @@
 _begin_fstest auto quota
 
 # real QA test starts here
-_require_scratch_nocheck
 _supported_fs ext4
+_require_scratch_nocheck
+_exclude_scratch_mount_option dax
 _require_user fsgqa
 _require_user fsgqa2
 _require_command "$DEBUGFS_PROG" debugfs
-- 
2.31.0


             reply	other threads:[~2022-04-27  0:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-27  0:52 Theodore Ts'o [this message]
2022-04-27  8:05 ` Zorro Lang
2022-04-27 14:53   ` Theodore Ts'o
2022-04-27 17:19     ` Zorro Lang
2022-04-27 19:44       ` Theodore Ts'o
2022-04-28  4:53         ` Zorro Lang
2022-04-28  5:58           ` Dave Chinner
2022-04-28  6:55             ` Zorro Lang
2022-04-29  1:10 ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220427005209.4188220-1-tytso@mit.edu \
    --to=tytso@mit.edu \
    --cc=fstests@vger.kernel.org \
    --subject='Re: [PATCH] ext4/054,ext4/055: don'\''t run when using DAX' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.