All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Miaohe Lin <linmiaohe@huawei.com>
Cc: <mm-commits@vger.kernel.org>, <ying.huang@intel.com>,
	<osalvador@suse.de>, <iamjoonsoo.kim@lge.com>, <hch@lst.de>
Subject: Re: [nacked] mm-vmscan-activate-swap-backed-executable-folios-after-first-usage.patch removed from -mm tree
Date: Wed, 27 Apr 2022 07:16:01 -0700	[thread overview]
Message-ID: <20220427071601.d18f105d4934f0362f33472c@linux-foundation.org> (raw)
In-Reply-To: <2e567a92-171e-26d5-2830-927c7f2f68a9@huawei.com>

On Wed, 27 Apr 2022 14:41:30 +0800 Miaohe Lin <linmiaohe@huawei.com> wrote:

> On 2022/4/27 14:25, Andrew Morton wrote:
> > 
> > The patch titled
> >      Subject: mm/vmscan: activate swap-backed executable folios after first usage
> > has been removed from the -mm tree.  Its filename was
> >      mm-vmscan-activate-swap-backed-executable-folios-after-first-usage.patch
> > 
> > This patch was dropped because it was nacked
> 
> Hi Andrew,
> 
> Since this patch is nacked, should I resend the whole series with this patch dropped?
> And I'd like to change this patch to use the helper folio_is_file_lru too, something like below:
> 
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index ed484a0e9cd0..60ccbebec4c8 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -1412,9 +1412,9 @@ static enum page_references folio_check_references(struct folio *folio,
>                         return PAGEREF_ACTIVATE;
> 
>                 /*
> -                * Activate executable folios after first usage.
> +                * Activate file-backed executable folios after first usage.
>                  */
> -               if (vm_flags & VM_EXEC)
> +               if ((vm_flags & VM_EXEC) && folio_is_file_lru(folio))
>                         return PAGEREF_ACTIVATE;
> 
>                 return PAGEREF_KEEP;
> 
> Should I send this patch separately or resend the whole series with this new change attached?
> 

I dropped this patch individually, so there's no need to resend the others.

  reply	other threads:[~2022-04-27 14:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-27  6:25 [nacked] mm-vmscan-activate-swap-backed-executable-folios-after-first-usage.patch removed from -mm tree Andrew Morton
2022-04-27  6:41 ` Miaohe Lin
2022-04-27 14:16   ` Andrew Morton [this message]
2022-04-28  1:59     ` Miaohe Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220427071601.d18f105d4934f0362f33472c@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=hch@lst.de \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linmiaohe@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mm-commits@vger.kernel.org \
    --cc=osalvador@suse.de \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.