From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79651C433EF for ; Wed, 27 Apr 2022 15:57:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240809AbiD0QA0 (ORCPT ); Wed, 27 Apr 2022 12:00:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240452AbiD0QAN (ORCPT ); Wed, 27 Apr 2022 12:00:13 -0400 Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD64C80BDA for ; Wed, 27 Apr 2022 08:56:26 -0700 (PDT) Received: by mail-pl1-x631.google.com with SMTP id c23so1954890plo.0 for ; Wed, 27 Apr 2022 08:56:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=S7gjHtnoBbugQauhNsDeWPF5G5twM4OriQvPe+xVavg=; b=IjLkvsUydINfST/SeE3kJPSTPMbbn1Qz9dv2EWCikm+f6aHgbuMsIJOUwGAluCFOFv 8GBorrPOSw3MkEA8ebb/4/Xa9eiuLUObT3bYrskiT1VavjLKAcViXwfiuY+fkwkEDSnv rsrAEmjg51YA69Z0IObAvGMxePXUQL0GpSLKkPfd3I5tDiJ78B0ReBqmwkzfZd9cDQY+ gPvJiMc53AaLS6Pikn+//xzrpHdpwXk3QZ/oirJL6q3HrsGLcST9aaN3HYXZMH34G/NJ 2kURUdwHdfQkL7+EcINfm33CMWAOKq/RVQPWjmdGEfZ0SiieiBoKJRhEDumG8B2WW9Zl RyNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=S7gjHtnoBbugQauhNsDeWPF5G5twM4OriQvPe+xVavg=; b=BvAUFScgANMCgAuWkYT+7RZsDnio/QuQm8XmTk0ylzhdCeVX/d2gwpEbN5rpxO4KVZ blfgH8qseQ/eZLuasEvXAoHAqArTYYaF7WlE794W2zkG30DOqAM9JoDVq3iEaDF11e87 G4f93WnUu02UKnnRFq9QLCPQvj1U0RjKuNOMchW0UPi4aUpPCAtM6DEbx90dvnTQnRER C4qjYBGU7qQYXBoB8cf79fOor3143LyhOCwVWNQPXDITDIeMgKNN4rPr+fohT7QLAA5a N+xYp7hY/KGC12eboZrPiBnnhfggMwGuUQnUhsb9rmq9r13/6pkKDTpOWXtq0xAtGxVC yu5Q== X-Gm-Message-State: AOAM530u4QG9HPJIgbMX+HfqLaR7r/zittHg5ssJ3dLB+CNG21bChpNt I5Qs8sL+uUNe1WupBlHQq5qxIUUgz9TUuA== X-Google-Smtp-Source: ABdhPJwovTBCuIAY1Dof31W4pMLa6odSaAw525T/ZOd/QWQRPmu7DuY3/ib8HvU8rF8OJSvBa5Fjxg== X-Received: by 2002:a17:902:ce01:b0:15c:eedb:f00c with SMTP id k1-20020a170902ce0100b0015ceedbf00cmr21330243plg.122.1651074984238; Wed, 27 Apr 2022 08:56:24 -0700 (PDT) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id s22-20020a17090a5d1600b001d954837197sm7500133pji.22.2022.04.27.08.56.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Apr 2022 08:56:23 -0700 (PDT) Date: Wed, 27 Apr 2022 08:56:21 -0700 From: Stephen Hemminger To: Willy Tarreau Cc: netdev@vger.kernel.org, David Miller , Jakub Kicinski , Eric Dumazet , Moshe Kol , Yossi Gilad , Amit Klein , linux-kernel@vger.kernel.org Subject: Re: [PATCH net 3/7] tcp: resalt the secret every 10 seconds Message-ID: <20220427085621.5f2d1759@hermes.local> In-Reply-To: <20220427065233.2075-4-w@1wt.eu> References: <20220427065233.2075-1-w@1wt.eu> <20220427065233.2075-4-w@1wt.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 27 Apr 2022 08:52:29 +0200 Willy Tarreau wrote: > From: Eric Dumazet > > In order to limit the ability for an observer to recognize the source > ports sequence used to contact a set of destinations, we should > periodically shuffle the secret. 10 seconds looks effective enough > without causing particular issues. > > Cc: Moshe Kol > Cc: Yossi Gilad > Cc: Amit Klein > Tested-by: Willy Tarreau > Signed-off-by: Eric Dumazet > --- > net/core/secure_seq.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/net/core/secure_seq.c b/net/core/secure_seq.c > index 2cdd43a63f64..200ab4686275 100644 > --- a/net/core/secure_seq.c > +++ b/net/core/secure_seq.c > @@ -22,6 +22,8 @@ > static siphash_aligned_key_t net_secret; > static siphash_aligned_key_t ts_secret; > Rather than hard coding, why not have a sysctl knob for this? That way the tinfoil types can set it smaller.