From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: fio Mailing List <fio@vger.kernel.org>,
GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>,
Ammar Faizi <ammarfaizi2@gnuweeb.org>
Subject: [PATCH v2 5/6] json: Change `if (!strlen(str))` to `if (!str[0])`
Date: Wed, 27 Apr 2022 16:11:24 +0700 [thread overview]
Message-ID: <20220427091125.114146-6-ammarfaizi2@gnuweeb.org> (raw)
In-Reply-To: <20220427091125.114146-1-ammarfaizi2@gnuweeb.org>
No need to traverse the whole string. Using `!strlen(str)` as a
*conditional expression* is effectively the same with `!str[0]`.
Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
---
json.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/json.c b/json.c
index cd3d5d74..8b650721 100644
--- a/json.c
+++ b/json.c
@@ -56,7 +56,7 @@ static char *strdup_escape(const char *str)
char *p, *ret;
int escapes;
- if (!strlen(str))
+ if (!str[0])
return NULL;
escapes = 0;
--
Ammar Faizi
next prev parent reply other threads:[~2022-04-27 11:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 9:11 [PATCH v2 0/6] Small fio cleanups and fixes Ammar Faizi
2022-04-27 9:11 ` [PATCH v2 1/6] backend: Fix indentation Ammar Faizi
2022-04-27 9:11 ` [PATCH v2 2/6] cgroup: Handle `ENOMEM` case on `malloc()` call Ammar Faizi
2022-04-27 9:11 ` [PATCH v2 3/6] stat: Handle `ENOMEM` case in `__show_run_stats()` Ammar Faizi
2022-04-27 9:35 ` Niklas Cassel
2022-04-27 9:52 ` Ammar Faizi
2022-04-27 9:11 ` [PATCH v2 4/6] engines/net: Replace `malloc()` + `memset()` with `calloc()` Ammar Faizi
2022-04-27 9:11 ` Ammar Faizi [this message]
2022-04-27 9:11 ` [PATCH v2 6/6] Makefile: Suppress `-Wimplicit-fallthrough` when compiling `lex.yy` Ammar Faizi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220427091125.114146-6-ammarfaizi2@gnuweeb.org \
--to=ammarfaizi2@gnuweeb.org \
--cc=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=gwml@vger.gnuweeb.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.