From: Andrew Morton <akpm@linux-foundation.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Jagdish Gediya <jvgediya@linux.ibm.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
willy@infradead.org, ying.huang@intel.com, dave.hansen@intel.com,
Jonathan.Cameron@huawei.com, adobriyan@gmail.com,
rf@opensource.cirrus.com, pmladek@suse.com
Subject: Re: [PATCH v3 1/2] lib/kstrtox.c: Add "false"/"true" support to kstrtobool()
Date: Wed, 27 Apr 2022 10:39:01 -0700 [thread overview]
Message-ID: <20220427103901.7567e7058dcaa3068056b2ed@linux-foundation.org> (raw)
In-Reply-To: <Ymldp7E3j29iVlMN@smile.fi.intel.com>
On Wed, 27 Apr 2022 18:13:43 +0300 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> On Tue, Apr 26, 2022 at 11:32:02PM +0530, Jagdish Gediya wrote:
> > At many places in kernel, It is necessary to convert sysfs input
> > to corrosponding bool value e.g. "false" or "0" need to be converted
>
> corresponding
>
> > to bool false, "true" or "1" need to be converted to bool true,
> > places where such conversion is needed currently check the input
> > string manually, kstrtobool() can be utilized at such places but
> > currently it doesn't have support to accept "false"/"true".
> >
> > Add support to accept "false"/"true" as valid string in kstrtobool().
>
> Andrew, this patch still needs a bit of work.
I fixed the two issues you identified in this email. Is there more to do?
next prev parent reply other threads:[~2022-04-27 17:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 18:02 [PATCH v3 1/2] lib/kstrtox.c: Add "false"/"true" support to kstrtobool() Jagdish Gediya
2022-04-26 18:02 ` [PATCH v3 2/2] mm: Convert sysfs input to bool using kstrtobool() Jagdish Gediya
2022-04-26 19:14 ` [PATCH v3 1/2] lib/kstrtox.c: Add "false"/"true" support to kstrtobool() Matthew Wilcox
2022-04-26 20:40 ` David Laight
2022-04-27 10:21 ` Jagdish Gediya
2022-04-27 15:13 ` Andy Shevchenko
2022-04-27 17:39 ` Andrew Morton [this message]
2022-04-27 18:17 ` Andy Shevchenko
2022-04-27 18:19 ` Andy Shevchenko
2022-07-25 14:55 ` Mark Rutland
2022-07-25 15:21 ` Matthew Wilcox
2022-07-25 15:36 ` Mark Rutland
2022-07-29 14:35 ` Andy Shevchenko
2022-07-29 14:36 ` Andy Shevchenko
2022-08-25 13:39 ` Petr Mladek
2022-08-26 10:35 ` Will Deacon
2022-07-29 15:17 ` Alexey Dobriyan
2022-07-29 15:32 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220427103901.7567e7058dcaa3068056b2ed@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=adobriyan@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dave.hansen@intel.com \
--cc=jvgediya@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pmladek@suse.com \
--cc=rf@opensource.cirrus.com \
--cc=willy@infradead.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.