All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Luís Henriques" <lhenriques@suse.de>
To: Jeff Layton <jlayton@kernel.org>, Xiubo Li <xiubli@redhat.com>,
	Ilya Dryomov <idryomov@gmail.com>
Cc: ceph-devel@vger.kernel.org, fstests@vger.kernel.org,
	"Luís Henriques" <lhenriques@suse.de>
Subject: [PATCH] ceph/005: verify correct statfs behaviour with quotas
Date: Wed, 27 Apr 2022 15:34:09 +0100	[thread overview]
Message-ID: <20220427143409.987-1-lhenriques@suse.de> (raw)

When using a directory with 'max_bytes' quota as a base for a mount,
statfs shall use that 'max_bytes' value as the total disk size.  That
value shall be used even when using subdirectory as base for the mount.

A bug was found where, when this subdirectory also had a 'max_files'
quota, the real filesystem size would be returned instead of the parent
'max_bytes' quota value.  This test case verifies this bug is fixed.

Signed-off-by: Luís Henriques <lhenriques@suse.de>
---
 tests/ceph/005     | 40 ++++++++++++++++++++++++++++++++++++++++
 tests/ceph/005.out |  2 ++
 2 files changed, 42 insertions(+)
 create mode 100755 tests/ceph/005
 create mode 100644 tests/ceph/005.out

diff --git a/tests/ceph/005 b/tests/ceph/005
new file mode 100755
index 000000000000..0763a235a677
--- /dev/null
+++ b/tests/ceph/005
@@ -0,0 +1,40 @@
+#! /bin/bash
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (C) 2022 SUSE Linux Products GmbH. All Rights Reserved.
+#
+# FS QA Test 005
+#
+# Make sure statfs reports correct total size when:
+# 1. using a directory with 'max_byte' quota as base for a mount
+# 2. using a subdirectory of the above directory with 'max_files' quota
+#
+. ./common/preamble
+_begin_fstest auto quick quota
+
+_supported_fs generic
+_require_scratch
+
+_scratch_mount
+mkdir -p $SCRATCH_MNT/quota-dir/subdir
+
+# set quotas
+quota=$((1024*10000))
+$SETFATTR_PROG -n ceph.quota.max_bytes -v $quota $SCRATCH_MNT/quota-dir
+$SETFATTR_PROG -n ceph.quota.max_files -v $quota $SCRATCH_MNT/quota-dir/subdir
+_scratch_unmount
+
+SCRATCH_DEV=$SCRATCH_DEV/quota-dir _scratch_mount
+total=`df -kP $SCRATCH_MNT | grep -v Filesystem | awk '{print $2}'`
+SCRATCH_DEV=$SCRATCH_DEV/quota-dir _scratch_unmount
+[ $total -eq 8192 ] || _fail "Incorrect statfs for quota-dir: $total"
+
+SCRATCH_DEV=$SCRATCH_DEV/quota-dir/subdir _scratch_mount
+total=`df -kP $SCRATCH_MNT | grep -v Filesystem | awk '{print $2}'`
+SCRATCH_DEV=$SCRATCH_DEV/quota-dir/subdir _scratch_unmount
+[ $total -eq 8192 ] || _fail "Incorrect statfs for quota-dir/subdir: $total"
+
+echo "Silence is golden"
+
+# success, all done
+status=0
+exit
diff --git a/tests/ceph/005.out b/tests/ceph/005.out
new file mode 100644
index 000000000000..a5027f127cf0
--- /dev/null
+++ b/tests/ceph/005.out
@@ -0,0 +1,2 @@
+QA output created by 005
+Silence is golden

             reply	other threads:[~2022-04-27 14:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-27 14:34 Luís Henriques [this message]
2022-05-24 22:11 ` David Disseldorp
2022-05-25  8:53   ` Luís Henriques
2022-05-25 10:36     ` David Disseldorp
2022-05-25 14:26       ` Luís Henriques
2022-05-25 10:19 ` Zorro Lang
2022-05-25 14:47   ` Luís Henriques

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220427143409.987-1-lhenriques@suse.de \
    --to=lhenriques@suse.de \
    --cc=ceph-devel@vger.kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=idryomov@gmail.com \
    --cc=jlayton@kernel.org \
    --cc=xiubli@redhat.com \
    --subject='Re: [PATCH] ceph/005: verify correct statfs behaviour with quotas' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.