From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BD18C433F5 for ; Wed, 27 Apr 2022 15:41:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240330AbiD0PpB (ORCPT ); Wed, 27 Apr 2022 11:45:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240158AbiD0Pop (ORCPT ); Wed, 27 Apr 2022 11:44:45 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64A4A32040 for ; Wed, 27 Apr 2022 08:41:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C5811B82871 for ; Wed, 27 Apr 2022 15:41:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59DA3C385B1; Wed, 27 Apr 2022 15:41:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651074085; bh=aWusfsVygd8PAIfwUe+vR4X18nkIBQqpy5W1lvkfkOw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BQw2buXiViwWIPOzLlHloHm322hqN7qjqG/WnsJFtxgGlmDcBpBDw+fHycib7AZvW quoHprHaeUNR8spNUbD2oRUGhNv1ZJdWPMcEluv47g6zapI4JbDSNgUAeWExm0eMiH ySDYWo+gdIji8IqLOj9Gc/PBijTkToXvw+qRmkyNrxv6k6guWgY3SUD71G2nlYGc+I P/14PVh2VLVo2sDdhXQqiNdChYKDLkX4fF9glEUfoT2miUq32BXjc4VKw9/bkXz64B NSny9EoKjoU7hqQ5FVpJ03ij9oDzA7Kv+YV2OU18UUp9qbyfh3tlKJyjCUyRqNUQaA BcOKEnaV2SUkQ== From: Jakub Kicinski To: davem@davemloft.net, pabeni@redhat.com Cc: netdev@vger.kernel.org, Jakub Kicinski , LinoSanfilippo@gmx.de Subject: [PATCH net-next 07/14] slic: remove a copy of the NAPI_POLL_WEIGHT define Date: Wed, 27 Apr 2022 08:41:04 -0700 Message-Id: <20220427154111.529975-8-kuba@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220427154111.529975-1-kuba@kernel.org> References: <20220427154111.529975-1-kuba@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Defining local versions of NAPI_POLL_WEIGHT with the same values in the drivers just makes refactoring harder. Signed-off-by: Jakub Kicinski --- CC: LinoSanfilippo@gmx.de --- drivers/net/ethernet/alacritech/slic.h | 2 -- drivers/net/ethernet/alacritech/slicoss.c | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/alacritech/slic.h b/drivers/net/ethernet/alacritech/slic.h index 3add305d34b4..4eecbdfff3ff 100644 --- a/drivers/net/ethernet/alacritech/slic.h +++ b/drivers/net/ethernet/alacritech/slic.h @@ -265,8 +265,6 @@ #define SLIC_NUM_STAT_DESC_ARRAYS 4 #define SLIC_INVALID_STAT_DESC_IDX 0xffffffff -#define SLIC_NAPI_WEIGHT 64 - #define SLIC_UPR_LSTAT 0 #define SLIC_UPR_CONFIG 1 diff --git a/drivers/net/ethernet/alacritech/slicoss.c b/drivers/net/ethernet/alacritech/slicoss.c index 1fc9a1cd3ef8..ce353b0c02a3 100644 --- a/drivers/net/ethernet/alacritech/slicoss.c +++ b/drivers/net/ethernet/alacritech/slicoss.c @@ -1803,7 +1803,7 @@ static int slic_probe(struct pci_dev *pdev, const struct pci_device_id *ent) goto unmap; } - netif_napi_add(dev, &sdev->napi, slic_poll, SLIC_NAPI_WEIGHT); + netif_napi_add(dev, &sdev->napi, slic_poll, NAPI_POLL_WEIGHT); netif_carrier_off(dev); err = register_netdev(dev); -- 2.34.1