From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19E22C433F5 for ; Wed, 27 Apr 2022 16:58:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243650AbiD0RBp (ORCPT ); Wed, 27 Apr 2022 13:01:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243639AbiD0RAX (ORCPT ); Wed, 27 Apr 2022 13:00:23 -0400 Received: from 1wt.eu (wtarreau.pck.nerim.net [62.212.114.60]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1C939638B; Wed, 27 Apr 2022 09:57:03 -0700 (PDT) Received: (from willy@localhost) by pcw.home.local (8.15.2/8.15.2/Submit) id 23RGunuo003835; Wed, 27 Apr 2022 18:56:49 +0200 Date: Wed, 27 Apr 2022 18:56:49 +0200 From: Willy Tarreau To: Eric Dumazet Cc: kernel test robot , netdev , kbuild-all@lists.01.org, Jakub Kicinski , Moshe Kol , Yossi Gilad , Amit Klein , LKML , "Jason A . Donenfeld" Subject: Re: [PATCH net 1/7] secure_seq: return the full 64-bit of the siphash Message-ID: <20220427165649.GA3756@1wt.eu> References: <20220427065233.2075-2-w@1wt.eu> <202204271705.VrWNPv7n-lkp@intel.com> <20220427100714.GC1724@1wt.eu> <20220427163554.GA3746@1wt.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 27, 2022 at 09:50:06AM -0700, Eric Dumazet wrote: > On Wed, Apr 27, 2022 at 9:35 AM Willy Tarreau wrote: > > > > On Wed, Apr 27, 2022 at 12:07:14PM +0200, Willy Tarreau wrote: > > > On Wed, Apr 27, 2022 at 05:56:41PM +0800, kernel test robot wrote: > > > > Hi Willy, > > > > > > > > I love your patch! Yet something to improve: > > > > > > > > [auto build test ERROR on net/master] > > > > > > > > url: https://github.com/intel-lab-lkp/linux/commits/Willy-Tarreau/insufficient-TCP-source-port-randomness/20220427-145651 > > > > base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 71cffebf6358a7f5031f5b208bbdc1cb4db6e539 > > > > config: i386-randconfig-r026-20220425 (https://download.01.org/0day-ci/archive/20220427/202204271705.VrWNPv7n-lkp@intel.com/config) > > > > compiler: gcc-11 (Debian 11.2.0-20) 11.2.0 > > > > reproduce (this is a W=1 build): > > > > # https://github.com/intel-lab-lkp/linux/commit/01b26e522b598adf346b809075880feab3dcdc08 > > > > git remote add linux-review https://github.com/intel-lab-lkp/linux > > > > git fetch --no-tags linux-review Willy-Tarreau/insufficient-TCP-source-port-randomness/20220427-145651 > > > > git checkout 01b26e522b598adf346b809075880feab3dcdc08 > > > > # save the config file > > > > mkdir build_dir && cp config build_dir/.config > > > > make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash > > > > > > > > If you fix the issue, kindly add following tag as appropriate > > > > Reported-by: kernel test robot > > > > > > > > All errors (new ones prefixed by >>): > > > > > > > > ld: net/ipv4/inet_hashtables.o: in function `__inet_hash_connect': > > > > >> inet_hashtables.c:(.text+0x187d): undefined reference to `__umoddi3' > > > > > > Argh! indeed, we spoke about using div_u64_rem() at the beginning and > > > that one vanished over time. Will respin it. > > > > I fixed it, built it for i386 and x86_64, tested it on x86_64 and confirmed > > that it still does what I need. The change is only this: > > > > - offset = (READ_ONCE(table_perturb[index]) + (port_offset >> 32)) % remaining; > > + div_u64_rem(READ_ONCE(table_perturb[index]) + (port_offset >> 32), remaining, &offset); > > > > I'll send a v2 series in a few hours if there are no more comments. > > We really do not need 33 bits here. > > I would suggest using a 32bit divide. > > offset = READ_ONCE(table_perturb[index]) + (port_offset >> 32)); > offset %= remaining; Yeah much better indeed, I'll do that. Thanks Eric! Willy From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============0449711527064556079==" MIME-Version: 1.0 From: Willy Tarreau To: kbuild-all@lists.01.org Subject: Re: [PATCH net 1/7] secure_seq: return the full 64-bit of the siphash Date: Wed, 27 Apr 2022 18:56:49 +0200 Message-ID: <20220427165649.GA3756@1wt.eu> In-Reply-To: List-Id: --===============0449711527064556079== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Wed, Apr 27, 2022 at 09:50:06AM -0700, Eric Dumazet wrote: > On Wed, Apr 27, 2022 at 9:35 AM Willy Tarreau wrote: > > > > On Wed, Apr 27, 2022 at 12:07:14PM +0200, Willy Tarreau wrote: > > > On Wed, Apr 27, 2022 at 05:56:41PM +0800, kernel test robot wrote: > > > > Hi Willy, > > > > > > > > I love your patch! Yet something to improve: > > > > > > > > [auto build test ERROR on net/master] > > > > > > > > url: https://github.com/intel-lab-lkp/linux/commits/Willy-Tarrea= u/insufficient-TCP-source-port-randomness/20220427-145651 > > > > base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.g= it 71cffebf6358a7f5031f5b208bbdc1cb4db6e539 > > > > config: i386-randconfig-r026-20220425 (https://download.01.org/0day= -ci/archive/20220427/202204271705.VrWNPv7n-lkp(a)intel.com/config) > > > > compiler: gcc-11 (Debian 11.2.0-20) 11.2.0 > > > > reproduce (this is a W=3D1 build): > > > > # https://github.com/intel-lab-lkp/linux/commit/01b26e522b5= 98adf346b809075880feab3dcdc08 > > > > git remote add linux-review https://github.com/intel-lab-lk= p/linux > > > > git fetch --no-tags linux-review Willy-Tarreau/insufficient= -TCP-source-port-randomness/20220427-145651 > > > > git checkout 01b26e522b598adf346b809075880feab3dcdc08 > > > > # save the config file > > > > mkdir build_dir && cp config build_dir/.config > > > > make W=3D1 O=3Dbuild_dir ARCH=3Di386 SHELL=3D/bin/bash > > > > > > > > If you fix the issue, kindly add following tag as appropriate > > > > Reported-by: kernel test robot > > > > > > > > All errors (new ones prefixed by >>): > > > > > > > > ld: net/ipv4/inet_hashtables.o: in function `__inet_hash_connect= ': > > > > >> inet_hashtables.c:(.text+0x187d): undefined reference to `__umod= di3' > > > > > > Argh! indeed, we spoke about using div_u64_rem() at the beginning and > > > that one vanished over time. Will respin it. > > > > I fixed it, built it for i386 and x86_64, tested it on x86_64 and confi= rmed > > that it still does what I need. The change is only this: > > > > - offset =3D (READ_ONCE(table_perturb[index]) + (port_offset >> 3= 2)) % remaining; > > + div_u64_rem(READ_ONCE(table_perturb[index]) + (port_offset >> 3= 2), remaining, &offset); > > > > I'll send a v2 series in a few hours if there are no more comments. > = > We really do not need 33 bits here. > = > I would suggest using a 32bit divide. > = > offset =3D READ_ONCE(table_perturb[index]) + (port_offset >> 32)); > offset %=3D remaining; Yeah much better indeed, I'll do that. Thanks Eric! Willy --===============0449711527064556079==--