Re: [PATCH v5 4/8] crypto: x86/aesni-xctr: Add accelerated implementation of XCTR

From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: Re: [PATCH v5 4/8] crypto: x86/aesni-xctr: Add accelerated implementation of XCTR
Date: Wed, 27 Apr 2022 17:56:39 +0800	[thread overview]
Message-ID: <202204271747.9NI6Iyxe-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 3144 bytes --]

CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
In-Reply-To: <20220427003759.1115361-5-nhuck@google.com>
References: <20220427003759.1115361-5-nhuck@google.com>
TO: Nathan Huckleberry <nhuck@google.com>

Hi Nathan,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on herbert-cryptodev-2.6/master]
[also build test WARNING on herbert-crypto-2.6/master linus/master v5.18-rc4 next-20220427]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Nathan-Huckleberry/crypto-HCTR2-support/20220427-084044
base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
:::::: branch date: 9 hours ago
:::::: commit date: 9 hours ago
config: i386-randconfig-s002-20220425 (https://download.01.org/0day-ci/archive/20220427/202204271747.9NI6Iyxe-lkp(a)intel.com/config)
compiler: gcc-11 (Debian 11.2.0-20) 11.2.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://github.com/intel-lab-lkp/linux/commit/00cd244c8a1bd9623a271407bf10b99c01884ef5
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Nathan-Huckleberry/crypto-HCTR2-support/20220427-084044
        git checkout 00cd244c8a1bd9623a271407bf10b99c01884ef5
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=i386 SHELL=/bin/bash arch/x86/crypto/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

sparse warnings: (new ones prefixed by >>)
>> arch/x86/crypto/aesni-intel_glue.c:1287:1: sparse: sparse: unused label 'unregister_aeads'

vim +/unregister_aeads +1287 arch/x86/crypto/aesni-intel_glue.c

00cd244c8a1bd9 Nathan Huckleberry 2022-04-27  1284  
85671860caaca2 Herbert Xu         2016-11-22  1285  	return 0;
85671860caaca2 Herbert Xu         2016-11-22  1286  
00cd244c8a1bd9 Nathan Huckleberry 2022-04-27 @1287  unregister_aeads:
00cd244c8a1bd9 Nathan Huckleberry 2022-04-27  1288  	simd_unregister_aeads(aesni_aeads, ARRAY_SIZE(aesni_aeads),
00cd244c8a1bd9 Nathan Huckleberry 2022-04-27  1289  				aesni_simd_aeads);
85671860caaca2 Herbert Xu         2016-11-22  1290  unregister_skciphers:
8b56d3488d8755 Eric Biggers       2019-03-10  1291  	simd_unregister_skciphers(aesni_skciphers, ARRAY_SIZE(aesni_skciphers),
8b56d3488d8755 Eric Biggers       2019-03-10  1292  				  aesni_simd_skciphers);
07269559ac0bf7 Eric Biggers       2019-06-02  1293  unregister_cipher:
07269559ac0bf7 Eric Biggers       2019-06-02  1294  	crypto_unregister_alg(&aesni_cipher_alg);
af05b3009b6b10 Herbert Xu         2015-05-28  1295  	return err;
54b6a1bd5364ac Huang Ying         2009-01-18  1296  }
54b6a1bd5364ac Huang Ying         2009-01-18  1297  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp