From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74383C433EF for ; Thu, 28 Apr 2022 02:00:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DD4796B0072; Wed, 27 Apr 2022 22:00:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D86156B0073; Wed, 27 Apr 2022 22:00:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C4C4A6B0075; Wed, 27 Apr 2022 22:00:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id B6E386B0072 for ; Wed, 27 Apr 2022 22:00:31 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9233129020 for ; Thu, 28 Apr 2022 02:00:31 +0000 (UTC) X-FDA: 79404633462.20.B3E7851 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by imf27.hostedemail.com (Postfix) with ESMTP id 084FF40052 for ; Thu, 28 Apr 2022 02:00:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651111230; x=1682647230; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=sap1oKZx9Z+PW5dPryKMMP2ypZLRROcC/ZmalbrLVDs=; b=gAFBoxlcoO0/nczSQVVOFY2/LEQR3Tv+fy9OywpsxPbuw4HLz/WUGfye Amc9/kHSNbbltH0nIwvS1wptZkG+zF2DM4racdj82SZqrJOrXuFrtJzJX yNBcA6P9tM2cLbK5EwPoDW5kKOvPmPhDaj82fT4IIX3dd8Mx6QbvgRnlk Ucjx6HeSxCdPssbgiL0n2+L/7QqWsvLl/kNYVxbY+sr+6y4D+9tEacCae WSX02sZrLPiLv9+vKQhVocqMs0QitfYZ4n74aEq9VTWbo20HJC7j7eu0h 4A3Sztov6gpKHVx8m17RSxudAOMBO5m6jCy6h7mgfyESCGi+wUeNzR+Ju Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10330"; a="326621231" X-IronPort-AV: E=Sophos;i="5.90,294,1643702400"; d="scan'208";a="326621231" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2022 19:00:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,294,1643702400"; d="scan'208";a="565380075" Received: from lkp-server01.sh.intel.com (HELO 5056e131ad90) ([10.239.97.150]) by fmsmga007.fm.intel.com with ESMTP; 27 Apr 2022 19:00:24 -0700 Received: from kbuild by 5056e131ad90 with local (Exim 4.95) (envelope-from ) id 1njtSB-0004y4-Pu; Thu, 28 Apr 2022 02:00:23 +0000 Date: Thu, 28 Apr 2022 09:59:48 +0800 From: kernel test robot To: Xu Yu , linux-mm@kvack.org Cc: kbuild-all@lists.01.org, akpm@linux-foundation.org, naoya.horiguchi@nec.com, shy828301@gmail.com Subject: Re: [PATCH 2/2] mm/huge_memory: do not overkill when splitting huge_zero_page Message-ID: <202204280339.5Akc9USp-lkp@intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 084FF40052 X-Stat-Signature: btedemdtqzarkdxdeas8dutap5c976hh Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=gAFBoxlc; spf=none (imf27.hostedemail.com: domain of lkp@intel.com has no SPF policy when checking 134.134.136.31) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com X-HE-Tag: 1651111227-946256 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Xu, Thank you for the patch! Yet something to improve: [auto build test ERROR on hnaz-mm/master] url: https://github.com/intel-lab-lkp/linux/commits/Xu-Yu/mm-memory-failure-rework-fix-on-huge_zero_page-splitting/20220427-141253 base: https://github.com/hnaz/linux-mm master config: arc-randconfig-r005-20220425 (https://download.01.org/0day-ci/archive/20220428/202204280339.5Akc9USp-lkp@intel.com/config) compiler: arc-elf-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/988ec6e274e00e5706be7590a4a39427fbe856b1 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Xu-Yu/mm-memory-failure-rework-fix-on-huge_zero_page-splitting/20220427-141253 git checkout 988ec6e274e00e5706be7590a4a39427fbe856b1 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): In file included from include/asm-generic/bug.h:5, from arch/arc/include/asm/bug.h:30, from include/linux/bug.h:5, from include/linux/mmdebug.h:5, from include/linux/mm.h:6, from mm/huge_memory.c:8: mm/huge_memory.c: In function 'split_huge_page_to_list': >> include/linux/compiler.h:56:45: error: invalid use of void expression 56 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) | ^ include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var' 58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) | ^~~~ mm/huge_memory.c:2553:9: note: in expansion of macro 'if' 2553 | if (VM_WARN_ON_ONCE_PAGE(is_huge_zero_page(head), head)) | ^~ >> include/linux/compiler.h:56:45: error: invalid use of void expression 56 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) | ^ include/linux/compiler.h:58:61: note: in definition of macro '__trace_if_var' 58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) | ^~~~ mm/huge_memory.c:2553:9: note: in expansion of macro 'if' 2553 | if (VM_WARN_ON_ONCE_PAGE(is_huge_zero_page(head), head)) | ^~ >> include/linux/compiler.h:56:45: error: invalid use of void expression 56 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) | ^ include/linux/compiler.h:69:10: note: in definition of macro '__trace_if_value' 69 | (cond) ? \ | ^~~~ include/linux/compiler.h:56:28: note: in expansion of macro '__trace_if_var' 56 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) | ^~~~~~~~~~~~~~ mm/huge_memory.c:2553:9: note: in expansion of macro 'if' 2553 | if (VM_WARN_ON_ONCE_PAGE(is_huge_zero_page(head), head)) | ^~ vim +56 include/linux/compiler.h 2bcd521a684cc94 Steven Rostedt 2008-11-21 50 2bcd521a684cc94 Steven Rostedt 2008-11-21 51 #ifdef CONFIG_PROFILE_ALL_BRANCHES 2bcd521a684cc94 Steven Rostedt 2008-11-21 52 /* 2bcd521a684cc94 Steven Rostedt 2008-11-21 53 * "Define 'is'", Bill Clinton 2bcd521a684cc94 Steven Rostedt 2008-11-21 54 * "Define 'if'", Steven Rostedt 2bcd521a684cc94 Steven Rostedt 2008-11-21 55 */ a15fd609ad53a63 Linus Torvalds 2019-03-20 @56 #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) a15fd609ad53a63 Linus Torvalds 2019-03-20 57 -- 0-DAY CI Kernel Test Service https://01.org/lkp