From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F2FEEA6 for ; Thu, 28 Apr 2022 08:11:36 +0000 (UTC) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 4B3DE3200033; Thu, 28 Apr 2022 04:11:34 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 28 Apr 2022 04:11:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1651133493; x=1651219893; bh=zhx4d/dBHT pW4W1OKZ4iXHkQAtUQxcXTyp97K6x+HYQ=; b=pFbjr0eXgD79GamR8HiFg2cHKF 2fl1+6DilEH6u6u7qHnebZo7pX2UBZ9S168D4JI8ryxEpqR2Eha8w66XTsj6D8h/ wrkCC07e1ULAH34JKLtFodWK+VvJIGZ91R/uc3a1uETArsX+92219SeKbKvGDUep 8dG5iJhRyqpdI6/Rk0X3dOksQ6POqKQYnmvfsi0qUUhGaQ4im46c/fZwYiKlgY5R 1WasH7xwGmRFkrXwUTpKJotZZWrQzMEyAPLQnBl1SStvOQ7Ywvbz1+fajHICHUwS cWbw1wrBcWA3uhar7Sgm0mgM7mfoncb+0a6QGDnra3ii7+S8YRHFJW/qFhHw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1651133493; x= 1651219893; bh=zhx4d/dBHTpW4W1OKZ4iXHkQAtUQxcXTyp97K6x+HYQ=; b=S MmOK5aAjnb3bCezwArQMGfxK81ncC8TnKiVwG7b0f+UZ9ehGY0XNOfVDDOblrpYN Vr9UaIA/jnpv9WEuC1N6Ido7agp2Dwmls9vVsGItfvGvkx/t8oWaQk5hB5zKc8Ld LU+Y1QweFE81HfHHma70jt242Ee1Oq4Vlbmsq7CLmj9bAiqgMYkDRAtn4U1EMHuS D/IsZtPSn4dJob5+5LP4BFHA69LdQTHNJsXzlYfPKzdVxZqO8JTjNLAh9wtDu36g SydKU2teXFmKD6jScXdlTX2h27JCHP2pkqdSJiEd6Zw+ki8OY+l4jzEQnwSj+gQ9 TL94D9bVhvhzOqZnsmaKQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudejucetufdoteggodetrfdotffvucfrrh hofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurh epfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrgihimhgvucft ihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtthgvrh hnpeejgeeiveevvdfgffeftdevuefhheduveejieefgeejveeuhfetkeelgfevteefffen ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrgigih hmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 28 Apr 2022 04:11:32 -0400 (EDT) Date: Thu, 28 Apr 2022 10:11:30 +0200 From: Maxime Ripard To: Paul Kocialkowski Cc: Jernej =?utf-8?Q?=C5=A0krabec?= , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Yong Deng , Mauro Carvalho Chehab , Chen-Yu Tsai , Samuel Holland , Laurent Pinchart , Thomas Petazzoni Subject: Re: [PATCH v4 43/45] media: sun6i-csi: Detect the availability of the ISP Message-ID: <20220428081130.6deusqgnrsgqdp3e@houat> References: <20220415152811.636419-1-paul.kocialkowski@bootlin.com> <20220415152811.636419-44-paul.kocialkowski@bootlin.com> <2029179.KlZ2vcFHjT@jernej-laptop> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vi7rcbrvgeo53dt4" Content-Disposition: inline In-Reply-To: --vi7rcbrvgeo53dt4 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 28, 2022 at 09:55:56AM +0200, Paul Kocialkowski wrote: > Hi Jernej, >=20 > Thanks a lot for all your reviews! >=20 > On Wed 27 Apr 22, 22:07, Jernej =C5=A0krabec wrote: > > Dne petek, 15. april 2022 ob 17:28:09 CEST je Paul Kocialkowski napisal= (a): > > > Add a helper to detect whether the ISP is available and connected > > > and store the indication in a driver-wide variable. > > >=20 > > > Signed-off-by: Paul Kocialkowski > > > --- > > > .../platform/sunxi/sun6i-csi/sun6i_csi.c | 33 +++++++++++++++++= ++ > > > .../platform/sunxi/sun6i-csi/sun6i_csi.h | 3 ++ > > > 2 files changed, 36 insertions(+) > > >=20 > > > diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c > > > b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c index > > > a88deb8ba1e7..f185cbd113c7 100644 > > > --- a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c > > > +++ b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c > > > @@ -25,6 +25,35 @@ > > > #include "sun6i_csi_capture.h" > > > #include "sun6i_csi_reg.h" > > >=20 > > > +/* ISP */ > > > + > > > +static bool sun6i_csi_isp_detect(struct sun6i_csi_device *csi_dev) > > > +{ > > > + struct device *dev =3D csi_dev->dev; > > > + struct fwnode_handle *handle =3D NULL; > > > + > > > + /* ISP is not available if disabled in kernel config. */ > > > + if (!IS_ENABLED(CONFIG_VIDEO_SUN6I_ISP)) > >=20 > > Where is this symbol defined? >=20 > That is defined through Kconfig's auto-generated header, from the associa= ted > option for the ISP driver. It is defined in the ISP support series so this > will effectively always be false for now. Can the ISP be compiled as a module, but the CSI driver built-in? If so, that would create a dependency from the kernel image to a module, which won't compile. Maxime --vi7rcbrvgeo53dt4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYmpMMgAKCRDj7w1vZxhR xR9JAQCzUJ3nSywMzMfmZf2THjuGSWtHrnB1gUI5bzeoJHD/bgD9E0zo+xuSxJ1g MWMoFbBta8oAjxNxO6BGTkd2mhGgTg4= =MHSM -----END PGP SIGNATURE----- --vi7rcbrvgeo53dt4-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7357BC433F5 for ; Thu, 28 Apr 2022 08:12:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=P7V6WDWgtez7l4AdQDquGu7gmbalB6tI0UG9SfKBLwk=; b=0ztd1FT6jeVvncVsmtUkVdwtho 8T3se17GYMTUdDtUudrHpZgSFfGA9QG1D8JnTXyfmrbxPkHVrNmo0VhxUJgBMzfvRna+mg71eMOaE 116SFYKJYFsrF0HscLj12a5Cp35d0dB20vky/kXnc19r+vhBg6GEtGfByl8OsK98QZ8gDrwcflzpv +2HWl2xdHaWMfo1w4JrLnLqS0FIsxcjkpAO7CQc75wGXmn4F5HbaevgLyxMs7oYzWmgity8h6T3SY zoRTqNo0hcpOp98xyg1SojV8hHkjNF8t7yt0aUwozsPOzQXewtzYHaiQ7sDlOUT10VHs6HZzxe+w4 ja35VYlA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1njzFh-005Qgt-8I; Thu, 28 Apr 2022 08:11:53 +0000 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1njzFR-005QYa-U7 for linux-arm-kernel@lists.infradead.org; Thu, 28 Apr 2022 08:11:40 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 4B3DE3200033; Thu, 28 Apr 2022 04:11:34 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 28 Apr 2022 04:11:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1651133493; x=1651219893; bh=zhx4d/dBHT pW4W1OKZ4iXHkQAtUQxcXTyp97K6x+HYQ=; b=pFbjr0eXgD79GamR8HiFg2cHKF 2fl1+6DilEH6u6u7qHnebZo7pX2UBZ9S168D4JI8ryxEpqR2Eha8w66XTsj6D8h/ wrkCC07e1ULAH34JKLtFodWK+VvJIGZ91R/uc3a1uETArsX+92219SeKbKvGDUep 8dG5iJhRyqpdI6/Rk0X3dOksQ6POqKQYnmvfsi0qUUhGaQ4im46c/fZwYiKlgY5R 1WasH7xwGmRFkrXwUTpKJotZZWrQzMEyAPLQnBl1SStvOQ7Ywvbz1+fajHICHUwS cWbw1wrBcWA3uhar7Sgm0mgM7mfoncb+0a6QGDnra3ii7+S8YRHFJW/qFhHw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1651133493; x= 1651219893; bh=zhx4d/dBHTpW4W1OKZ4iXHkQAtUQxcXTyp97K6x+HYQ=; b=S MmOK5aAjnb3bCezwArQMGfxK81ncC8TnKiVwG7b0f+UZ9ehGY0XNOfVDDOblrpYN Vr9UaIA/jnpv9WEuC1N6Ido7agp2Dwmls9vVsGItfvGvkx/t8oWaQk5hB5zKc8Ld LU+Y1QweFE81HfHHma70jt242Ee1Oq4Vlbmsq7CLmj9bAiqgMYkDRAtn4U1EMHuS D/IsZtPSn4dJob5+5LP4BFHA69LdQTHNJsXzlYfPKzdVxZqO8JTjNLAh9wtDu36g SydKU2teXFmKD6jScXdlTX2h27JCHP2pkqdSJiEd6Zw+ki8OY+l4jzEQnwSj+gQ9 TL94D9bVhvhzOqZnsmaKQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudejucetufdoteggodetrfdotffvucfrrh hofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurh epfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrgihimhgvucft ihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtthgvrh hnpeejgeeiveevvdfgffeftdevuefhheduveejieefgeejveeuhfetkeelgfevteefffen ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrgigih hmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 28 Apr 2022 04:11:32 -0400 (EDT) Date: Thu, 28 Apr 2022 10:11:30 +0200 From: Maxime Ripard To: Paul Kocialkowski Cc: Jernej =?utf-8?Q?=C5=A0krabec?= , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Yong Deng , Mauro Carvalho Chehab , Chen-Yu Tsai , Samuel Holland , Laurent Pinchart , Thomas Petazzoni Subject: Re: [PATCH v4 43/45] media: sun6i-csi: Detect the availability of the ISP Message-ID: <20220428081130.6deusqgnrsgqdp3e@houat> References: <20220415152811.636419-1-paul.kocialkowski@bootlin.com> <20220415152811.636419-44-paul.kocialkowski@bootlin.com> <2029179.KlZ2vcFHjT@jernej-laptop> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220428_011138_085480_234901A5 X-CRM114-Status: GOOD ( 23.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0871117188375402860==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0871117188375402860== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vi7rcbrvgeo53dt4" Content-Disposition: inline --vi7rcbrvgeo53dt4 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 28, 2022 at 09:55:56AM +0200, Paul Kocialkowski wrote: > Hi Jernej, >=20 > Thanks a lot for all your reviews! >=20 > On Wed 27 Apr 22, 22:07, Jernej =C5=A0krabec wrote: > > Dne petek, 15. april 2022 ob 17:28:09 CEST je Paul Kocialkowski napisal= (a): > > > Add a helper to detect whether the ISP is available and connected > > > and store the indication in a driver-wide variable. > > >=20 > > > Signed-off-by: Paul Kocialkowski > > > --- > > > .../platform/sunxi/sun6i-csi/sun6i_csi.c | 33 +++++++++++++++++= ++ > > > .../platform/sunxi/sun6i-csi/sun6i_csi.h | 3 ++ > > > 2 files changed, 36 insertions(+) > > >=20 > > > diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c > > > b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c index > > > a88deb8ba1e7..f185cbd113c7 100644 > > > --- a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c > > > +++ b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c > > > @@ -25,6 +25,35 @@ > > > #include "sun6i_csi_capture.h" > > > #include "sun6i_csi_reg.h" > > >=20 > > > +/* ISP */ > > > + > > > +static bool sun6i_csi_isp_detect(struct sun6i_csi_device *csi_dev) > > > +{ > > > + struct device *dev =3D csi_dev->dev; > > > + struct fwnode_handle *handle =3D NULL; > > > + > > > + /* ISP is not available if disabled in kernel config. */ > > > + if (!IS_ENABLED(CONFIG_VIDEO_SUN6I_ISP)) > >=20 > > Where is this symbol defined? >=20 > That is defined through Kconfig's auto-generated header, from the associa= ted > option for the ISP driver. It is defined in the ISP support series so this > will effectively always be false for now. Can the ISP be compiled as a module, but the CSI driver built-in? If so, that would create a dependency from the kernel image to a module, which won't compile. Maxime --vi7rcbrvgeo53dt4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYmpMMgAKCRDj7w1vZxhR xR9JAQCzUJ3nSywMzMfmZf2THjuGSWtHrnB1gUI5bzeoJHD/bgD9E0zo+xuSxJ1g MWMoFbBta8oAjxNxO6BGTkd2mhGgTg4= =MHSM -----END PGP SIGNATURE----- --vi7rcbrvgeo53dt4-- --===============0871117188375402860== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0871117188375402860==--