All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Steve Glendinning <steve.glendinning@shawell.net>,
	UNGLinuxDriver@microchip.com, Oliver Neukum <oneukum@suse.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org, linux-usb@vger.kernel.org,
	Andre Edich <andre.edich@microchip.com>,
	Martyn Welch <martyn.welch@collabora.com>,
	Gabriel Hojda <ghojda@yo2urs.ro>,
	Christoph Fritz <chf.fritz@googlemail.com>,
	Lino Sanfilippo <LinoSanfilippo@gmx.de>,
	Philipp Rosenberger <p.rosenberger@kunbus.com>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Russell King <linux@armlinux.org.uk>
Subject: Re: [PATCH net-next 0/7] Polling be gone on LAN95xx
Date: Thu, 28 Apr 2022 14:19:56 +0200	[thread overview]
Message-ID: <20220428121956.GA18418@wunner.de> (raw)
In-Reply-To: <20220427123715.GC17577@pengutronix.de>

On Wed, Apr 27, 2022 at 02:37:15PM +0200, Oleksij Rempel wrote:
> On Wed, Apr 27, 2022 at 07:48:00AM +0200, Lukas Wunner wrote:
> > Do away with link status polling on LAN95XX USB Ethernet
> > and rely on interrupts instead, thereby reducing bus traffic,
> > CPU overhead and improving interface bringup latency.
> > 
> > The meat of the series is in patch [5/7].  The preceding and
> > following patches are various cleanups to prepare for and
> > adjust to interrupt-driven link state detection.
> 
> Tested-by: Oleksij Rempel <o.rempel@pengutronix.de>
> 
> Tested on:
> - LAN9514 (RPi2)
> - LAN9512 (EVB)
> - LAN9500 (EVB)

Thanks a lot for testing, this helps greatly.

> On USB unplug i get some not usable kernel message, but it is not the
> show stopper for me:
> smsc95xx 1-1.4.1:1.0 eth1: Error updating MAC full duplex mode
> smsc95xx 1-1.4.1:1.0 eth1: hardware isn't capable of remote wakeup

Okay, I've amended patch [4/7] to silence the first of these messages
if the error is caused by hot-removal.

The second message isn't related to this series, I'll address that
separately at a later point in time.

Thanks,

Lukas

  reply	other threads:[~2022-04-28 12:20 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-27  5:48 [PATCH net-next 0/7] Polling be gone on LAN95xx Lukas Wunner
2022-04-27  5:48 ` [PATCH net-next 1/7] usbnet: Run unregister_netdev() before unbind() again Lukas Wunner
2022-04-27  7:44   ` Oliver Neukum
2022-04-27  7:45   ` Oliver Neukum
2022-04-27  5:48 ` [PATCH net-next 2/7] usbnet: smsc95xx: Don't clear read-only PHY interrupt Lukas Wunner
2022-04-27  5:48 ` [PATCH net-next 3/7] usbnet: smsc95xx: Don't reset PHY behind PHY driver's back Lukas Wunner
2022-04-27  5:48 ` [PATCH net-next 4/7] usbnet: smsc95xx: Avoid link settings race on interrupt reception Lukas Wunner
2022-04-27 11:50   ` Andrew Lunn
2022-04-27  5:48 ` [PATCH net-next 5/7] usbnet: smsc95xx: Forward PHY interrupts to PHY driver to avoid polling Lukas Wunner
2022-04-27 12:03   ` Andrew Lunn
2022-04-27 12:26   ` Andrew Lunn
2022-04-27  5:48 ` [PATCH net-next 6/7] net: phy: smsc: Cache interrupt mask Lukas Wunner
2022-04-27 12:14   ` Andrew Lunn
2022-04-27 12:51     ` Lukas Wunner
2022-04-27  5:48 ` [PATCH net-next 7/7] net: phy: smsc: Cope with hot-removal in interrupt handler Lukas Wunner
2022-04-27  7:46   ` Oliver Neukum
2022-04-27 12:37 ` [PATCH net-next 0/7] Polling be gone on LAN95xx Oleksij Rempel
2022-04-28 12:19   ` Lukas Wunner [this message]
2022-05-02 20:33 ` Ferry Toth
2022-05-03  8:26   ` Lukas Wunner
2022-05-03 14:26     ` Ferry Toth
2022-05-04  8:15       ` Lukas Wunner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220428121956.GA18418@wunner.de \
    --to=lukas@wunner.de \
    --cc=LinoSanfilippo@gmx.de \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=andre.edich@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=chf.fritz@googlemail.com \
    --cc=davem@davemloft.net \
    --cc=ghojda@yo2urs.ro \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=martyn.welch@collabora.com \
    --cc=netdev@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=oneukum@suse.com \
    --cc=p.rosenberger@kunbus.com \
    --cc=pabeni@redhat.com \
    --cc=steve.glendinning@shawell.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.