From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from list by lists.gnu.org with archive (Exim 4.90_1)
	id 1nk3RE-0007hb-47
	for mharc-grub-devel@gnu.org; Thu, 28 Apr 2022 08:40:04 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:33296)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <dkiper@net-space.pl>)
 id 1nk3R9-0007fZ-V5
 for grub-devel@gnu.org; Thu, 28 Apr 2022 08:40:01 -0400
Received: from dibed.net-space.pl ([84.10.22.86]:36983)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_3DES_EDE_CBC_SHA1:192)
 (Exim 4.90_1) (envelope-from <dkiper@net-space.pl>)
 id 1nk3Qa-0007Bz-IM
 for grub-devel@gnu.org; Thu, 28 Apr 2022 08:39:30 -0400
Received: from router-fw.i.net-space.pl ([192.168.52.1]:44760 "EHLO
 tomti.i.net-space.pl") by router-fw-old.i.net-space.pl with ESMTP
 id S2137732AbiD1MjS (ORCPT <rfc822;grub-devel@gnu.org>);
 Thu, 28 Apr 2022 14:39:18 +0200
X-Comment: RFC 2476 MSA function at dibed.net-space.pl logged sender identity
 as: dkiper
Date: Thu, 28 Apr 2022 14:39:12 +0200
From: Daniel Kiper <dkiper@net-space.pl>
To: Glenn Washburn <development@efficientek.com>
Cc: grub-devel@gnu.org, Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>,
 Patrick Steinhardt <ps@pks.im>, John Lane <john@lane.uk.net>
Subject: Re: [PATCH v9 3/7] cryptodisk: Add --header option to cryptomount
 and fail to implement it in the backends
Message-ID: <20220428123912.zpb5hrkdtql46ph5@tomti.i.net-space.pl>
References: <cover.1649658484.git.development@efficientek.com>
 <1b2055ac5dff02889c2306951f173a2cdcaca6ce.1649658484.git.development@efficientek.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1b2055ac5dff02889c2306951f173a2cdcaca6ce.1649658484.git.development@efficientek.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Received-SPF: pass client-ip=84.10.22.86; envelope-from=dkiper@net-space.pl;
 helo=dibed.net-space.pl
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: The development of GNU GRUB <grub-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/grub-devel>,
 <mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/grub-devel>,
 <mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 28 Apr 2022 12:40:03 -0000

On Mon, Apr 11, 2022 at 06:40:24AM +0000, Glenn Washburn wrote:
> Add a --header (short -H) option to cryptomount which takes a file argument.
> Pass the file to the backends via cargs struct and cause the backends to
> fail when passed a header. Detached header file support will be added later
> for individual backends.
>
> Signed-off-by: John Lane <john@lane.uk.net>
> GNUtoo@cyberdimension.org: rebase, patch split, small fixes, commit message
> Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
> development@efficientek.com: rebase, rework for cryptomount parameter passing,
>   improve commit message
> Signed-off-by: Glenn Washburn <development@efficientek.com>

Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

Daniel