From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 186A0C433EF for ; Thu, 28 Apr 2022 21:36:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237155AbiD1VjX (ORCPT ); Thu, 28 Apr 2022 17:39:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236678AbiD1VjV (ORCPT ); Thu, 28 Apr 2022 17:39:21 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5FFFC9682B for ; Thu, 28 Apr 2022 14:36:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651181764; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iQbiMIo1gUtSCaq3YFPNWEYorFG8oaTPuL0iosH3Hq4=; b=cNuihQ61Pnxw+DoDoUkuvYLtXERwzTAGWiiWgrxyM6xZHxQFJOkOKRC7+SCLStk1RUgKKV pTVuzNVU75dg2RigKUGyC9IhNO8WhQy7VDMQXH5k5SEFnrcWhzP0y9fYl7Di9i86n26yXb Jk3jiD5LAC9iE7nOYsvgG7kZpx6AAQ8= Received: from mail-io1-f70.google.com (mail-io1-f70.google.com [209.85.166.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-97-3_qcrhhuPoKKcwPLOwgpPA-1; Thu, 28 Apr 2022 17:36:03 -0400 X-MC-Unique: 3_qcrhhuPoKKcwPLOwgpPA-1 Received: by mail-io1-f70.google.com with SMTP id k2-20020a0566022a4200b00654c0f121a9so5422954iov.1 for ; Thu, 28 Apr 2022 14:36:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=iQbiMIo1gUtSCaq3YFPNWEYorFG8oaTPuL0iosH3Hq4=; b=Ce80Hcf2h6cFgLlmMvCALoZN7ETue5VsQJYDgIg+31vMPkx7HzeEVaH5P8QrtZwsp7 Lxt8LxlD2s/Iwzd3UAQN1aS++1i8cq9KiNgo6vfTWro5vbdWVR2aa7GwrCwa11vucSNG PrpEWk7EZGdlqr02yWK7WGcpqc3BJ4DeuQmDLx6NqgbJhxtzlZWe1EwXBkloOSA6UCy0 d7WvqL/75tEDr/caQB0l5Qk/jwiXxrU5GfphABTmwWy371L/WG/cmXYvTT7gckkCXpmM VcgPpB5cdCSFAWbI0i5xqzaNhxW4tWYGKprJKEazQVMEXkxeqFaw82Dke7i+wCtGsWLV rhKA== X-Gm-Message-State: AOAM533ht7l3Yak7AkStc/pQfbyZh0pZ7D4isiEgpVjNY1cJ1v4LaGSi PD49sg2EgedKZnuIlAk5tFPIXll34/p9z5YPdbFFDkFY1fkuZ7YNgj0G97HGIToylXM3ge40Dxn DWpedQj3X/dVMgRve9ITZZin3 X-Received: by 2002:a05:6e02:214b:b0:2cc:1c95:8198 with SMTP id d11-20020a056e02214b00b002cc1c958198mr14200463ilv.231.1651181760596; Thu, 28 Apr 2022 14:36:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwO2Ydk1G1hZccHv0hPl1sCdxwwRZq6FDq1leR+oIkXB3miVaj8H4gAjSSbLmAYq/XYS2oOAg== X-Received: by 2002:a05:6e02:214b:b0:2cc:1c95:8198 with SMTP id d11-20020a056e02214b00b002cc1c958198mr14200452ilv.231.1651181760310; Thu, 28 Apr 2022 14:36:00 -0700 (PDT) Received: from redhat.com ([38.15.36.239]) by smtp.gmail.com with ESMTPSA id c94-20020a029667000000b0032b3a7817a3sm43663jai.103.2022.04.28.14.35.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Apr 2022 14:35:59 -0700 (PDT) Date: Thu, 28 Apr 2022 15:35:58 -0600 From: Alex Williamson To: Jason Gunthorpe Cc: "Wang, Zhi A" , Jani Nikula , Joonas Lahtinen , "Vivi, Rodrigo" , Christoph Hellwig , Tvrtko Ursulin , "intel-gvt-dev@lists.freedesktop.org" , "intel-gfx@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , Zhenyu Wang , "dri-devel@lists.freedesktop.org" Subject: Re: [PULL] gvt-next Message-ID: <20220428153558.4b13fa27.alex.williamson@redhat.com> In-Reply-To: <20220426115258.GJ2125828@nvidia.com> References: <87zgk8tf3l.fsf@intel.com> <20220426115258.GJ2125828@nvidia.com> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 26 Apr 2022 08:52:58 -0300 Jason Gunthorpe wrote: > On Tue, Apr 26, 2022 at 08:42:25AM +0000, Wang, Zhi A wrote: > > On 4/26/22 8:37 AM, Jani Nikula wrote: > > > On Tue, 26 Apr 2022, "Wang, Zhi A" wrote: > > >> Hi folks: > > >> > > >> Here is the pull of gvt-next which fixs the compilation error when i915 debug > > >> is open after the GVT-g refactor patches. > > >> > > >> Thanks so much for the efforts. > > > > > > Pulled, thanks. > > > > > > BR, > > > Jani. > > > > > Thanks, looks good now. :) > > Great! Thanks everyone! > > Alex, can you pull this to VFIO now too? The top commit should be: I see a gvt-next-2022-04-29 tag adding the following fixes: 419f8299ddad i915/gvt: Fix NULL pointer dereference in init_mmio_block_handlers 5b95b9d58fb0 drm/i915/gvt: Fix the compiling error when CONFIG_DRM_I915_DEBUG_RUNTIME_PM=n fa630c304b93 drm/i915/gvt: Make intel_gvt_match_device() static I'm expecting that's my new merge target once a pull request is completed for that. Please keep me cc'd. Thanks, Alex > commit 5e9ae5c47052e28a31fb4f55a6e735c28d4c3948 > Author: Zhi Wang > Date: Mon Apr 25 18:03:31 2022 -0400 > > drm/i915/gvt: Add missing symbol export. > > When CONFIG_DRM_I915_DEBUG_RUNTIME and CONFIG_DRM_I915_DEBUG_PM > are enabled, two more extra symols in i915 are required to be > exported. > > Cc: Jani Nikula > Signed-off-by: Zhi Wang > Link: http://patchwork.freedesktop.org/patch/msgid/20220425220331.24865-1-zhi.a.wang@intel.com > Reviewed-by: Jani Nikula > > Which was picked up here: > > https://cgit.freedesktop.org/drm-intel/commit/?h=drm-intel-next&id=f08699ec5bd924be4c9572e21fd0a806d3fb34c2 > > It will have these commits: > > 5e9ae5c47052e2 drm/i915/gvt: Add missing symbol export. > 2917f53113be3b vfio/mdev: Remove mdev drvdata > 2aa72ec97ce9eb vfio/mdev: Use the driver core to create the 'remove' file > 6b42f491e17ce1 vfio/mdev: Remove mdev_parent_ops > e6486939d8ea22 vfio/mdev: Remove mdev_parent_ops dev_attr_groups > 6c7f98b334a32d vfio/mdev: Remove vfio_mdev.c > cba619cb0d4d66 drm/i915/gvt: merge gvt.c into kvmgvt.c > 978cf586ac35f3 drm/i915/gvt: convert to use vfio_register_emulated_iommu_dev > 0e09f4066ad11b drm/i915/gvt: remove kvmgt_guest_{init,exit} > 7f11e6893ff01b drm/i915/gvt: pass a struct intel_vgpu to the vfio read/write helpers > 4456641232e2c1 drm/i915/gvt: streamline intel_vgpu_create > 37e4bdbd5bad71 drm/i915/gvt: remove the extra vfio_device refcounting for dmabufs > 5f8f3fe67cd908 drm/i915/gvt: remove struct intel_gvt_mpt > 91879bbaf8890f drm/i915/gvt: devirtualize dma_pin_guest_page > 8398eee85fd009 drm/i915/gvt: devirtualize ->dma_{,un}map_guest_page > 4c2baaaf764bfb drm/i915/gvt: devirtualize ->{enable,disable}_page_track > 4050dab5981cd4 drm/i915/gvt: devirtualize ->gfn_to_mfn > bd73b4b193d450 drm/i915/gvt: devirtualize ->is_valid_gfn > b3bece34956f86 drm/i915/gvt: devirtualize ->inject_msi > 4c705ad0d784fd drm/i915/gvt: devirtualize ->detach_vgpu > f9399b0e4a9555 drm/i915/gvt: devirtualize ->set_edid and ->set_opregion > fe902f0ce686e8 drm/i915/gvt: devirtualize ->{get,put}_vfio_device > e3d7640eeeb306 drm/i915/gvt: devirtualize ->{read,write}_gpa > 3c340d05868d98 drm/i915/gvt: remove vgpu->handle > 10ddb96295f3bd drm/i915/gvt: merge struct kvmgt_guest_info into strut intel_vgpu > 62980cacc37f58 drm/i915/gvt: merge struct kvmgt_vdev into struct intel_vgpu > 3cbac24c2cdbfe drm/i915/gvt: remove the unused from_virt_to_mfn op > c977092a997708 drm/i915/gvt: remove the map_gfn_to_mfn and set_trap_area ops > 675e5c4a33e20c drm/i915/gvt: remove intel_gvt_ops > 8b750bf744181c drm/i915/gvt: move the gvt code into kvmgt.ko > f49fc35799fa63 drm/i915/gvt: rename intel_vgpu_ops to intel_vgpu_mdev_ops > 367748066eeb37 drm/i915/gvt: remove enum hypervisor_type > a85749e12d66c2 drm/i915/gvt: remove module refcounting in intel_gvt_{,un}register_hypervisor > 7f0cf30187cdb1 drm/i915/gvt: better align the Makefile with i915 Makefile > de5d437ae8696a drm/i915/gvt: fix trace TRACE_INCLUDE_PATH > 1672991412dfef i915/gvt: Use the initial HW state snapshot saved in i915 > 66e7a8063381cb i915/gvt: Save the initial HW state snapshot in i915 > e0f74ed4634d6d i915/gvt: Separate the MMIO tracking table from GVT-g > > Thanks, > Jason > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62906C433F5 for ; Thu, 28 Apr 2022 21:36:06 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7D13310EBD7; Thu, 28 Apr 2022 21:36:05 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 873E910EBC6 for ; Thu, 28 Apr 2022 21:36:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651181763; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iQbiMIo1gUtSCaq3YFPNWEYorFG8oaTPuL0iosH3Hq4=; b=Nd+UYsf4629gO4h6DIltz37Z9Mp97JV79i+TuYeR8YlVV3ua5NCiMoSzfWhZSWW4tudXa1 m4SZzQn12h6jxFZPpMAHBj8JwKIst+Px3OYX8ICKtiZ9/iwFpurmSlM+MLDnKpW/oxFyik vMJLybsuhtCI6NXJX5fHY6TbdrjEt9M= Received: from mail-il1-f197.google.com (mail-il1-f197.google.com [209.85.166.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-266-X7_zR3eCNg2iTPYKDFCUNA-1; Thu, 28 Apr 2022 17:36:02 -0400 X-MC-Unique: X7_zR3eCNg2iTPYKDFCUNA-1 Received: by mail-il1-f197.google.com with SMTP id g15-20020a056e021a2f00b002cd868be1faso2537123ile.21 for ; Thu, 28 Apr 2022 14:36:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=iQbiMIo1gUtSCaq3YFPNWEYorFG8oaTPuL0iosH3Hq4=; b=pFQJdFeyEi4ISNx3CwSkVEDZKQKD6d28DwXitWrjBE5pR+Wusssftv2GLzvhtkq1el X9cVCgfAO0a6Ow9S5JeORTIEf4t4+I7Hkc4I44jVPgDWFKLTnEaiDBfGU4V9PwrsoFDu dP0aJQ8nv4kx8v66Be832ZtlZ4HBTorU3vcGn2XjJRr8d6cUdrSGdeCSSZtIJ8w2ogcr UGmwzIgJzndL5HTtg2oWZltA0Al/p1N25En1275lUyLEoMPCppA02kjI7TIHPhIkAhEP V3iACpACyCMtZh/+aPdR6iyav9pu80PyVeU66XK6Y5jd058xp3/PbnSiq8f9qP/ELtxn 4B+w== X-Gm-Message-State: AOAM530SPvBcX0IMRlgAyKIz+nN8dVmV3Beea0ui5FPsI15VLFvbIC09 vLhl2jOeRWmZcGZMqaP6xatGbrxGaE5MSSRIbl1HzftSa7gpjqOT92suhRPyulZNP7zsmbvJmWF bzYJ6lmVbLJkhCTLGSMOhb3gCZKBi X-Received: by 2002:a05:6e02:214b:b0:2cc:1c95:8198 with SMTP id d11-20020a056e02214b00b002cc1c958198mr14200459ilv.231.1651181760593; Thu, 28 Apr 2022 14:36:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwO2Ydk1G1hZccHv0hPl1sCdxwwRZq6FDq1leR+oIkXB3miVaj8H4gAjSSbLmAYq/XYS2oOAg== X-Received: by 2002:a05:6e02:214b:b0:2cc:1c95:8198 with SMTP id d11-20020a056e02214b00b002cc1c958198mr14200452ilv.231.1651181760310; Thu, 28 Apr 2022 14:36:00 -0700 (PDT) Received: from redhat.com ([38.15.36.239]) by smtp.gmail.com with ESMTPSA id c94-20020a029667000000b0032b3a7817a3sm43663jai.103.2022.04.28.14.35.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Apr 2022 14:35:59 -0700 (PDT) Date: Thu, 28 Apr 2022 15:35:58 -0600 From: Alex Williamson To: Jason Gunthorpe Subject: Re: [PULL] gvt-next Message-ID: <20220428153558.4b13fa27.alex.williamson@redhat.com> In-Reply-To: <20220426115258.GJ2125828@nvidia.com> References: <87zgk8tf3l.fsf@intel.com> <20220426115258.GJ2125828@nvidia.com> Organization: Red Hat MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=alex.williamson@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tvrtko Ursulin , "dri-devel@lists.freedesktop.org" , "intel-gfx@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "Vivi, Rodrigo" , "intel-gvt-dev@lists.freedesktop.org" , Christoph Hellwig , "Wang, Zhi A" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, 26 Apr 2022 08:52:58 -0300 Jason Gunthorpe wrote: > On Tue, Apr 26, 2022 at 08:42:25AM +0000, Wang, Zhi A wrote: > > On 4/26/22 8:37 AM, Jani Nikula wrote: > > > On Tue, 26 Apr 2022, "Wang, Zhi A" wrote: > > >> Hi folks: > > >> > > >> Here is the pull of gvt-next which fixs the compilation error when i915 debug > > >> is open after the GVT-g refactor patches. > > >> > > >> Thanks so much for the efforts. > > > > > > Pulled, thanks. > > > > > > BR, > > > Jani. > > > > > Thanks, looks good now. :) > > Great! Thanks everyone! > > Alex, can you pull this to VFIO now too? The top commit should be: I see a gvt-next-2022-04-29 tag adding the following fixes: 419f8299ddad i915/gvt: Fix NULL pointer dereference in init_mmio_block_handlers 5b95b9d58fb0 drm/i915/gvt: Fix the compiling error when CONFIG_DRM_I915_DEBUG_RUNTIME_PM=n fa630c304b93 drm/i915/gvt: Make intel_gvt_match_device() static I'm expecting that's my new merge target once a pull request is completed for that. Please keep me cc'd. Thanks, Alex > commit 5e9ae5c47052e28a31fb4f55a6e735c28d4c3948 > Author: Zhi Wang > Date: Mon Apr 25 18:03:31 2022 -0400 > > drm/i915/gvt: Add missing symbol export. > > When CONFIG_DRM_I915_DEBUG_RUNTIME and CONFIG_DRM_I915_DEBUG_PM > are enabled, two more extra symols in i915 are required to be > exported. > > Cc: Jani Nikula > Signed-off-by: Zhi Wang > Link: http://patchwork.freedesktop.org/patch/msgid/20220425220331.24865-1-zhi.a.wang@intel.com > Reviewed-by: Jani Nikula > > Which was picked up here: > > https://cgit.freedesktop.org/drm-intel/commit/?h=drm-intel-next&id=f08699ec5bd924be4c9572e21fd0a806d3fb34c2 > > It will have these commits: > > 5e9ae5c47052e2 drm/i915/gvt: Add missing symbol export. > 2917f53113be3b vfio/mdev: Remove mdev drvdata > 2aa72ec97ce9eb vfio/mdev: Use the driver core to create the 'remove' file > 6b42f491e17ce1 vfio/mdev: Remove mdev_parent_ops > e6486939d8ea22 vfio/mdev: Remove mdev_parent_ops dev_attr_groups > 6c7f98b334a32d vfio/mdev: Remove vfio_mdev.c > cba619cb0d4d66 drm/i915/gvt: merge gvt.c into kvmgvt.c > 978cf586ac35f3 drm/i915/gvt: convert to use vfio_register_emulated_iommu_dev > 0e09f4066ad11b drm/i915/gvt: remove kvmgt_guest_{init,exit} > 7f11e6893ff01b drm/i915/gvt: pass a struct intel_vgpu to the vfio read/write helpers > 4456641232e2c1 drm/i915/gvt: streamline intel_vgpu_create > 37e4bdbd5bad71 drm/i915/gvt: remove the extra vfio_device refcounting for dmabufs > 5f8f3fe67cd908 drm/i915/gvt: remove struct intel_gvt_mpt > 91879bbaf8890f drm/i915/gvt: devirtualize dma_pin_guest_page > 8398eee85fd009 drm/i915/gvt: devirtualize ->dma_{,un}map_guest_page > 4c2baaaf764bfb drm/i915/gvt: devirtualize ->{enable,disable}_page_track > 4050dab5981cd4 drm/i915/gvt: devirtualize ->gfn_to_mfn > bd73b4b193d450 drm/i915/gvt: devirtualize ->is_valid_gfn > b3bece34956f86 drm/i915/gvt: devirtualize ->inject_msi > 4c705ad0d784fd drm/i915/gvt: devirtualize ->detach_vgpu > f9399b0e4a9555 drm/i915/gvt: devirtualize ->set_edid and ->set_opregion > fe902f0ce686e8 drm/i915/gvt: devirtualize ->{get,put}_vfio_device > e3d7640eeeb306 drm/i915/gvt: devirtualize ->{read,write}_gpa > 3c340d05868d98 drm/i915/gvt: remove vgpu->handle > 10ddb96295f3bd drm/i915/gvt: merge struct kvmgt_guest_info into strut intel_vgpu > 62980cacc37f58 drm/i915/gvt: merge struct kvmgt_vdev into struct intel_vgpu > 3cbac24c2cdbfe drm/i915/gvt: remove the unused from_virt_to_mfn op > c977092a997708 drm/i915/gvt: remove the map_gfn_to_mfn and set_trap_area ops > 675e5c4a33e20c drm/i915/gvt: remove intel_gvt_ops > 8b750bf744181c drm/i915/gvt: move the gvt code into kvmgt.ko > f49fc35799fa63 drm/i915/gvt: rename intel_vgpu_ops to intel_vgpu_mdev_ops > 367748066eeb37 drm/i915/gvt: remove enum hypervisor_type > a85749e12d66c2 drm/i915/gvt: remove module refcounting in intel_gvt_{,un}register_hypervisor > 7f0cf30187cdb1 drm/i915/gvt: better align the Makefile with i915 Makefile > de5d437ae8696a drm/i915/gvt: fix trace TRACE_INCLUDE_PATH > 1672991412dfef i915/gvt: Use the initial HW state snapshot saved in i915 > 66e7a8063381cb i915/gvt: Save the initial HW state snapshot in i915 > e0f74ed4634d6d i915/gvt: Separate the MMIO tracking table from GVT-g > > Thanks, > Jason > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D13BBC433EF for ; Thu, 28 Apr 2022 21:36:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EBE9710EBC6; Thu, 28 Apr 2022 21:36:06 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4609E10EBC6 for ; Thu, 28 Apr 2022 21:36:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651181764; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iQbiMIo1gUtSCaq3YFPNWEYorFG8oaTPuL0iosH3Hq4=; b=cNuihQ61Pnxw+DoDoUkuvYLtXERwzTAGWiiWgrxyM6xZHxQFJOkOKRC7+SCLStk1RUgKKV pTVuzNVU75dg2RigKUGyC9IhNO8WhQy7VDMQXH5k5SEFnrcWhzP0y9fYl7Di9i86n26yXb Jk3jiD5LAC9iE7nOYsvgG7kZpx6AAQ8= Received: from mail-il1-f197.google.com (mail-il1-f197.google.com [209.85.166.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-407-eHmmGWF9M7ypDUQo9ezWRw-1; Thu, 28 Apr 2022 17:36:03 -0400 X-MC-Unique: eHmmGWF9M7ypDUQo9ezWRw-1 Received: by mail-il1-f197.google.com with SMTP id f18-20020a926a12000000b002be48b02bc6so2542265ilc.17 for ; Thu, 28 Apr 2022 14:36:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=iQbiMIo1gUtSCaq3YFPNWEYorFG8oaTPuL0iosH3Hq4=; b=nCcf7LjtVmY6FkJ3XnNssN0A+rCAhLJsWrS2MProU1FbS+aNyR1FoB6m+9asLVU3Mw VweavE7SqYVAaWLCi3kxbyK/REPOH3EWcYN+nDm8kNzKLHyA374g0h3GttAQcGJ9ZKdZ tKYACLNHWxtfqqW6sXHb7ZXZzRyg8TL/DYLjrbrjgexIBQXQnrNCwvLRSxNY4tViJkwA 03qE1Y5t/Fat+961Z2rgkmyB5lgM2Q50ap+/zvB+QxPZRdTNjML+AntnXiFr8KvmG4eH QbJCvU1yjqppI9k5JXGMuYLWVAz42Llj9bDHINyfzzJcHkvKMl3rmeCkaOZ/z206adnm A31g== X-Gm-Message-State: AOAM53045PuYP76gSAPAlFqUCKoUmz5EM8DQomPJ11Ax7QErHcTBRJfb NiCoGV9+PZPHv9x8ndmQH1HQUzyNMqpDAaBKH1ONb91GkZ0OQ+/tLRJJrX4LQLWdyLWntVQ1xzG ZTqQ4GQMsZUAQZm1BSfAmh8KotakE X-Received: by 2002:a05:6e02:214b:b0:2cc:1c95:8198 with SMTP id d11-20020a056e02214b00b002cc1c958198mr14200457ilv.231.1651181760591; Thu, 28 Apr 2022 14:36:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwO2Ydk1G1hZccHv0hPl1sCdxwwRZq6FDq1leR+oIkXB3miVaj8H4gAjSSbLmAYq/XYS2oOAg== X-Received: by 2002:a05:6e02:214b:b0:2cc:1c95:8198 with SMTP id d11-20020a056e02214b00b002cc1c958198mr14200452ilv.231.1651181760310; Thu, 28 Apr 2022 14:36:00 -0700 (PDT) Received: from redhat.com ([38.15.36.239]) by smtp.gmail.com with ESMTPSA id c94-20020a029667000000b0032b3a7817a3sm43663jai.103.2022.04.28.14.35.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Apr 2022 14:35:59 -0700 (PDT) Date: Thu, 28 Apr 2022 15:35:58 -0600 From: Alex Williamson To: Jason Gunthorpe Message-ID: <20220428153558.4b13fa27.alex.williamson@redhat.com> In-Reply-To: <20220426115258.GJ2125828@nvidia.com> References: <87zgk8tf3l.fsf@intel.com> <20220426115258.GJ2125828@nvidia.com> Organization: Red Hat MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=alex.williamson@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Intel-gfx] [PULL] gvt-next X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "dri-devel@lists.freedesktop.org" , "intel-gfx@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "Vivi, Rodrigo" , "intel-gvt-dev@lists.freedesktop.org" , Christoph Hellwig Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 26 Apr 2022 08:52:58 -0300 Jason Gunthorpe wrote: > On Tue, Apr 26, 2022 at 08:42:25AM +0000, Wang, Zhi A wrote: > > On 4/26/22 8:37 AM, Jani Nikula wrote: > > > On Tue, 26 Apr 2022, "Wang, Zhi A" wrote: > > >> Hi folks: > > >> > > >> Here is the pull of gvt-next which fixs the compilation error when i915 debug > > >> is open after the GVT-g refactor patches. > > >> > > >> Thanks so much for the efforts. > > > > > > Pulled, thanks. > > > > > > BR, > > > Jani. > > > > > Thanks, looks good now. :) > > Great! Thanks everyone! > > Alex, can you pull this to VFIO now too? The top commit should be: I see a gvt-next-2022-04-29 tag adding the following fixes: 419f8299ddad i915/gvt: Fix NULL pointer dereference in init_mmio_block_handlers 5b95b9d58fb0 drm/i915/gvt: Fix the compiling error when CONFIG_DRM_I915_DEBUG_RUNTIME_PM=n fa630c304b93 drm/i915/gvt: Make intel_gvt_match_device() static I'm expecting that's my new merge target once a pull request is completed for that. Please keep me cc'd. Thanks, Alex > commit 5e9ae5c47052e28a31fb4f55a6e735c28d4c3948 > Author: Zhi Wang > Date: Mon Apr 25 18:03:31 2022 -0400 > > drm/i915/gvt: Add missing symbol export. > > When CONFIG_DRM_I915_DEBUG_RUNTIME and CONFIG_DRM_I915_DEBUG_PM > are enabled, two more extra symols in i915 are required to be > exported. > > Cc: Jani Nikula > Signed-off-by: Zhi Wang > Link: http://patchwork.freedesktop.org/patch/msgid/20220425220331.24865-1-zhi.a.wang@intel.com > Reviewed-by: Jani Nikula > > Which was picked up here: > > https://cgit.freedesktop.org/drm-intel/commit/?h=drm-intel-next&id=f08699ec5bd924be4c9572e21fd0a806d3fb34c2 > > It will have these commits: > > 5e9ae5c47052e2 drm/i915/gvt: Add missing symbol export. > 2917f53113be3b vfio/mdev: Remove mdev drvdata > 2aa72ec97ce9eb vfio/mdev: Use the driver core to create the 'remove' file > 6b42f491e17ce1 vfio/mdev: Remove mdev_parent_ops > e6486939d8ea22 vfio/mdev: Remove mdev_parent_ops dev_attr_groups > 6c7f98b334a32d vfio/mdev: Remove vfio_mdev.c > cba619cb0d4d66 drm/i915/gvt: merge gvt.c into kvmgvt.c > 978cf586ac35f3 drm/i915/gvt: convert to use vfio_register_emulated_iommu_dev > 0e09f4066ad11b drm/i915/gvt: remove kvmgt_guest_{init,exit} > 7f11e6893ff01b drm/i915/gvt: pass a struct intel_vgpu to the vfio read/write helpers > 4456641232e2c1 drm/i915/gvt: streamline intel_vgpu_create > 37e4bdbd5bad71 drm/i915/gvt: remove the extra vfio_device refcounting for dmabufs > 5f8f3fe67cd908 drm/i915/gvt: remove struct intel_gvt_mpt > 91879bbaf8890f drm/i915/gvt: devirtualize dma_pin_guest_page > 8398eee85fd009 drm/i915/gvt: devirtualize ->dma_{,un}map_guest_page > 4c2baaaf764bfb drm/i915/gvt: devirtualize ->{enable,disable}_page_track > 4050dab5981cd4 drm/i915/gvt: devirtualize ->gfn_to_mfn > bd73b4b193d450 drm/i915/gvt: devirtualize ->is_valid_gfn > b3bece34956f86 drm/i915/gvt: devirtualize ->inject_msi > 4c705ad0d784fd drm/i915/gvt: devirtualize ->detach_vgpu > f9399b0e4a9555 drm/i915/gvt: devirtualize ->set_edid and ->set_opregion > fe902f0ce686e8 drm/i915/gvt: devirtualize ->{get,put}_vfio_device > e3d7640eeeb306 drm/i915/gvt: devirtualize ->{read,write}_gpa > 3c340d05868d98 drm/i915/gvt: remove vgpu->handle > 10ddb96295f3bd drm/i915/gvt: merge struct kvmgt_guest_info into strut intel_vgpu > 62980cacc37f58 drm/i915/gvt: merge struct kvmgt_vdev into struct intel_vgpu > 3cbac24c2cdbfe drm/i915/gvt: remove the unused from_virt_to_mfn op > c977092a997708 drm/i915/gvt: remove the map_gfn_to_mfn and set_trap_area ops > 675e5c4a33e20c drm/i915/gvt: remove intel_gvt_ops > 8b750bf744181c drm/i915/gvt: move the gvt code into kvmgt.ko > f49fc35799fa63 drm/i915/gvt: rename intel_vgpu_ops to intel_vgpu_mdev_ops > 367748066eeb37 drm/i915/gvt: remove enum hypervisor_type > a85749e12d66c2 drm/i915/gvt: remove module refcounting in intel_gvt_{,un}register_hypervisor > 7f0cf30187cdb1 drm/i915/gvt: better align the Makefile with i915 Makefile > de5d437ae8696a drm/i915/gvt: fix trace TRACE_INCLUDE_PATH > 1672991412dfef i915/gvt: Use the initial HW state snapshot saved in i915 > 66e7a8063381cb i915/gvt: Save the initial HW state snapshot in i915 > e0f74ed4634d6d i915/gvt: Separate the MMIO tracking table from GVT-g > > Thanks, > Jason >