From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A076AC433EF for ; Thu, 28 Apr 2022 17:12:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234695AbiD1RPe (ORCPT ); Thu, 28 Apr 2022 13:15:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234884AbiD1RPd (ORCPT ); Thu, 28 Apr 2022 13:15:33 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65D615B3EA for ; Thu, 28 Apr 2022 10:12:18 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nk7gX-0006Be-Tu; Thu, 28 Apr 2022 19:12:09 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1nk7gX-005nMB-Ip; Thu, 28 Apr 2022 19:12:08 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1nk7gV-006FUT-Gw; Thu, 28 Apr 2022 19:12:07 +0200 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Herbert Xu , "David S. Miller" , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea Cc: linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 2/2] crypto: atmel-sha204a: Suppress duplicate error message Date: Thu, 28 Apr 2022 19:11:46 +0200 Message-Id: <20220428171146.188331-2-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220428171146.188331-1-u.kleine-koenig@pengutronix.de> References: <20220428171146.188331-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Developer-Signature: v=1; a=openpgp-sha256; l=1421; h=from:subject; bh=dULXhhIy46nVMYAUp2LhjGfrO/i/Y09zX1dcnzPKoGU=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBiasrPq0XoXAKagHpsB8sM6G3iYsdiN2oez9DR0LWA jRJ5CRaJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCYmrKzwAKCRDB/BR4rcrsCQ8cB/ 4szPgonLJVifD33+nyLWfuPUnHfaAyipo+rST3nVh3ajJ3YOgQTzZMU+eFaqkK6mJGTo5VOmax4Q8c INhjwyyntxHu014xmHHpRpqdT89MrsufBzIDQOE5DuhSxmHEEqmxj1O2Y8pPk4/0pkEV/OVmGRNtAJ OwGNFOf6TaXRjCKfGt9dt1kwVLwKzcxyxi8R2q1gCzIc7A5GjEwatgsNNG2PtEFqU4Vq8LMwwZ9XGD nnNg+ZrIBV/WJ2GD2FYvGo9V33xPHRtMdR4bCwMHZZRkv6RzUpc7XvwJaW2SxbWYZSsnKnzE9WDSbB j/jtw6GOvqx8hDpgMgRZHabbn/9Rz5 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-crypto@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Returning an error value in an i2c remove callback results in an error message being emitted by the i2c core, but otherwise it doesn't make a difference. The device goes away anyhow and the devm cleanups are called. As atmel_sha204a_remove already emits an error message ant the additional error message by the i2c core doesn't add any useful information, change the return value to zero to suppress this error message. Note that after atmel_sha204a_remove() returns *i2c_priv is freed, so there is trouble ahead because atmel_sha204a_rng_done() might be called after that freeing. So make the error message a bit more frightening. Signed-off-by: Uwe Kleine-König --- drivers/crypto/atmel-sha204a.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/atmel-sha204a.c b/drivers/crypto/atmel-sha204a.c index c71fc86eb849..fecc56b19ba6 100644 --- a/drivers/crypto/atmel-sha204a.c +++ b/drivers/crypto/atmel-sha204a.c @@ -121,8 +121,8 @@ static int atmel_sha204a_remove(struct i2c_client *client) struct atmel_i2c_client_priv *i2c_priv = i2c_get_clientdata(client); if (atomic_read(&i2c_priv->tfm_count)) { - dev_err(&client->dev, "Device is busy\n"); - return -EBUSY; + dev_emerg(&client->dev, "Device is busy, will remove it anyhow\n"); + return 0; } kfree((void *)i2c_priv->hwrng.priv); -- 2.35.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3E976C433F5 for ; Thu, 28 Apr 2022 17:13:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HhzIr3fpt0jdSr54bWYMCbRZyFSAKQzjdXSjKzk3cyk=; b=dTgI+XHWvj2QkG SsNUz/2Nx8yqtk1GitUux7cIsdnAJvg/MTqTXBVYCaEdONHt8NQnGJw5fkPSPIX7Tt82zh07LpwVc T5Ng3m7oxPCmSq82ZvHLbM6SPcp2nGNFgQ+DFXdA/MA3yE9bVdLtE3AsnErpj9uASx4EJaZt/r8O7 IbsuYNj6b2A3OPcWeosWIwjBzLHMuIO02lMD3vCWrKpL5yiqIS837dypNJBtxxAQ5LHpgyuVj1mYL AxXr3YYWkJyj/UbswXkGOkQfvmR4DwtZmycuddBHeb0j0f4cv71FVWQLcagpQQRk2m5tvoxXLVV+C KlNzXUdKdP120Rej3czg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nk7gw-0080Dj-VH; Thu, 28 Apr 2022 17:12:35 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nk7gl-0080Bf-7o for linux-arm-kernel@lists.infradead.org; Thu, 28 Apr 2022 17:12:24 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nk7gX-0006Be-Tu; Thu, 28 Apr 2022 19:12:09 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1nk7gX-005nMB-Ip; Thu, 28 Apr 2022 19:12:08 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1nk7gV-006FUT-Gw; Thu, 28 Apr 2022 19:12:07 +0200 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Herbert Xu , "David S. Miller" , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea Cc: linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 2/2] crypto: atmel-sha204a: Suppress duplicate error message Date: Thu, 28 Apr 2022 19:11:46 +0200 Message-Id: <20220428171146.188331-2-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220428171146.188331-1-u.kleine-koenig@pengutronix.de> References: <20220428171146.188331-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1421; h=from:subject; bh=dULXhhIy46nVMYAUp2LhjGfrO/i/Y09zX1dcnzPKoGU=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBiasrPq0XoXAKagHpsB8sM6G3iYsdiN2oez9DR0LWA jRJ5CRaJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCYmrKzwAKCRDB/BR4rcrsCQ8cB/ 4szPgonLJVifD33+nyLWfuPUnHfaAyipo+rST3nVh3ajJ3YOgQTzZMU+eFaqkK6mJGTo5VOmax4Q8c INhjwyyntxHu014xmHHpRpqdT89MrsufBzIDQOE5DuhSxmHEEqmxj1O2Y8pPk4/0pkEV/OVmGRNtAJ OwGNFOf6TaXRjCKfGt9dt1kwVLwKzcxyxi8R2q1gCzIc7A5GjEwatgsNNG2PtEFqU4Vq8LMwwZ9XGD nnNg+ZrIBV/WJ2GD2FYvGo9V33xPHRtMdR4bCwMHZZRkv6RzUpc7XvwJaW2SxbWYZSsnKnzE9WDSbB j/jtw6GOvqx8hDpgMgRZHabbn/9Rz5 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220428_101223_343355_D0C6858D X-CRM114-Status: GOOD ( 17.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org UmV0dXJuaW5nIGFuIGVycm9yIHZhbHVlIGluIGFuIGkyYyByZW1vdmUgY2FsbGJhY2sgcmVzdWx0 cyBpbiBhbiBlcnJvcgptZXNzYWdlIGJlaW5nIGVtaXR0ZWQgYnkgdGhlIGkyYyBjb3JlLCBidXQg b3RoZXJ3aXNlIGl0IGRvZXNuJ3QgbWFrZSBhCmRpZmZlcmVuY2UuIFRoZSBkZXZpY2UgZ29lcyBh d2F5IGFueWhvdyBhbmQgdGhlIGRldm0gY2xlYW51cHMgYXJlCmNhbGxlZC4KCkFzIGF0bWVsX3No YTIwNGFfcmVtb3ZlIGFscmVhZHkgZW1pdHMgYW4gZXJyb3IgbWVzc2FnZSBhbnQgdGhlIGFkZGl0 aW9uYWwKZXJyb3IgbWVzc2FnZSBieSB0aGUgaTJjIGNvcmUgZG9lc24ndCBhZGQgYW55IHVzZWZ1 bCBpbmZvcm1hdGlvbiwgY2hhbmdlCnRoZSByZXR1cm4gdmFsdWUgdG8gemVybyB0byBzdXBwcmVz cyB0aGlzIGVycm9yIG1lc3NhZ2UuCgpOb3RlIHRoYXQgYWZ0ZXIgYXRtZWxfc2hhMjA0YV9yZW1v dmUoKSByZXR1cm5zICppMmNfcHJpdiBpcyBmcmVlZCwgc28gdGhlcmUKaXMgdHJvdWJsZSBhaGVh ZCBiZWNhdXNlIGF0bWVsX3NoYTIwNGFfcm5nX2RvbmUoKSBtaWdodCBiZSBjYWxsZWQgYWZ0ZXIK dGhhdCBmcmVlaW5nLiBTbyBtYWtlIHRoZSBlcnJvciBtZXNzYWdlIGEgYml0IG1vcmUgZnJpZ2h0 ZW5pbmcuCgpTaWduZWQtb2ZmLWJ5OiBVd2UgS2xlaW5lLUvDtm5pZyA8dS5rbGVpbmUta29lbmln QHBlbmd1dHJvbml4LmRlPgotLS0KIGRyaXZlcnMvY3J5cHRvL2F0bWVsLXNoYTIwNGEuYyB8IDQg KystLQogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRp ZmYgLS1naXQgYS9kcml2ZXJzL2NyeXB0by9hdG1lbC1zaGEyMDRhLmMgYi9kcml2ZXJzL2NyeXB0 by9hdG1lbC1zaGEyMDRhLmMKaW5kZXggYzcxZmM4NmViODQ5Li5mZWNjNTZiMTliYTYgMTAwNjQ0 Ci0tLSBhL2RyaXZlcnMvY3J5cHRvL2F0bWVsLXNoYTIwNGEuYworKysgYi9kcml2ZXJzL2NyeXB0 by9hdG1lbC1zaGEyMDRhLmMKQEAgLTEyMSw4ICsxMjEsOCBAQCBzdGF0aWMgaW50IGF0bWVsX3No YTIwNGFfcmVtb3ZlKHN0cnVjdCBpMmNfY2xpZW50ICpjbGllbnQpCiAJc3RydWN0IGF0bWVsX2ky Y19jbGllbnRfcHJpdiAqaTJjX3ByaXYgPSBpMmNfZ2V0X2NsaWVudGRhdGEoY2xpZW50KTsKIAog CWlmIChhdG9taWNfcmVhZCgmaTJjX3ByaXYtPnRmbV9jb3VudCkpIHsKLQkJZGV2X2VycigmY2xp ZW50LT5kZXYsICJEZXZpY2UgaXMgYnVzeVxuIik7Ci0JCXJldHVybiAtRUJVU1k7CisJCWRldl9l bWVyZygmY2xpZW50LT5kZXYsICJEZXZpY2UgaXMgYnVzeSwgd2lsbCByZW1vdmUgaXQgYW55aG93 XG4iKTsKKwkJcmV0dXJuIDA7CiAJfQogCiAJa2ZyZWUoKHZvaWQgKilpMmNfcHJpdi0+aHdybmcu cHJpdik7Ci0tIAoyLjM1LjEKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVs QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==