From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68651C433F5 for ; Fri, 29 Apr 2022 04:04:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236935AbiD2EHb (ORCPT ); Fri, 29 Apr 2022 00:07:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230133AbiD2EH3 (ORCPT ); Fri, 29 Apr 2022 00:07:29 -0400 Received: from nksmu.kylinos.cn (mailgw.kylinos.cn [123.150.8.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5B3DB9F3F for ; Thu, 28 Apr 2022 21:04:08 -0700 (PDT) X-UUID: d2eb80d31af748789493127fc21f493c-20220429 X-UUID: d2eb80d31af748789493127fc21f493c-20220429 Received: from cs2c.com.cn [(172.17.111.24)] by nksmu.kylinos.cn (envelope-from ) (Generic MTA) with ESMTP id 2146502266; Fri, 29 Apr 2022 12:02:33 +0800 X-ns-mid: postfix-626B63B4-5096043818 Received: from localhost.localdomain (unknown [172.20.108.41]) by cs2c.com.cn (NSMail) with ESMTPA id 40EBE3844000; Fri, 29 Apr 2022 04:04:04 +0000 (UTC) From: Zhenneng Li To: David Airlie , Daniel Vetter Cc: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Zhenneng Li Subject: [PATCH] drm/i915: remove unnecessary spin_lock_irq Date: Fri, 29 Apr 2022 12:03:55 +0800 Message-Id: <20220429040355.2644322-1-lizhenneng@kylinos.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This code will not be called by interrupt handler, so change it to spin_lock. Signed-off-by: Zhenneng Li --- drivers/gpu/drm/i915/i915_scheduler.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_scheduler.c b/drivers/gpu/drm/i915/i915_scheduler.c index 762127dd56c5..6615102a1568 100644 --- a/drivers/gpu/drm/i915/i915_scheduler.c +++ b/drivers/gpu/drm/i915/i915_scheduler.c @@ -288,9 +288,9 @@ static void __i915_schedule(struct i915_sched_node *node, void i915_schedule(struct i915_request *rq, const struct i915_sched_attr *attr) { - spin_lock_irq(&schedule_lock); + spin_lock(&schedule_lock); __i915_schedule(&rq->sched, attr); - spin_unlock_irq(&schedule_lock); + spin_unlock(&schedule_lock); } void i915_sched_node_init(struct i915_sched_node *node) -- 2.25.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BCCB1C433EF for ; Fri, 29 Apr 2022 04:04:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E079F10FA44; Fri, 29 Apr 2022 04:04:16 +0000 (UTC) Received: from nksmu.kylinos.cn (mailgw.kylinos.cn [123.150.8.42]) by gabe.freedesktop.org (Postfix) with ESMTPS id BC40610FA44; Fri, 29 Apr 2022 04:04:14 +0000 (UTC) X-UUID: d2eb80d31af748789493127fc21f493c-20220429 X-UUID: d2eb80d31af748789493127fc21f493c-20220429 Received: from cs2c.com.cn [(172.17.111.24)] by nksmu.kylinos.cn (envelope-from ) (Generic MTA) with ESMTP id 2146502266; Fri, 29 Apr 2022 12:02:33 +0800 X-ns-mid: postfix-626B63B4-5096043818 Received: from localhost.localdomain (unknown [172.20.108.41]) by cs2c.com.cn (NSMail) with ESMTPA id 40EBE3844000; Fri, 29 Apr 2022 04:04:04 +0000 (UTC) From: Zhenneng Li To: David Airlie , Daniel Vetter Subject: [PATCH] drm/i915: remove unnecessary spin_lock_irq Date: Fri, 29 Apr 2022 12:03:55 +0800 Message-Id: <20220429040355.2644322-1-lizhenneng@kylinos.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tvrtko Ursulin , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Zhenneng Li , Rodrigo Vivi Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This code will not be called by interrupt handler, so change it to spin_lock. Signed-off-by: Zhenneng Li --- drivers/gpu/drm/i915/i915_scheduler.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_scheduler.c b/drivers/gpu/drm/i915/i915_scheduler.c index 762127dd56c5..6615102a1568 100644 --- a/drivers/gpu/drm/i915/i915_scheduler.c +++ b/drivers/gpu/drm/i915/i915_scheduler.c @@ -288,9 +288,9 @@ static void __i915_schedule(struct i915_sched_node *node, void i915_schedule(struct i915_request *rq, const struct i915_sched_attr *attr) { - spin_lock_irq(&schedule_lock); + spin_lock(&schedule_lock); __i915_schedule(&rq->sched, attr); - spin_unlock_irq(&schedule_lock); + spin_unlock(&schedule_lock); } void i915_sched_node_init(struct i915_sched_node *node) -- 2.25.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE12DC433FE for ; Fri, 29 Apr 2022 16:36:48 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1DD3D10EA40; Fri, 29 Apr 2022 16:36:47 +0000 (UTC) Received: from nksmu.kylinos.cn (mailgw.kylinos.cn [123.150.8.42]) by gabe.freedesktop.org (Postfix) with ESMTPS id BC40610FA44; Fri, 29 Apr 2022 04:04:14 +0000 (UTC) X-UUID: d2eb80d31af748789493127fc21f493c-20220429 X-UUID: d2eb80d31af748789493127fc21f493c-20220429 Received: from cs2c.com.cn [(172.17.111.24)] by nksmu.kylinos.cn (envelope-from ) (Generic MTA) with ESMTP id 2146502266; Fri, 29 Apr 2022 12:02:33 +0800 X-ns-mid: postfix-626B63B4-5096043818 Received: from localhost.localdomain (unknown [172.20.108.41]) by cs2c.com.cn (NSMail) with ESMTPA id 40EBE3844000; Fri, 29 Apr 2022 04:04:04 +0000 (UTC) From: Zhenneng Li To: David Airlie , Daniel Vetter Date: Fri, 29 Apr 2022 12:03:55 +0800 Message-Id: <20220429040355.2644322-1-lizhenneng@kylinos.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Fri, 29 Apr 2022 16:36:46 +0000 Subject: [Intel-gfx] [PATCH] drm/i915: remove unnecessary spin_lock_irq X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Zhenneng Li , Rodrigo Vivi Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" This code will not be called by interrupt handler, so change it to spin_lock. Signed-off-by: Zhenneng Li --- drivers/gpu/drm/i915/i915_scheduler.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_scheduler.c b/drivers/gpu/drm/i915/i915_scheduler.c index 762127dd56c5..6615102a1568 100644 --- a/drivers/gpu/drm/i915/i915_scheduler.c +++ b/drivers/gpu/drm/i915/i915_scheduler.c @@ -288,9 +288,9 @@ static void __i915_schedule(struct i915_sched_node *node, void i915_schedule(struct i915_request *rq, const struct i915_sched_attr *attr) { - spin_lock_irq(&schedule_lock); + spin_lock(&schedule_lock); __i915_schedule(&rq->sched, attr); - spin_unlock_irq(&schedule_lock); + spin_unlock(&schedule_lock); } void i915_sched_node_init(struct i915_sched_node *node) -- 2.25.1