From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EF834C43219 for ; Fri, 29 Apr 2022 14:48:16 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B8F308393F; Fri, 29 Apr 2022 16:48:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="FzMy1VgX"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8292083542; Fri, 29 Apr 2022 16:48:13 +0200 (CEST) Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9E01381DD6 for ; Fri, 29 Apr 2022 16:48:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x830.google.com with SMTP id y3so5910496qtn.8 for ; Fri, 29 Apr 2022 07:48:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pX3Kv1BsnXhCCkvwvWa++CgJou8Bifq/1FYLrpva5iA=; b=FzMy1VgXi3mADmIC5GmVdnUlt3NbFTVWTSRxFu8FSrRYI5VVmb4sKoxi+HHJfkmr1F rwOtLWggcdJDGqeBwmUDb3L+ZBz+cmeTuNpMi513KTQeT249U0zJwRPGNfB8ue8N7HE4 bZCsdHzAHk7nt4fjOwykydKp20vciZ8QOK5p8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pX3Kv1BsnXhCCkvwvWa++CgJou8Bifq/1FYLrpva5iA=; b=6Cuj2q52feFCAvv9uKebkEyQPK37qq8giz7BGaOP+JvjYo7t5QlHBydHH1pOrtDwpB wysuc8pIh3VHXlzVzQzHNBIGLsk0YrnY2CxdT4L7UxMlYBQhxtbFnG7rrRkbYe3CKV9f d0rvXBVCtq9cJ3ypMtMC7+vz5Edf5sLzlA9uLE/BgQwlm0p5GXOd/xvhZRK3Xw3qLYXb RQHAQBPs78cLvEDYpkl1Zx0yu27geYy6yaa7HIf7HdgVy37nEehGHiOx0kKO6IlPpNKy GKEBT8ALBWMJih+pFoKKV2Cv43nRaM5C2Jwf3P3HAJ4IbgyBB5QWJZvTdye9QEmkiYO4 8UvA== X-Gm-Message-State: AOAM530382A1DeeSgeXoDokgg3kygavi0xKn6fvWo1pOlJUTiKPpvnUk BMKzeP91ja6LnBForNMVZZ66xg== X-Google-Smtp-Source: ABdhPJxykyxyr2WjBk1bpLCc1qr/PwhYqygrO2AV3UR8/GWkFpuOG17P+j3tp6+7aNmKIgYx71RRcg== X-Received: by 2002:ac8:5e0c:0:b0:2f3:867f:a10f with SMTP id h12-20020ac85e0c000000b002f3867fa10fmr9047874qtx.201.1651243689414; Fri, 29 Apr 2022 07:48:09 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-4500-41c8-9db8-25be-eadf.res6.spectrum.com. [2603:6081:7b01:4500:41c8:9db8:25be:eadf]) by smtp.gmail.com with ESMTPSA id x13-20020a05620a258d00b0069c7468e123sm1585294qko.122.2022.04.29.07.48.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Apr 2022 07:48:08 -0700 (PDT) Date: Fri, 29 Apr 2022 10:48:06 -0400 From: Tom Rini To: Sean Anderson Cc: u-boot@lists.denx.de, Simon Glass , Mario Six , Ramon Fried , Heinrich Schuchardt , Joe Hershberger , Marek =?iso-8859-1?Q?Beh=FAn?= Subject: Re: [PATCH v3 01/13] sandbox: net: Add aliases for ethernet devices Message-ID: <20220429144806.GR1182808@bill-the-cat> References: <20220418193659.3677824-1-sean.anderson@seco.com> <20220418193659.3677824-2-sean.anderson@seco.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="soWJpSPh+l8Y6Fy7" Content-Disposition: inline In-Reply-To: <20220418193659.3677824-2-sean.anderson@seco.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --soWJpSPh+l8Y6Fy7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 18, 2022 at 03:36:47PM -0400, Sean Anderson wrote: > Commit f3dd213e15 ("net: introduce helpers to get PHY ofnode from MAC") > changed the ethernet sequence assignment from >=20 > uclass 36: ethernet > 0 * eth@10002000 @ 05813460, seq 0 > 1 * eth@10003000 @ 05813550, seq 5 > 2 * sbe5 @ 05813640, seq 3 > 3 * eth@10004000 @ 05813730, seq 6 > 4 * dsa-test-eth @ 05813820, seq 4 > 5 * lan0 @ 05813a30, seq 2 > 6 * lan1 @ 05813b50, seq 7 >=20 > to >=20 > uclass 36: ethernet > 0 * eth@10002000 @ 03813630, seq 0 > 1 * eth@10003000 @ 03813720, seq 5 > 2 * sbe5 @ 03813810, seq 3 > 3 * eth@10004000 @ 03813900, seq 6 > 4 phy-test-eth @ 038139f0, seq 7 > 5 * dsa-test-eth @ 03813ae0, seq 4 > 6 * lan0 @ 03813cf0, seq 2 > 7 * lan1 @ 03813e10, seq 8 >=20 > This caused the mac address assignment to switch around. Avoid this in > the future by assigning aliases for all ethernet devices. This reverts > the sequence to what it was before the aformentioned commit (with > phy-test-eth as seq 8). There is no ethernet1 for whatever reason. >=20 > Signed-off-by: Sean Anderson > --- >=20 > Changes in v3: > - New >=20 > arch/sandbox/dts/test.dts | 3 +++ > 1 file changed, 3 insertions(+) This needs to update test/dm/test-fdt.c::dm_test_alias_highest_id() to know 8 is the highest now, not 5. I'm noting this as there's other less easy to correct problems with the series. --=20 Tom --soWJpSPh+l8Y6Fy7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmJr+qAACgkQFHw5/5Y0 tyyvMgv/TP1tB/91V7r+eYGB2bFASyVM52L+NjYr/3aDxQ7EDi6LY1W4JPEJkeAI 9xdqX3btqsaLlV0KG4P1Xmqlv34vws3p75WchjIYQfeL1vAYHIxuKviKnpnemBec F68oQG+mLCR6BV8Pglim0Tm4jxqL/BvDmuFKXqgM3Vs7uYCzxQ8gBx2cjflLC+av pbZzcz0siw+ky8GI0IgPORy58yHlb8Oz8M1XdXVSh3KGDt3CkwH7J/zOVJMrDEIQ 26yODnSwwvROEmcfm9Jwzy2gLFVxzxKLnyGrSdYuQZ1ef5YuHl8D9tUJ0u41Iysu P/q8APc7PF9JqSxNH0vy9XNH9Qu3KTaJdf5PZ5ulrnrr8ghqg/gsaEYiB1jqOCnT pTzMk24Ilnk5zQ5XHMkfrGqwi24PW0LpLFjYkUOaWu0FdnBUUwtP2m5eOKFSFGvS MsDyuv+2LtxLwDlKTdJWmsqe2YcwxtqtEU5jotetkALeQP7vtdgpABoGPLk6kHrB 68cHEUDg =iFEl -----END PGP SIGNATURE----- --soWJpSPh+l8Y6Fy7--