From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6ED06C433F5 for ; Fri, 29 Apr 2022 13:32:48 +0000 (UTC) Received: from localhost ([::1]:38994 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nkQjn-0000NG-GH for qemu-devel@archiver.kernel.org; Fri, 29 Apr 2022 09:32:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46306) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nkQgY-0006FI-AH for qemu-devel@nongnu.org; Fri, 29 Apr 2022 09:29:26 -0400 Received: from us-smtp-delivery-44.mimecast.com ([205.139.111.44]:29391) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nkQgW-0004VF-EF for qemu-devel@nongnu.org; Fri, 29 Apr 2022 09:29:26 -0400 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-196-AS1sWWSqMUqd_APeaXWlBA-1; Fri, 29 Apr 2022 09:29:19 -0400 X-MC-Unique: AS1sWWSqMUqd_APeaXWlBA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 10FE2281AF3E; Fri, 29 Apr 2022 13:29:19 +0000 (UTC) Received: from bahia (unknown [10.39.192.177]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6CCC87774; Fri, 29 Apr 2022 13:29:16 +0000 (UTC) Date: Fri, 29 Apr 2022 15:29:15 +0200 From: Greg Kurz To: Bin Meng Subject: Re: [PATCH v5 4/6] 9pfs: fix wrong errno being sent to Linux client on macOS host Message-ID: <20220429152915.7beb6545@bahia> In-Reply-To: References: <7406109.yuWpBpk2tO@silver> <20220429150810.05eca6fe@bahia> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 Received-SPF: softfail client-ip=205.139.111.44; envelope-from=groug@kaod.org; helo=us-smtp-delivery-44.mimecast.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Roitzsch , Christian Schoenebeck , "qemu-devel@nongnu.org Developers" , qemu-stable@nongnu.org, Keno Fischer , Will Cohen , Guohuai Shi , Akihiko Odaki Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 29 Apr 2022 21:19:51 +0800 Bin Meng wrote: > On Fri, Apr 29, 2022 at 9:08 PM Greg Kurz wrote: > > > > On Fri, 29 Apr 2022 14:46:26 +0200 > > Christian Schoenebeck wrote: > > > > > On Freitag, 29. April 2022 13:28:39 CEST Bin Meng wrote: > > > > On Fri, Apr 29, 2022 at 7:16 PM Christian Schoenebeck > > > > > > > > wrote: > > > > > Linux and macOS only share some errno definitions with equal macro > > > > > name and value. In fact most mappings for errno are completely > > > > > different on the two systems. > > > > > > > > > > This patch converts some important errno values from macOS host to > > > > > corresponding Linux errno values before eventually sending such error > > > > > codes along with 'Rlerror' replies (if 9p2000.L is used that is). Not > > > > > having translated errnos before violated the 9p2000.L protocol spec, > > > > > > > > > > which says: > > > > > " > > > > > size[4] Rlerror tag[2] ecode[4] > > > > > > > > > > ... ecode is a numerical Linux errno. > > > > > " > > > > > > > > > > https://github.com/chaos/diod/wiki/protocol#lerror----return-error-code > > > > > > > > > > This patch fixes a bunch of misbehaviours when running a Linux client > > > > > > > > > > on macOS host. For instance this patch fixes: > > > > > mount -t 9p -o posixacl ... > > > > > > > > > > on Linux guest if security_mode=mapped was used for 9p server, which > > > > > refused to mount successfully, because macOS returned ENOATTR==93 > > > > > when client tried to retrieve POSIX ACL xattrs, because errno 93 > > > > > is defined as EPROTONOSUPPORT==93 on Linux, so Linux client believed > > > > > that xattrs were not supported by filesystem on host in general. > > > > > > > > This issue looks exact the same issue we were trying to fix when > > > > supporting 9p on Windows host, > > > > > > > > What we did is like this: > > > > http://patchwork.ozlabs.org/project/qemu-devel/patch/20220425142705.2099270-> 10-bmeng.cn@gmail.com/ > > > > > > > > But we had some questions in mind (see the commit message of our > > > > patch, and below) > > > > > > > > > Signed-off-by: Christian Schoenebeck > > > > > Link: https://lore.kernel.org/qemu-devel/20220421124835.3e664669@bahia/ > > > > > Reviewed-by: Greg Kurz > > > > > --- > > > > > > > > > > hw/9pfs/9p-util.h | 30 ++++++++++++++++++++++++++++++ > > > > > hw/9pfs/9p.c | 2 ++ > > > > > 2 files changed, 32 insertions(+) > > > > > > > > > > diff --git a/hw/9pfs/9p-util.h b/hw/9pfs/9p-util.h > > > > > index 2cc9a5dbfb..c3526144c9 100644 > > > > > --- a/hw/9pfs/9p-util.h > > > > > +++ b/hw/9pfs/9p-util.h > > > > > @@ -58,6 +58,36 @@ static inline uint64_t host_dev_to_dotl_dev(dev_t dev) > > > > > > > > > > #endif > > > > > } > > > > > > > > > > +/* Translates errno from host -> Linux if needed */ > > > > > +static inline int errno_to_dotl(int err) { > > > > > +#if defined(CONFIG_LINUX) > > > > > + /* nothing to translate (Linux -> Linux) */ > > > > > +#elif defined(CONFIG_DARWIN) > > > > > + /* > > > > > + * translation mandatory for macOS hosts > > > > > + * > > > > > + * FIXME: Only most important errnos translated here yet, this should > > > > > be + * extended to as many errnos being translated as possible in > > > > > future. + */ > > > > > + if (err == ENAMETOOLONG) { > > > > > + err = 36; /* ==ENAMETOOLONG on Linux */ > > > > > + } else if (err == ENOTEMPTY) { > > > > > + err = 39; /* ==ENOTEMPTY on Linux */ > > > > > + } else if (err == ELOOP) { > > > > > + err = 40; /* ==ELOOP on Linux */ > > > > > + } else if (err == ENOATTR) { > > > > > + err = 61; /* ==ENODATA on Linux */ > > > > > + } else if (err == ENOTSUP) { > > > > > + err = 95; /* ==EOPNOTSUPP on Linux */ > > > > > + } else if (err == EOPNOTSUPP) { > > > > > + err = 95; /* ==EOPNOTSUPP on Linux */ > > > > > + } > > > > > > > > What happens if a macOS guest is running on QEMU from a macOS host? > > > > Here all macOS errnos are translated to the Linux errnos. Will macOS > > > > be happy? > > > > > > Look at the commit log of this patch: it is a matter of which protocol is used > > > (currently there are 3 [1] protocol versions): > > > > > > * 9p2000: nothing to translate here, as this protocol version does not > > > return a numeric error code, it only returns an error string (and we are > > > no longer supporting 9p2000 version in QEMU anyway BTW [1]): > > > http://ericvh.github.io/9p-rfc/rfc9p2000.html#anchor27 > > > > > > * 9p2000.L: errno *must* be in Linux errno mapping: > > > https://github.com/chaos/diod/wiki/protocol#lerror----return-error-code > > > > > > * 9p2000.u: this one returns both an error code and error string, and it > > > says the error string should be preferred being interpreted by client: > > > http://ericvh.github.io/9p-rfc/rfc9p2000.u.html#anchor15 > > > > > > In this patch here I only translated errno for 9p2000.L, whereas you are > > > always translating it, no matter wich protocol version is used. You might > > > argue that there should be a translation for 9p2000.u as well, but in the end > > > we don't know the OS running on guest in this case. It could be Linux or > > > something else. > > > > > > > In the case of 9p2000.u the spec says "to provide a hint of the underlying > > UNIX error number which caused the error on the server" and even mentions > > "consistency problems of mapping error numbers betweeen different versions > > of UNIX"... this basically means that errno in 9p2000.u is undefined since > > it depends on the host. It is thus unusable unless the guest runs a compatible > > UNIX variant. In any case, there's really nothing to translate. > > > > > [1] https://wiki.qemu.org/Documentation/9p#9p_Protocol > > > > > Thanks for the clarifications and pointers to different protocols! It > looks what we did in our Windows patch is correct. > > I have another question, does this mean the current 9pfs client on > macOS is broken since it does not use any translation? With this > patch, now the 9p server returns the translated linux errno so the 9p > client on macOS should complain. > I don't now the macOS client but if it doesn't expect linux errnos then it is infringing 9p2000.L and should be fixed. > Regards, > Bin