All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gabriel Krisman Bertazi <krisman@collabora.com>
To: tytso@mit.edu, adilger.kernel@dilger.ca, jaegeuk@kernel.org
Cc: linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net, ebiggers@kernel.org,
	Gabriel Krisman Bertazi <krisman@collabora.com>,
	kernel@collabora.com
Subject: [PATCH v3 5/7] ext4: Log error when lookup of encoded dentry fails
Date: Fri, 29 Apr 2022 14:27:26 -0400	[thread overview]
Message-ID: <20220429182728.14008-6-krisman@collabora.com> (raw)
In-Reply-To: <20220429182728.14008-1-krisman@collabora.com>

If the volume is in strict mode, ext4_ci_compare can report a broken
encoding name.  This will not trigger on a bad lookup, which is caught
earlier, only if the actual disk name is bad.

Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>

---

Changes since v1:
  - reword error message "file in directory" -> "filename" (Eric)
---
 fs/ext4/namei.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index e450e52eef48..d53c8d101099 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -1457,6 +1457,9 @@ static bool ext4_match(struct inode *parent,
 			 * only case where it happens is on a disk
 			 * corruption or ENOMEM.
 			 */
+			if (ret == -EINVAL)
+				EXT4_ERROR_INODE(parent,
+						 "Bad encoded filename");
 			return false;
 		}
 		return ret;
-- 
2.35.1


WARNING: multiple messages have this Message-ID (diff)
From: Gabriel Krisman Bertazi <krisman@collabora.com>
To: tytso@mit.edu, adilger.kernel@dilger.ca, jaegeuk@kernel.org
Cc: ebiggers@kernel.org, linux-ext4@vger.kernel.org,
	Gabriel Krisman Bertazi <krisman@collabora.com>,
	kernel@collabora.com, linux-f2fs-devel@lists.sourceforge.net
Subject: [f2fs-dev] [PATCH v3 5/7] ext4: Log error when lookup of encoded dentry fails
Date: Fri, 29 Apr 2022 14:27:26 -0400	[thread overview]
Message-ID: <20220429182728.14008-6-krisman@collabora.com> (raw)
In-Reply-To: <20220429182728.14008-1-krisman@collabora.com>

If the volume is in strict mode, ext4_ci_compare can report a broken
encoding name.  This will not trigger on a bad lookup, which is caught
earlier, only if the actual disk name is bad.

Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>

---

Changes since v1:
  - reword error message "file in directory" -> "filename" (Eric)
---
 fs/ext4/namei.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index e450e52eef48..d53c8d101099 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -1457,6 +1457,9 @@ static bool ext4_match(struct inode *parent,
 			 * only case where it happens is on a disk
 			 * corruption or ENOMEM.
 			 */
+			if (ret == -EINVAL)
+				EXT4_ERROR_INODE(parent,
+						 "Bad encoded filename");
 			return false;
 		}
 		return ret;
-- 
2.35.1



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  parent reply	other threads:[~2022-04-29 18:27 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-29 18:27 [PATCH v3 0/7] Clean up the case-insenstive lookup path Gabriel Krisman Bertazi
2022-04-29 18:27 ` [f2fs-dev] " Gabriel Krisman Bertazi
2022-04-29 18:27 ` [PATCH v3 1/7] ext4: Match the f2fs ci_compare implementation Gabriel Krisman Bertazi
2022-04-29 18:27   ` [f2fs-dev] " Gabriel Krisman Bertazi
2022-05-09 18:08   ` kernel test robot
2022-05-09 18:08     ` [f2fs-dev] " kernel test robot
2022-04-29 18:27 ` [PATCH v3 2/7] ext4: Simplify the handling of cached insensitive names Gabriel Krisman Bertazi
2022-04-29 18:27   ` [f2fs-dev] " Gabriel Krisman Bertazi
2022-04-29 18:27 ` [PATCH v3 3/7] ext4: Implement ci comparison using unicode_name Gabriel Krisman Bertazi
2022-04-29 18:27   ` [f2fs-dev] " Gabriel Krisman Bertazi
2022-05-09 20:13   ` kernel test robot
2022-05-09 20:13     ` kernel test robot
2022-04-29 18:27 ` [PATCH v3 4/7] ext4: Simplify hash check on ext4_match Gabriel Krisman Bertazi
2022-04-29 18:27   ` [f2fs-dev] " Gabriel Krisman Bertazi
2022-04-29 18:27 ` Gabriel Krisman Bertazi [this message]
2022-04-29 18:27   ` [f2fs-dev] [PATCH v3 5/7] ext4: Log error when lookup of encoded dentry fails Gabriel Krisman Bertazi
2022-04-29 18:27 ` [PATCH v3 6/7] ext4: Move ext4_match_ci into libfs Gabriel Krisman Bertazi
2022-04-29 18:27   ` [f2fs-dev] " Gabriel Krisman Bertazi
2022-04-29 18:27 ` [PATCH v3 7/7] f2fs: Reuse generic_ci_match for ci comparisons Gabriel Krisman Bertazi
2022-04-29 18:27   ` [f2fs-dev] " Gabriel Krisman Bertazi
2022-05-09 22:29   ` kernel test robot
2022-05-09 22:29     ` [f2fs-dev] " kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220429182728.14008-6-krisman@collabora.com \
    --to=krisman@collabora.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=ebiggers@kernel.org \
    --cc=jaegeuk@kernel.org \
    --cc=kernel@collabora.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.