All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hui Su <suhui_kernel@163.com>
To: sumit.semwal@linaro.org, christian.koenig@amd.com,
	daniel.vetter@ffwll.ch, linux-media@vger.kernel.org,
	dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] drivers/dma-buf: fix the wrong return val
Date: Tue, 3 May 2022 01:14:40 +0800	[thread overview]
Message-ID: <20220502171440.GA377545@localhost.localdomain> (raw)

The function should return the correct value.

Fixes: 64a8f92fd783 ("dma-buf: add dma_fence_unwrap v2")
Signed-off-by: Hui Su <suhui@zeku.com>
---
 drivers/dma-buf/st-dma-fence-unwrap.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/dma-buf/st-dma-fence-unwrap.c b/drivers/dma-buf/st-dma-fence-unwrap.c
index 039f016b57be..0f156fca9697 100644
--- a/drivers/dma-buf/st-dma-fence-unwrap.c
+++ b/drivers/dma-buf/st-dma-fence-unwrap.c
@@ -157,7 +157,7 @@ static int unwrap_array(void *arg)
 	dma_fence_signal(f1);
 	dma_fence_signal(f2);
 	dma_fence_put(array);
-	return 0;
+	return err;
 }

 static int unwrap_chain(void *arg)
@@ -199,7 +199,7 @@ static int unwrap_chain(void *arg)
 	dma_fence_signal(f1);
 	dma_fence_signal(f2);
 	dma_fence_put(chain);
-	return 0;
+	return err;
 }

 static int unwrap_chain_array(void *arg)
@@ -245,7 +245,7 @@ static int unwrap_chain_array(void *arg)
 	dma_fence_signal(f1);
 	dma_fence_signal(f2);
 	dma_fence_put(chain);
-	return 0;
+	return err;
 }

 int dma_fence_unwrap(void)
--
2.34.1


                 reply	other threads:[~2022-05-02 17:30 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220502171440.GA377545@localhost.localdomain \
    --to=suhui_kernel@163.com \
    --cc=christian.koenig@amd.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=sumit.semwal@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.