All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Gabriel Niebler <gniebler@suse.com>
Cc: Nikolay Borisov <nborisov@suse.com>,
	linux-btrfs@vger.kernel.org, dsterba@suse.com
Subject: Re: [PATCH] btrfs: Turn fs_roots_radix in btrfs_fs_info into an XArray
Date: Mon, 2 May 2022 20:39:36 +0200	[thread overview]
Message-ID: <20220502183936.GN18596@twin.jikos.cz> (raw)
In-Reply-To: <e4ced932-1f39-86fb-c0a4-018c47cf10fa@suse.com>

On Mon, May 02, 2022 at 10:59:01AM +0200, Gabriel Niebler wrote:
> Am 28.04.22 um 13:59 schrieb Nikolay Borisov:
> > On 27.04.22 г. 0:45 ч., Gabriel Niebler wrote:
> >> … rename it to simply fs_roots and adjust all usages of this object to 
> > While the while/xa_for_each_marked and not straight xa_for_each_marked?
> 
> Like before, this just mimicks the old logic, because I wasn't sure 
> whether the double loop is only due to the bunched nature of gang lookup 
> or whether it has some additional safeguarding function.
> 
> I'm fine with simplifying it to xa_for_each_marked if you say it's safe.
> 
> Waiting for further feedback whether to resubmit or not.

I don't have any more comments and it's rc5 so not much time left before
code freeze, so please resend, thanks.

  reply	other threads:[~2022-05-02 18:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-26 21:45 [PATCH] btrfs: Turn fs_roots_radix in btrfs_fs_info into an XArray Gabriel Niebler
2022-04-27 14:51 ` Gabriel Niebler
2022-04-27 19:21   ` David Sterba
2022-04-28 11:37   ` Nikolay Borisov
2022-04-27 20:07 ` David Sterba
2022-04-28 11:59 ` Nikolay Borisov
2022-05-02  8:59   ` Gabriel Niebler
2022-05-02 18:39     ` David Sterba [this message]
2022-05-03  8:01     ` Gabriel Niebler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220502183936.GN18596@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=dsterba@suse.com \
    --cc=gniebler@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=nborisov@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.