From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1399CC433F5 for ; Tue, 3 May 2022 06:31:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A5AD6B0071; Tue, 3 May 2022 02:31:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 855536B0073; Tue, 3 May 2022 02:31:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F6226B0074; Tue, 3 May 2022 02:31:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 60F3F6B0071 for ; Tue, 3 May 2022 02:31:35 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4073E21FE9 for ; Tue, 3 May 2022 06:31:35 +0000 (UTC) X-FDA: 79423460550.11.7988422 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by imf05.hostedemail.com (Postfix) with ESMTP id 971F2100082 for ; Tue, 3 May 2022 06:31:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651559494; x=1683095494; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=66DJLmeKXHUoLx1IC5oaA5smv6AokBXv+WFzA/uXsUc=; b=JDhNC8Z9+XJCtdW+6zGpm1MZTsq8K06bXiBs3KKjuPwdDwwlHzUMWyd3 SHt9ualuMMBjqIfYJZ8ASAgkTMaqjmxYpIiDfkaQSunOnRRXG7jqsRvLf t0RBz67wR6Slklfe/mVIj3q5Yo9kqrci5t7Ml8k3tUxp/x5Kys56YiG25 y1im3Qa8xbISMN5J7CFphTsB1NSxSCA95irsrj2tgVp+lnB/drt6d8zlO n2D/kxLqK/krbcgjwb7jnZEZ3bbOyQ4KqPTpYEwi9eDGY62T7GTZu0s78 BKbisRHSeBj/orKZ60sbob1mJbQV2ljEJDQweqghWm0mNyTM/9seEeuSp Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10335"; a="254871692" X-IronPort-AV: E=Sophos;i="5.91,194,1647327600"; d="scan'208";a="254871692" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 May 2022 23:31:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,194,1647327600"; d="scan'208";a="707920413" Received: from lkp-server01.sh.intel.com (HELO 5056e131ad90) ([10.239.97.150]) by fmsmga001.fm.intel.com with ESMTP; 02 May 2022 23:31:25 -0700 Received: from kbuild by 5056e131ad90 with local (Exim 4.95) (envelope-from ) id 1nlm4C-000ADd-If; Tue, 03 May 2022 06:31:24 +0000 Date: Tue, 3 May 2022 14:30:57 +0800 From: kernel test robot To: Zach O'Keefe , Alex Shi , David Hildenbrand , David Rientjes , Matthew Wilcox , Michal Hocko , Pasha Tatashin , Peter Xu , SeongJae Park , Song Liu , Vlastimil Babka , Yang Shi , Zi Yan , linux-mm@kvack.org Cc: kbuild-all@lists.01.org, Andrea Arcangeli , Andrew Morton , Linux Memory Management List , Arnd Bergmann , Axel Rasmussen , Chris Kennelly , Chris Zankel , Helge Deller , Hugh Dickins , Ivan Kokshaysky , "James E.J. Bottomley" , Jens Axboe , "Kirill A. Shutemov" , Matt Turner , Max Filippov , Miaohe Lin , Minchan Kim Subject: Re: [PATCH v4 04/13] mm/khugepaged: make hugepage allocation context-specific Message-ID: <202205031435.JEToTgim-lkp@intel.com> References: <20220502181714.3483177-5-zokeefe@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220502181714.3483177-5-zokeefe@google.com> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 971F2100082 X-Stat-Signature: u97au1ukj814d3rm8torogjoi64uwnxq Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=JDhNC8Z9; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf05.hostedemail.com: domain of lkp@intel.com has no SPF policy when checking 134.134.136.20) smtp.mailfrom=lkp@intel.com X-Rspam-User: X-HE-Tag: 1651559482-941325 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Zach, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on next-20220502] [cannot apply to hnaz-mm/master rostedt-trace/for-next deller-parisc/for-next arnd-asm-generic/master linus/master v5.18-rc5 v5.18-rc4 v5.18-rc3 v5.18-rc5] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Zach-O-Keefe/mm-khugepaged-record-SCAN_PMD_MAPPED-when-scan_pmd-finds-THP/20220503-031727 base: 9f9b9a2972eb8dcaad09d826c5c6d7488eaca3e6 config: x86_64-randconfig-a013 (https://download.01.org/0day-ci/archive/20220503/202205031435.JEToTgim-lkp@intel.com/config) compiler: gcc-11 (Debian 11.2.0-20) 11.2.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/0d006aeaf99be94a0dcb727cb6540195f13fd9c3 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Zach-O-Keefe/mm-khugepaged-record-SCAN_PMD_MAPPED-when-scan_pmd-finds-THP/20220503-031727 git checkout 0d006aeaf99be94a0dcb727cb6540195f13fd9c3 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): mm/khugepaged.c: In function 'alloc_charge_hpage': >> mm/khugepaged.c:1091:36: warning: passing argument 1 of 'khugepaged_alloc_page' makes pointer from integer without a cast [-Wint-conversion] 1091 | if (!khugepaged_alloc_page(gfp, node, cc)) | ^~~ | | | gfp_t {aka unsigned int} mm/khugepaged.c:949:49: note: expected 'struct page **' but argument is of type 'gfp_t' {aka 'unsigned int'} 949 | static bool khugepaged_alloc_page(struct page **hpage, gfp_t gfp, int node) | ~~~~~~~~~~~~~~^~~~~ >> mm/khugepaged.c:1091:47: warning: passing argument 3 of 'khugepaged_alloc_page' makes integer from pointer without a cast [-Wint-conversion] 1091 | if (!khugepaged_alloc_page(gfp, node, cc)) | ^~ | | | struct collapse_control * mm/khugepaged.c:949:71: note: expected 'int' but argument is of type 'struct collapse_control *' 949 | static bool khugepaged_alloc_page(struct page **hpage, gfp_t gfp, int node) | ~~~~^~~~ vim +/khugepaged_alloc_page +1091 mm/khugepaged.c 1074 1075 static int alloc_charge_hpage(struct mm_struct *mm, struct collapse_control *cc) 1076 { 1077 #ifdef CONFIG_NUMA 1078 const struct cpumask *cpumask; 1079 #endif 1080 gfp_t gfp = alloc_hugepage_khugepaged_gfpmask() | __GFP_THISNODE; 1081 int node = khugepaged_find_target_node(cc); 1082 1083 #ifdef CONFIG_NUMA 1084 /* sched to specified node before huge page memory copy */ 1085 if (task_node(current) != node) { 1086 cpumask = cpumask_of_node(node); 1087 if (!cpumask_empty(cpumask)) 1088 set_cpus_allowed_ptr(current, cpumask); 1089 } 1090 #endif > 1091 if (!khugepaged_alloc_page(gfp, node, cc)) 1092 return SCAN_ALLOC_HUGE_PAGE_FAIL; 1093 if (unlikely(mem_cgroup_charge(page_folio(cc->hpage), mm, gfp))) 1094 return SCAN_CGROUP_CHARGE_FAIL; 1095 count_memcg_page_event(cc->hpage, THP_COLLAPSE_ALLOC); 1096 return SCAN_SUCCEED; 1097 } 1098 -- 0-DAY CI Kernel Test Service https://01.org/lkp