[PATCH] imx8mn_evk: Add the missing spl.bin entry

[PATCH] imx8mn_evk: Add the missing spl.bin entry

[Fabio Estevam]

From: Fabio Estevam <festevam@denx.de>

The generated flash.bin does not boot the imx8mn evk LPDDR4 variant
as it misses the spl.bin description in binman.

Add its entry to fix the boot on the imx8mn evk LPDDR4 variant.

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm/dts/imx8mn-evk-u-boot.dtsi | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/arm/dts/imx8mn-evk-u-boot.dtsi b/arch/arm/dts/imx8mn-evk-u-boot.dtsi
index 3db46d4cbc..593cf06eb9 100644
--- a/arch/arm/dts/imx8mn-evk-u-boot.dtsi
+++ b/arch/arm/dts/imx8mn-evk-u-boot.dtsi
@@ -58,7 +58,9 @@
 	};
 
 
-	flash {
+	spl {
+		filename = "spl.bin";
+
 		mkimage {
 			args = "-n spl/u-boot-spl.cfgout -T imx8mimage -e 0x912000";
 
-- 
2.25.1

Re: [PATCH] imx8mn_evk: Add the missing spl.bin entry

[Tim Harvey]

On Tue, May 3, 2022 at 12:03 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> From: Fabio Estevam <festevam@denx.de>
>
> The generated flash.bin does not boot the imx8mn evk LPDDR4 variant
> as it misses the spl.bin description in binman.
>
> Add its entry to fix the boot on the imx8mn evk LPDDR4 variant.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>  arch/arm/dts/imx8mn-evk-u-boot.dtsi | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/dts/imx8mn-evk-u-boot.dtsi b/arch/arm/dts/imx8mn-evk-u-boot.dtsi
> index 3db46d4cbc..593cf06eb9 100644
> --- a/arch/arm/dts/imx8mn-evk-u-boot.dtsi
> +++ b/arch/arm/dts/imx8mn-evk-u-boot.dtsi
> @@ -58,7 +58,9 @@
>         };
>
>
> -       flash {
> +       spl {
> +               filename = "spl.bin";
> +
>                 mkimage {
>                         args = "-n spl/u-boot-spl.cfgout -T imx8mimage -e 0x912000";
>
> --
> 2.25.1
>

Sounds like there should be a Fixes tag here?

Tim

Re: [PATCH] imx8mn_evk: Add the missing spl.bin entry

[Arti Zirk]

On T, 2022-05-03 at 16:03 -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> The generated flash.bin does not boot the imx8mn evk LPDDR4 variant
> as it misses the spl.bin description in binman.
> 
> Add its entry to fix the boot on the imx8mn evk LPDDR4 variant.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>  arch/arm/dts/imx8mn-evk-u-boot.dtsi | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/dts/imx8mn-evk-u-boot.dtsi
> b/arch/arm/dts/imx8mn-evk-u-boot.dtsi
> index 3db46d4cbc..593cf06eb9 100644
> --- a/arch/arm/dts/imx8mn-evk-u-boot.dtsi
> +++ b/arch/arm/dts/imx8mn-evk-u-boot.dtsi
> @@ -58,7 +58,9 @@
>         };
>  
>  
> -       flash {
> +       spl {
> +               filename = "spl.bin";
> +
>                 mkimage {
>                         args = "-n spl/u-boot-spl.cfgout -T imx8mimage -e 0x912000";
>  

This works on my 8MNANOLPD4-EVK board. 

Btw, it looks like you can also just delete the spl and itb entries
because those are already included from the imx8mn-ddr4-evk-u-boot.dtsi
file.

Link: https://lore.kernel.org/u-boot/20220117220407.769-1-andrey.zhizhikin@leica-geosystems.com/
Fixes: d6afc6b3a04a ("imx8mn-evk: switch to use binman")
Tested-by: Arti Zirk <art@zirk.me>

Re: [PATCH] imx8mn_evk: Add the missing spl.bin entry

[Alper Nebi Yasak]

On 03/05/2022 22:03, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> The generated flash.bin does not boot the imx8mn evk LPDDR4 variant
> as it misses the spl.bin description in binman.

The dtsi file #includes "imx8mn-ddr4-evk-u-boot.dtsi", which provides an
'spl' description. It also provides a 'imx-boot' description for a
working 'flash.bin' file. The issue here is the 'flash' description here
is overwriting the same file with its own broken definition. You're
removing it, so things work fine.

> Add its entry to fix the boot on the imx8mn evk LPDDR4 variant.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>  arch/arm/dts/imx8mn-evk-u-boot.dtsi | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Reviewed-by: Alper Nebi Yasak <alpernebiyasak@gmail.com>

> diff --git a/arch/arm/dts/imx8mn-evk-u-boot.dtsi b/arch/arm/dts/imx8mn-evk-u-boot.dtsi
> index 3db46d4cbc..593cf06eb9 100644
> --- a/arch/arm/dts/imx8mn-evk-u-boot.dtsi
> +++ b/arch/arm/dts/imx8mn-evk-u-boot.dtsi
> @@ -58,7 +58,9 @@
>  	};
>  
>  
> -	flash {
> +	spl {
> +		filename = "spl.bin";
> +
>  		mkimage {
>  			args = "-n spl/u-boot-spl.cfgout -T imx8mimage -e 0x912000";
>  

You might want to copy 'imx-boot' from "imx8mn-ddr4-evk-u-boot.dtsi" for
completeness. But it doesn't really matter.

[PATCH] imx8mn_evk: Add the missing spl.bin entry

[sbabic]

> From: Fabio Estevam <festevam@denx.de>
> The generated flash.bin does not boot the imx8mn evk LPDDR4 variant
> as it misses the spl.bin description in binman.
> Add its entry to fix the boot on the imx8mn evk LPDDR4 variant.
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> Tested-by: Arti Zirk <art@zirk.me>
> Reviewed-by: Alper Nebi Yasak <alpernebiyasak@gmail.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================