All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Francis Laniel <flaniel@linux.microsoft.com>
Cc: Angelo Compagnucci <angelo.compagnucci@gmail.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/sysdig: fix DRIVER_NAME definition
Date: Tue, 3 May 2022 21:15:07 +0200	[thread overview]
Message-ID: <20220503191507.GA2575@scaer> (raw)
In-Reply-To: <20220503142701.14397-2-flaniel@linux.microsoft.com>

Francis, All,

On 2022-05-03 15:27 +0100, Francis Laniel spake thusly:
> When I wrote the previous commit, I was not fully focused and wrote:
> -DDRIVER_NAME=$(FALCOSECURITY_LIBS_DRIVER_NAME.)
> Which leaded to DRIVER_NAME to be empty.
> So, it was not possible to use sysdig due to the following error message:
> error opening device /dev/0. Make sure you have root credentials and that the  module is loaded.
> 
> Fixes: ea86757e51cf ("package/sysdig: bump to 0.29.1")
> Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/sysdig/sysdig.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/sysdig/sysdig.mk b/package/sysdig/sysdig.mk
> index 76cabcaeca..318746d44a 100644
> --- a/package/sysdig/sysdig.mk
> +++ b/package/sysdig/sysdig.mk
> @@ -28,7 +28,7 @@ SYSDIG_DEPENDENCIES = \
>  SYSDIG_CONF_OPTS += -DFALCOSECURITY_LIBS_SOURCE_DIR=$(FALCOSECURITY_LIBS_SRCDIR) \
>  	-DBUILD_DRIVER=OFF \
>  	-DGRPC_CPP_PLUGIN=$(HOST_DIR)/bin/grpc_cpp_plugin \
> -	-DDRIVER_NAME=$(FALCOSECURITY_LIBS_DRIVER_NAME.) \
> +	-DDRIVER_NAME=$(FALCOSECURITY_LIBS_DRIVER_NAME) \
>  	-DENABLE_DKMS=OFF \
>  	-DUSE_BUNDLED_DEPS=OFF \
>  	-DWITH_CHISEL=ON \
> -- 
> 2.25.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-05-03 19:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-03 14:26 [Buildroot] [PATCH 0/2] Bump sysdig to 0.29.2 Francis Laniel
2022-05-03 14:27 ` [Buildroot] [PATCH 1/2] package/sysdig: fix DRIVER_NAME definition Francis Laniel
2022-05-03 19:15   ` Yann E. MORIN [this message]
2022-05-03 14:27 ` [Buildroot] [PATCH 2/2] package/sysdig: bump to version 0.29.2 Francis Laniel
2022-05-03 19:22   ` Yann E. MORIN
2022-05-04 12:28     ` Francis Laniel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220503191507.GA2575@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=angelo.compagnucci@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=flaniel@linux.microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.