All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Moulding <dmoulding@me.com>
To: hch@lst.de
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
	penguin-kernel@I-love.SAKURA.ne.jp
Subject: Re: [PATCH v2] block: deprecate autoloading based on dev_t
Date: Tue,  3 May 2022 15:28:48 -0600	[thread overview]
Message-ID: <20220503212848.5853-1-dmoulding@me.com> (raw)
In-Reply-To: <20220104071647.164918-1-hch@lst.de>

I believe this change may break some mdraid setups. It looks to me
like mdadm still depends on this legacy autoload behavior. There are
some situations where mdadm does mknod to create a temporary device
node and then attempts to open that temporary node. On my system,
after disabling legacy autoloading, mdadm fails (ENODEV) when it
attempts the open of the temporary node (block 9:127).

It seems this is an issue when mdadm attempts to assemble an array
that it sees as "foreign". And it makes the determination of whether
an array is foreign or not based on whether the hostname recorded in
the array superblock(s) matches the current system's hostname. It's my
observation that some init systems do not set the system hostname
early enough, so arrays that should look local will be treated as
foreign arrays by mdadm, which makes it go down this path where it
will depend on the legacy autoloading behavior.

As an aside, this happens even though udev is in use. mdadm ships with
udev rules that cause mdadm to be invoked to assemble arrays when
uevents fire that announce the appearance of "file systems" of type
linux_raid_member. So while udev is supposed to supplant this legacy
autoloading behavior, it appears there are at least some current
real-world cases where udev itself ultimately ends up itself depending
(in an indirect way) on this legacy behavior :)

Cheers,

-- Dan

      parent reply	other threads:[~2022-05-03 21:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-04  7:16 [PATCH v2] block: deprecate autoloading based on dev_t Christoph Hellwig
2022-01-17  8:43 ` Christoph Hellwig
2022-01-17 14:28   ` Jens Axboe
2022-01-26 13:49 ` Jens Axboe
2022-05-03 21:28 ` Dan Moulding [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220503212848.5853-1-dmoulding@me.com \
    --to=dmoulding@me.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=penguin-kernel@I-love.SAKURA.ne.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.