From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECA1AC433EF for ; Wed, 4 May 2022 08:46:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 64E206B0078; Wed, 4 May 2022 04:46:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D6EF6B007B; Wed, 4 May 2022 04:46:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 429796B007D; Wed, 4 May 2022 04:46:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2E43A6B0078 for ; Wed, 4 May 2022 04:46:47 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id ADE6C60DAB for ; Wed, 4 May 2022 08:46:46 +0000 (UTC) X-FDA: 79427430012.18.14981B1 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf21.hostedemail.com (Postfix) with ESMTP id 9B01F1C0097 for ; Wed, 4 May 2022 08:46:39 +0000 (UTC) Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2447Yc83004338; Wed, 4 May 2022 08:46:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : content-type : mime-version; s=corp-2021-07-09; bh=qDV7cy7cpku4G7kfHiEIqke4EynpyJEV2X1sifMgZHk=; b=qephbHIaTO7/CcyARplozYNosIHT+KP4UYdfVSvocQpukeQwYL7b+8DmiNgSyrWpTkNy IOGW3RHD8vdqKt0FCBut7WieJ+L3fl8Czly3WfA8TcocFfJlKiCScHXhx72P6KWf3wZw xiBpaCVAWrrRHin78D5mUYXAyH0ue3nowQSvMd8L9vCnz0Gz1oz/5/w935GAh15xXJT7 cbuJb5CGyvScRxc067nxuV5j4XiSDGjfddXN1wRHcO1D2sUMgEcyY7d6/7BU8gPZQxjc AB7JwtjnI9NKtXFptwNw0rRJoDV1vubI+Wge8XMp06tff2cqvVP7azaYS5iEzqgV2Kzd vA== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3fruq0fuer-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 04 May 2022 08:46:43 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 2448eU93022291; Wed, 4 May 2022 08:46:40 GMT Received: from nam04-dm6-obe.outbound.protection.outlook.com (mail-dm6nam08lp2040.outbound.protection.outlook.com [104.47.73.40]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id 3fruj9rm8x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 04 May 2022 08:46:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n3Sjt0dCNTPdsLE8E7rpcl2X89Z2IOsSMQgG0V2sKajR2BpHPTO7MIqIbEfJSmhnKT/BWn/sG53zILqwBkr7C4+YyRDP32EBzGjuhUeLKF6PDJm8zk9js4XguHsKYwFmomcYATWGT1qroRbtiA6bMlzaMXV29/32Q+v++cO7g5lLD5IEwqVT13ntLM+UgJnGzjqqpbX4AMuaDVRtFdOoR+7tn7hm9fXz50eWDO3rDa0kxkRCIr+KMpklfMrwoepDAwDB0ew5v+zz8sslrXJKO0duPOBDt+ZpT66WW2xb4tU0uZxP4N9ZZWtOnfMycRXsZkHGEYirhckZkJ+LLh1qhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qDV7cy7cpku4G7kfHiEIqke4EynpyJEV2X1sifMgZHk=; b=JJfjVx2o5ix5oy5Fvkvzj+SdxIYEFafxydykUpFO1bdZLVq6iIDLLQbz4SEGT7QFDxwTdwd/KJZ1yJ/iKZJKscg9g+817sVOG5/M0/H2OvDXNOae6fhIzN16cWKq07pI+9uT6JQcI7BtXSb8t1SY+lKtY+/fHS9dfDhocWFzb3SdEuVXHNutyXR/oz6T6eDg0fkMKgj5vs66eKWK0J1L2A4puocsGMxqsdeqy10DRoyjIHWmr6KE/hdQ5txFsUJ0VgYhmN3KNElKf5nFf7I9DtaoJL34YJPNdMjMd/D0OrnBawuakIj6bFaS/Vmu8f1X5DcsfUp0QF3Q9tne5kdK+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qDV7cy7cpku4G7kfHiEIqke4EynpyJEV2X1sifMgZHk=; b=W2fcSM5osZoLJwk0fLLycmf3d/SS/K8ywK2EBUv8xouxhph4QRSDa67eeVYkgw19RyhBWW1av4atBkcrt5lRxQkfORwNNrmCMuBCumWpwg4egasR19VMgwhJuGM3HlSrRoIyZ/5o+cY4JRyBKdkYpTRp7DUNdeKoDSgC2U6jRtg= Received: from MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) by SJ0PR10MB5551.namprd10.prod.outlook.com (2603:10b6:a03:3d5::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.14; Wed, 4 May 2022 08:46:38 +0000 Received: from MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::b5d5:7b39:ca2d:1b87]) by MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::b5d5:7b39:ca2d:1b87%5]) with mapi id 15.20.5164.025; Wed, 4 May 2022 08:46:38 +0000 Date: Wed, 4 May 2022 11:46:27 +0300 From: Dan Carpenter To: kbuild@lists.01.org, Carl Huang Cc: lkp@intel.com, kbuild-all@lists.01.org, Linux Memory Management List , Kalle Valo Subject: [linux-next:master 408/8237] drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex'. Message-ID: <202205032236.kofEquX3-lkp@intel.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) X-ClientProxiedBy: MR1P264CA0094.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:3f::27) To MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f24e1d10-18db-4667-117f-08da2daa9a38 X-MS-TrafficTypeDiagnostic: SJ0PR10MB5551:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Shaeb6X0v6TsLjv/OM1v7mHxvV6LCirGDhdupeznTBuL9BrcZKpk29ljESZxzP4FKv4eueDuoC6eITKWXrDW/X+z6pup83LG3WvvPXpfEMQVxlbIoGDrghOggKg+Ceary5Xj0UQ6CEzekrnWWO42tum8wi+eVmb8Tbia17dZKUNlpW57C9082v4lC++WaJPdjBSYimze89J4/9QtTs7gOePN/TzAhjSaYs5JSDeEgnNscwQoaJHzUIo5bLc2BTCUIW02j29AXQ/VjC/WCD8TLOogojQzEZ/Nl9ne6/ori9HZ5M5momsIt4g13rmhAhpR/CwVp9d31zTXoqnDuZTHr9yZkbeAU1UxT0Y7Ky08hpxASCCTvqQ8sZ8RLKiATXbZdGfWtEhXo+vq/wGIAhNqwD7OEBEGsZ7nzAk134A58cUVPh+E2BEPo5U/xqE0mFUO2FX/0vv6crzXmVikGA14Sef5nzGOnrCnRbOCquFpfxwolU60C6AhwMm2UUXsj8+VTrl8ucpk4QqqMKKqX+qUeO/NkODZDVDRe5FkMmlsktqMhv4lQIxgi2sFKY6wv4UiflJYakHCR+chIqKv5uAFH84yRiJh+Olhczp2jZRmO++wTsdvyXIYqSmBuJDRca2b9yuK98+fp4i5n8lNBnx24+FRXSvBZvnHavALnN1jEyIlK/qsqCXB2JHQDezGgNWor9YE1COQU/JRmFcKLXCutOCSFlQuT7g8ion+YOyx82eWPQXCAdJV3TbQN7zQpEeZwa1IkNfd0kzH644s7Zc5SUecCyfvMhkyclLqqeHrlFLBOpXj9piHA7BBQk3C+ZeBC1YznRLlgAgKtFGqMdBtGQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8676002)(186003)(36756003)(4326008)(66476007)(66946007)(66556008)(316002)(9686003)(6512007)(52116002)(26005)(6506007)(54906003)(6916009)(1076003)(966005)(6666004)(86362001)(5660300002)(8936002)(6486002)(508600001)(38100700002)(38350700002)(83380400001)(2906002)(44832011);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RDx1VHzC1YBF3H820e5io5Ac+JUrO7U9SwvtlA0n87fXEwaqZDtNPHF4tTHA?= =?us-ascii?Q?37X8nvqqGkP8pu5gZF8mJ87X60I1WBG2VTTJFifHxfNQVG6NgY5aVAWvRkTe?= =?us-ascii?Q?ANTutxTcTRpLvV2Wb/eoNa36qV2ibkAVGVMyupSgB213IQZtFl/BQ5zqJ8/5?= =?us-ascii?Q?u/+FjdjXTgai6kV5lq3juWaKM7BtXnGwVpqMTfRQFsYppQD3RdhWfIWv3frJ?= =?us-ascii?Q?/3F3DTzprycLE6wQZVF42s6rrZM8qmc7viYBz8VewVALYkheI/Dg+aUqciqd?= =?us-ascii?Q?xXwJXyVP8B7mHGjgzVOBbP5j/ajHI/THpDFLB0t6qkw4orbxQTXXwnp1gpLN?= =?us-ascii?Q?S0AutgcvH7QzhMoU7DpvcZdlNNAesn4ddXmoinA5aeaA/gZCPEjS+k8Uq+DB?= =?us-ascii?Q?d7pSgutXp6URhPA7rNptpU0dtihN37AbYF4wRN59r/dVkdmPr9c0howFxpuW?= =?us-ascii?Q?+2uOItIIVaRfbjw0qcVLfTITxrLRU3zRlFMJM9eNYouMTvEpZcZd/KXYrTCq?= =?us-ascii?Q?TVYU8SWRAAp01FtoSX3qAgU3k5WjvA6uTPydjmP0hicPv6A1AGbB9Sct2bpN?= =?us-ascii?Q?nvL34RovvPK5e6X1XpqnwGb5CJP7rthgBaEH401mTxM8Dn+RQ/sFXHm2+pBA?= =?us-ascii?Q?gI4amWmirXI01xE4Gj2xS5Z9K90VHwhTBTID0X8QweSR3itrO66C+u4XC9JZ?= =?us-ascii?Q?iEFE8o6pfdzpky6R8/j/J3NxeLoihddcRbQs+BWyescvTibKnZGyyqsYxFtp?= =?us-ascii?Q?OgjwNC2DpkDIRfE9/i53Qj/kiolX3fHUuwHwxeq0gxrbeNxIioS6UJ6yPmtG?= =?us-ascii?Q?eauDs0tmYz0WL9l80Z12pHQCpEqqbX4MRwxoFyXf0hsYe6Rguzgrkpv4cfyf?= =?us-ascii?Q?zDAqbrM4Yf5zFInXTMdYkzd71LKViI2XlW7MdLOJKvEKBEazrKFkVD1IZ/EK?= =?us-ascii?Q?JW2CNyL1/edFZustklq/8ebtws6of3qFc8NSN+lgESuqLHuD5URasKbU88N7?= =?us-ascii?Q?EjVWSPr8eF/mMbSKYTUJIfng0LVMvaEkyBrY46bKHQeMffEyOYP8Zb94A6My?= =?us-ascii?Q?TD6nFYVCu55E95yCSbK/zKDC9HyO+y82PsBNT8CdlJWs/LmvELVz8s+8swxC?= =?us-ascii?Q?xveZuQrZsoUmRgV49UESmNWmZyFnZTB8HdhU4Clqf/+L8+c9N7QGZG1gZKdF?= =?us-ascii?Q?FChRMPP/a2dQB4GWsp3E+Eut+1PVm8INbX4QXOGEyNQSSIAzhNqQxiVi9wQB?= =?us-ascii?Q?2JrWlD22OKWxTtMR6mAIgrWQhnitjQHT3A89QQrwJ9I6rkx8cLI/w/iXGVuA?= =?us-ascii?Q?V1lVpdDs+hQFiyglnhbqjIZXdJGMwZrrh44m8OMDj4eE0/0t0BSXx81GdOCz?= =?us-ascii?Q?cb09X+mtYb3OzWYKfew+ZIju84IEsHEntRvSrixNgAbn3mZSVeVKpg7P78VL?= =?us-ascii?Q?CkH6Mq1mXrkSbL16NnjX6uIW1R2q2Y9zNhharAp1oQf+AtO/3/IRp7V7QqPm?= =?us-ascii?Q?8uEFQ4fE11Bdu54HeY/gS8dblQU9p/mvsAOu9/BtL5vPQ+SdVKPdmIaM1Qs4?= =?us-ascii?Q?mninOAAE/uLw6689BqzhF009UDYrE34kCNBg14m9zdjBdGrw237wSQ/MBjqW?= =?us-ascii?Q?RRgZ8MZcvD55j3WSAF1784cs0HOYB2UgWzyZssQrTT11jw1lKP0mRrWDAm95?= =?us-ascii?Q?yFgqvWKsVu3qS9Kt4QJEx12NFRoBSKNDFC+A+s5/kflAaA82tE3ogrirKeCm?= =?us-ascii?Q?I09GoByqShaZHXPmdd8omRy1rnfYYNM=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: f24e1d10-18db-4667-117f-08da2daa9a38 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 08:46:38.2496 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: D+rJ66bgFqksO9NjAALt468uOf/9TadsEg7LI22sJM5lbqzeBtBfoFi0WSXEmn+FRvgg+UhWFaav/sI9KqnGysqJU2SP4q99kS7i2PkCKFg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5551 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858 definitions=2022-05-04_02:2022-05-02,2022-05-04 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0 mlxlogscore=999 mlxscore=0 spamscore=0 suspectscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2205040058 X-Proofpoint-ORIG-GUID: SkfdvHVoJdxIuas6GifiZsqpAIzQclUl X-Proofpoint-GUID: SkfdvHVoJdxIuas6GifiZsqpAIzQclUl X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 9B01F1C0097 X-Stat-Signature: 7qc8dockduujzzuk3orcg7fxubhnaedn X-Rspam-User: Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2021-07-09 header.b=qephbHIa; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=W2fcSM5o; spf=none (imf21.hostedemail.com: domain of dan.carpenter@oracle.com has no SPF policy when checking 205.220.165.32) smtp.mailfrom=dan.carpenter@oracle.com; dmarc=pass (policy=none) header.from=oracle.com X-HE-Tag: 1651653999-645386 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 44a2f39e611ac0bc1f17c288a583d7f2e5684aa7 commit: 90bf5c8d0f7ecddf96fc1cd9434af4e157b51970 [408/8237] ath11k: purge rx pktlog when entering WoW config: i386-randconfig-m021-20220502 (https://download.01.org/0day-ci/archive/20220503/202205032236.kofEquX3-lkp@intel.com/config) compiler: gcc-11 (Debian 11.2.0-20) 11.2.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Reported-by: Dan Carpenter smatch warnings: drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex'. vim +712 drivers/net/wireless/ath/ath11k/wow.c ba9177fcef21fa Carl Huang 2022-03-14 653 int ath11k_wow_op_resume(struct ieee80211_hw *hw) ba9177fcef21fa Carl Huang 2022-03-14 654 { ba9177fcef21fa Carl Huang 2022-03-14 655 struct ath11k *ar = hw->priv; ba9177fcef21fa Carl Huang 2022-03-14 656 int ret; ba9177fcef21fa Carl Huang 2022-03-14 657 ba9177fcef21fa Carl Huang 2022-03-14 658 mutex_lock(&ar->conf_mutex); ba9177fcef21fa Carl Huang 2022-03-14 659 ba9177fcef21fa Carl Huang 2022-03-14 660 ret = ath11k_hif_resume(ar->ab); ba9177fcef21fa Carl Huang 2022-03-14 661 if (ret) { ba9177fcef21fa Carl Huang 2022-03-14 662 ath11k_warn(ar->ab, "failed to resume hif: %d\n", ret); ba9177fcef21fa Carl Huang 2022-03-14 663 goto exit; ba9177fcef21fa Carl Huang 2022-03-14 664 } ba9177fcef21fa Carl Huang 2022-03-14 665 ba9177fcef21fa Carl Huang 2022-03-14 666 ath11k_hif_ce_irq_enable(ar->ab); ba9177fcef21fa Carl Huang 2022-03-14 667 ath11k_hif_irq_enable(ar->ab); ba9177fcef21fa Carl Huang 2022-03-14 668 90bf5c8d0f7ecd Carl Huang 2022-03-14 669 ret = ath11k_dp_rx_pktlog_start(ar->ab); 90bf5c8d0f7ecd Carl Huang 2022-03-14 670 if (ret) { 90bf5c8d0f7ecd Carl Huang 2022-03-14 671 ath11k_warn(ar->ab, "failed to start rx pktlog from wow: %d\n", ret); 90bf5c8d0f7ecd Carl Huang 2022-03-14 672 return ret; goto exit; 90bf5c8d0f7ecd Carl Huang 2022-03-14 673 } 90bf5c8d0f7ecd Carl Huang 2022-03-14 674 ba9177fcef21fa Carl Huang 2022-03-14 675 ret = ath11k_wow_wakeup(ar->ab); fec4b898f369a9 Carl Huang 2022-03-14 676 if (ret) { ba9177fcef21fa Carl Huang 2022-03-14 677 ath11k_warn(ar->ab, "failed to wakeup from wow: %d\n", ret); fec4b898f369a9 Carl Huang 2022-03-14 678 goto exit; fec4b898f369a9 Carl Huang 2022-03-14 679 } fec4b898f369a9 Carl Huang 2022-03-14 680 fec4b898f369a9 Carl Huang 2022-03-14 681 ret = ath11k_wow_nlo_cleanup(ar); fec4b898f369a9 Carl Huang 2022-03-14 682 if (ret) { fec4b898f369a9 Carl Huang 2022-03-14 683 ath11k_warn(ar->ab, "failed to cleanup nlo: %d\n", ret); fec4b898f369a9 Carl Huang 2022-03-14 684 goto exit; fec4b898f369a9 Carl Huang 2022-03-14 685 } ba9177fcef21fa Carl Huang 2022-03-14 686 c417b247ba0421 Carl Huang 2022-03-14 687 ret = ath11k_wow_clear_hw_filter(ar); c417b247ba0421 Carl Huang 2022-03-14 688 if (ret) { c417b247ba0421 Carl Huang 2022-03-14 689 ath11k_warn(ar->ab, "failed to clear hw filter: %d\n", ret); c417b247ba0421 Carl Huang 2022-03-14 690 goto exit; c417b247ba0421 Carl Huang 2022-03-14 691 } c417b247ba0421 Carl Huang 2022-03-14 692 ba9177fcef21fa Carl Huang 2022-03-14 693 exit: ba9177fcef21fa Carl Huang 2022-03-14 694 if (ret) { ba9177fcef21fa Carl Huang 2022-03-14 695 switch (ar->state) { ba9177fcef21fa Carl Huang 2022-03-14 696 case ATH11K_STATE_ON: ba9177fcef21fa Carl Huang 2022-03-14 697 ar->state = ATH11K_STATE_RESTARTING; ba9177fcef21fa Carl Huang 2022-03-14 698 ret = 1; ba9177fcef21fa Carl Huang 2022-03-14 699 break; ba9177fcef21fa Carl Huang 2022-03-14 700 case ATH11K_STATE_OFF: ba9177fcef21fa Carl Huang 2022-03-14 701 case ATH11K_STATE_RESTARTING: ba9177fcef21fa Carl Huang 2022-03-14 702 case ATH11K_STATE_RESTARTED: ba9177fcef21fa Carl Huang 2022-03-14 703 case ATH11K_STATE_WEDGED: ba9177fcef21fa Carl Huang 2022-03-14 704 ath11k_warn(ar->ab, "encountered unexpected device state %d on resume, cannot recover\n", ba9177fcef21fa Carl Huang 2022-03-14 705 ar->state); ba9177fcef21fa Carl Huang 2022-03-14 706 ret = -EIO; ba9177fcef21fa Carl Huang 2022-03-14 707 break; ba9177fcef21fa Carl Huang 2022-03-14 708 } ba9177fcef21fa Carl Huang 2022-03-14 709 } ba9177fcef21fa Carl Huang 2022-03-14 710 ba9177fcef21fa Carl Huang 2022-03-14 711 mutex_unlock(&ar->conf_mutex); ba9177fcef21fa Carl Huang 2022-03-14 @712 return ret; ba9177fcef21fa Carl Huang 2022-03-14 713 } -- 0-DAY CI Kernel Test Service https://01.org/lkp From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============8115581885908957050==" MIME-Version: 1.0 From: kernel test robot Subject: [linux-next:master 408/8237] drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex'. Date: Tue, 03 May 2022 22:36:28 +0800 Message-ID: <202205032236.kofEquX3-lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============8115581885908957050== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org BCC: lkp(a)intel.com CC: Linux Memory Management List TO: Carl Huang CC: Kalle Valo tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git= master head: 44a2f39e611ac0bc1f17c288a583d7f2e5684aa7 commit: 90bf5c8d0f7ecddf96fc1cd9434af4e157b51970 [408/8237] ath11k: purge r= x pktlog when entering WoW :::::: branch date: 7 hours ago :::::: commit date: 7 weeks ago config: i386-randconfig-m021-20220502 (https://download.01.org/0day-ci/arch= ive/20220503/202205032236.kofEquX3-lkp(a)intel.com/config) compiler: gcc-11 (Debian 11.2.0-20) 11.2.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Reported-by: Dan Carpenter smatch warnings: drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inco= nsistent returns '&ar->conf_mutex'. vim +712 drivers/net/wireless/ath/ath11k/wow.c ba9177fcef21fa Carl Huang 2022-03-14 652 = ba9177fcef21fa Carl Huang 2022-03-14 653 int ath11k_wow_op_resume(struct = ieee80211_hw *hw) ba9177fcef21fa Carl Huang 2022-03-14 654 { ba9177fcef21fa Carl Huang 2022-03-14 655 struct ath11k *ar =3D hw->priv; ba9177fcef21fa Carl Huang 2022-03-14 656 int ret; ba9177fcef21fa Carl Huang 2022-03-14 657 = ba9177fcef21fa Carl Huang 2022-03-14 658 mutex_lock(&ar->conf_mutex); ba9177fcef21fa Carl Huang 2022-03-14 659 = ba9177fcef21fa Carl Huang 2022-03-14 660 ret =3D ath11k_hif_resume(ar->a= b); ba9177fcef21fa Carl Huang 2022-03-14 661 if (ret) { ba9177fcef21fa Carl Huang 2022-03-14 662 ath11k_warn(ar->ab, "failed to= resume hif: %d\n", ret); ba9177fcef21fa Carl Huang 2022-03-14 663 goto exit; ba9177fcef21fa Carl Huang 2022-03-14 664 } ba9177fcef21fa Carl Huang 2022-03-14 665 = ba9177fcef21fa Carl Huang 2022-03-14 666 ath11k_hif_ce_irq_enable(ar->ab= ); ba9177fcef21fa Carl Huang 2022-03-14 667 ath11k_hif_irq_enable(ar->ab); ba9177fcef21fa Carl Huang 2022-03-14 668 = 90bf5c8d0f7ecd Carl Huang 2022-03-14 669 ret =3D ath11k_dp_rx_pktlog_sta= rt(ar->ab); 90bf5c8d0f7ecd Carl Huang 2022-03-14 670 if (ret) { 90bf5c8d0f7ecd Carl Huang 2022-03-14 671 ath11k_warn(ar->ab, "failed to= start rx pktlog from wow: %d\n", ret); 90bf5c8d0f7ecd Carl Huang 2022-03-14 672 return ret; 90bf5c8d0f7ecd Carl Huang 2022-03-14 673 } 90bf5c8d0f7ecd Carl Huang 2022-03-14 674 = ba9177fcef21fa Carl Huang 2022-03-14 675 ret =3D ath11k_wow_wakeup(ar->a= b); fec4b898f369a9 Carl Huang 2022-03-14 676 if (ret) { ba9177fcef21fa Carl Huang 2022-03-14 677 ath11k_warn(ar->ab, "failed to= wakeup from wow: %d\n", ret); fec4b898f369a9 Carl Huang 2022-03-14 678 goto exit; fec4b898f369a9 Carl Huang 2022-03-14 679 } fec4b898f369a9 Carl Huang 2022-03-14 680 = fec4b898f369a9 Carl Huang 2022-03-14 681 ret =3D ath11k_wow_nlo_cleanup(= ar); fec4b898f369a9 Carl Huang 2022-03-14 682 if (ret) { fec4b898f369a9 Carl Huang 2022-03-14 683 ath11k_warn(ar->ab, "failed to= cleanup nlo: %d\n", ret); fec4b898f369a9 Carl Huang 2022-03-14 684 goto exit; fec4b898f369a9 Carl Huang 2022-03-14 685 } ba9177fcef21fa Carl Huang 2022-03-14 686 = c417b247ba0421 Carl Huang 2022-03-14 687 ret =3D ath11k_wow_clear_hw_fil= ter(ar); c417b247ba0421 Carl Huang 2022-03-14 688 if (ret) { c417b247ba0421 Carl Huang 2022-03-14 689 ath11k_warn(ar->ab, "failed to= clear hw filter: %d\n", ret); c417b247ba0421 Carl Huang 2022-03-14 690 goto exit; c417b247ba0421 Carl Huang 2022-03-14 691 } c417b247ba0421 Carl Huang 2022-03-14 692 = ba9177fcef21fa Carl Huang 2022-03-14 693 exit: ba9177fcef21fa Carl Huang 2022-03-14 694 if (ret) { ba9177fcef21fa Carl Huang 2022-03-14 695 switch (ar->state) { ba9177fcef21fa Carl Huang 2022-03-14 696 case ATH11K_STATE_ON: ba9177fcef21fa Carl Huang 2022-03-14 697 ar->state =3D ATH11K_STATE_RE= STARTING; ba9177fcef21fa Carl Huang 2022-03-14 698 ret =3D 1; ba9177fcef21fa Carl Huang 2022-03-14 699 break; ba9177fcef21fa Carl Huang 2022-03-14 700 case ATH11K_STATE_OFF: ba9177fcef21fa Carl Huang 2022-03-14 701 case ATH11K_STATE_RESTARTING: ba9177fcef21fa Carl Huang 2022-03-14 702 case ATH11K_STATE_RESTARTED: ba9177fcef21fa Carl Huang 2022-03-14 703 case ATH11K_STATE_WEDGED: ba9177fcef21fa Carl Huang 2022-03-14 704 ath11k_warn(ar->ab, "encounte= red unexpected device state %d on resume, cannot recover\n", ba9177fcef21fa Carl Huang 2022-03-14 705 ar->state); ba9177fcef21fa Carl Huang 2022-03-14 706 ret =3D -EIO; ba9177fcef21fa Carl Huang 2022-03-14 707 break; ba9177fcef21fa Carl Huang 2022-03-14 708 } ba9177fcef21fa Carl Huang 2022-03-14 709 } ba9177fcef21fa Carl Huang 2022-03-14 710 = ba9177fcef21fa Carl Huang 2022-03-14 711 mutex_unlock(&ar->conf_mutex); ba9177fcef21fa Carl Huang 2022-03-14 @712 return ret; ba9177fcef21fa Carl Huang 2022-03-14 713 } ba9177fcef21fa Carl Huang 2022-03-14 714 = :::::: The code at line 712 was first introduced by commit :::::: ba9177fcef21fa98406e73c472b5ac2eb4ec5f31 ath11k: Add basic WoW funct= ionalities :::::: TO: Carl Huang :::::: CC: Kalle Valo -- = 0-DAY CI Kernel Test Service https://01.org/lkp --===============8115581885908957050==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============2436643759410221725==" MIME-Version: 1.0 From: Dan Carpenter To: kbuild-all@lists.01.org Subject: [linux-next:master 408/8237] drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex'. Date: Wed, 04 May 2022 11:46:27 +0300 Message-ID: <202205032236.kofEquX3-lkp@intel.com> List-Id: --===============2436643759410221725== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git= master head: 44a2f39e611ac0bc1f17c288a583d7f2e5684aa7 commit: 90bf5c8d0f7ecddf96fc1cd9434af4e157b51970 [408/8237] ath11k: purge r= x pktlog when entering WoW config: i386-randconfig-m021-20220502 (https://download.01.org/0day-ci/arch= ive/20220503/202205032236.kofEquX3-lkp(a)intel.com/config) compiler: gcc-11 (Debian 11.2.0-20) 11.2.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Reported-by: Dan Carpenter smatch warnings: drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inco= nsistent returns '&ar->conf_mutex'. vim +712 drivers/net/wireless/ath/ath11k/wow.c ba9177fcef21fa Carl Huang 2022-03-14 653 int ath11k_wow_op_resume(struct = ieee80211_hw *hw) ba9177fcef21fa Carl Huang 2022-03-14 654 { ba9177fcef21fa Carl Huang 2022-03-14 655 struct ath11k *ar =3D hw->priv; ba9177fcef21fa Carl Huang 2022-03-14 656 int ret; ba9177fcef21fa Carl Huang 2022-03-14 657 = ba9177fcef21fa Carl Huang 2022-03-14 658 mutex_lock(&ar->conf_mutex); ba9177fcef21fa Carl Huang 2022-03-14 659 = ba9177fcef21fa Carl Huang 2022-03-14 660 ret =3D ath11k_hif_resume(ar->a= b); ba9177fcef21fa Carl Huang 2022-03-14 661 if (ret) { ba9177fcef21fa Carl Huang 2022-03-14 662 ath11k_warn(ar->ab, "failed to= resume hif: %d\n", ret); ba9177fcef21fa Carl Huang 2022-03-14 663 goto exit; ba9177fcef21fa Carl Huang 2022-03-14 664 } ba9177fcef21fa Carl Huang 2022-03-14 665 = ba9177fcef21fa Carl Huang 2022-03-14 666 ath11k_hif_ce_irq_enable(ar->ab= ); ba9177fcef21fa Carl Huang 2022-03-14 667 ath11k_hif_irq_enable(ar->ab); ba9177fcef21fa Carl Huang 2022-03-14 668 = 90bf5c8d0f7ecd Carl Huang 2022-03-14 669 ret =3D ath11k_dp_rx_pktlog_sta= rt(ar->ab); 90bf5c8d0f7ecd Carl Huang 2022-03-14 670 if (ret) { 90bf5c8d0f7ecd Carl Huang 2022-03-14 671 ath11k_warn(ar->ab, "failed to= start rx pktlog from wow: %d\n", ret); 90bf5c8d0f7ecd Carl Huang 2022-03-14 672 return ret; goto exit; 90bf5c8d0f7ecd Carl Huang 2022-03-14 673 } 90bf5c8d0f7ecd Carl Huang 2022-03-14 674 = ba9177fcef21fa Carl Huang 2022-03-14 675 ret =3D ath11k_wow_wakeup(ar->a= b); fec4b898f369a9 Carl Huang 2022-03-14 676 if (ret) { ba9177fcef21fa Carl Huang 2022-03-14 677 ath11k_warn(ar->ab, "failed to= wakeup from wow: %d\n", ret); fec4b898f369a9 Carl Huang 2022-03-14 678 goto exit; fec4b898f369a9 Carl Huang 2022-03-14 679 } fec4b898f369a9 Carl Huang 2022-03-14 680 = fec4b898f369a9 Carl Huang 2022-03-14 681 ret =3D ath11k_wow_nlo_cleanup(= ar); fec4b898f369a9 Carl Huang 2022-03-14 682 if (ret) { fec4b898f369a9 Carl Huang 2022-03-14 683 ath11k_warn(ar->ab, "failed to= cleanup nlo: %d\n", ret); fec4b898f369a9 Carl Huang 2022-03-14 684 goto exit; fec4b898f369a9 Carl Huang 2022-03-14 685 } ba9177fcef21fa Carl Huang 2022-03-14 686 = c417b247ba0421 Carl Huang 2022-03-14 687 ret =3D ath11k_wow_clear_hw_fil= ter(ar); c417b247ba0421 Carl Huang 2022-03-14 688 if (ret) { c417b247ba0421 Carl Huang 2022-03-14 689 ath11k_warn(ar->ab, "failed to= clear hw filter: %d\n", ret); c417b247ba0421 Carl Huang 2022-03-14 690 goto exit; c417b247ba0421 Carl Huang 2022-03-14 691 } c417b247ba0421 Carl Huang 2022-03-14 692 = ba9177fcef21fa Carl Huang 2022-03-14 693 exit: ba9177fcef21fa Carl Huang 2022-03-14 694 if (ret) { ba9177fcef21fa Carl Huang 2022-03-14 695 switch (ar->state) { ba9177fcef21fa Carl Huang 2022-03-14 696 case ATH11K_STATE_ON: ba9177fcef21fa Carl Huang 2022-03-14 697 ar->state =3D ATH11K_STATE_RE= STARTING; ba9177fcef21fa Carl Huang 2022-03-14 698 ret =3D 1; ba9177fcef21fa Carl Huang 2022-03-14 699 break; ba9177fcef21fa Carl Huang 2022-03-14 700 case ATH11K_STATE_OFF: ba9177fcef21fa Carl Huang 2022-03-14 701 case ATH11K_STATE_RESTARTING: ba9177fcef21fa Carl Huang 2022-03-14 702 case ATH11K_STATE_RESTARTED: ba9177fcef21fa Carl Huang 2022-03-14 703 case ATH11K_STATE_WEDGED: ba9177fcef21fa Carl Huang 2022-03-14 704 ath11k_warn(ar->ab, "encounte= red unexpected device state %d on resume, cannot recover\n", ba9177fcef21fa Carl Huang 2022-03-14 705 ar->state); ba9177fcef21fa Carl Huang 2022-03-14 706 ret =3D -EIO; ba9177fcef21fa Carl Huang 2022-03-14 707 break; ba9177fcef21fa Carl Huang 2022-03-14 708 } ba9177fcef21fa Carl Huang 2022-03-14 709 } ba9177fcef21fa Carl Huang 2022-03-14 710 = ba9177fcef21fa Carl Huang 2022-03-14 711 mutex_unlock(&ar->conf_mutex); ba9177fcef21fa Carl Huang 2022-03-14 @712 return ret; ba9177fcef21fa Carl Huang 2022-03-14 713 } -- = 0-DAY CI Kernel Test Service https://01.org/lkp --===============2436643759410221725==--