From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91F9DC433EF for ; Thu, 5 May 2022 01:39:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235865AbiEEBmm (ORCPT ); Wed, 4 May 2022 21:42:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229884AbiEEBml (ORCPT ); Wed, 4 May 2022 21:42:41 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36E0128E3E for ; Wed, 4 May 2022 18:39:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 148826195F for ; Thu, 5 May 2022 01:39:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB042C385A5; Thu, 5 May 2022 01:38:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651714742; bh=ik5Di7uV1iag3ez/E3W7W0tWUJSnYIRUediKmqnR8ng=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DKeKNOY1cwl8htld4UL83sbEi4l1R0+kGiJQqDnVw/+A/G5iy2kiMV8AllhvneOI1 mP6zB75AuOBqTK7C1efiOJfDW/Birj7EYU9xM8wlErpP0cMF77KW+Fct8gS0mChIsn /NzgqjtT3X/a9gbxeRZm3+1PT2LBsUZ1X0nXATUKO6rBt5UpuhTF0iuUVlxnmdkJAu iQtZC+Sq8GVz8XY53gs1Ui+Ot7RTvfUL+wHZ0pcWgov9gj3TGAPb6HbKcQHOYE+0mF GmqFgpJLkG9zxIvRpuYrLB7/v55vgt+CfCMX7LfWBWAMdvgkNRSx2UjFJBVhHOX88G 7UMRqtGXVBNbg== Date: Thu, 5 May 2022 09:38:54 +0800 From: Shawn Guo To: Lucas Stach Cc: Rob Herring , Krzysztof Kozlowski , Fabio Estevam , Pengutronix Kernel Team , NXP Linux Team , Laurent Pinchart , Paul Elder , Marek Vasut , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 00/11] consolidated i.MX8MP HSIO/MEDIA/HDMI blk-ctrl series Message-ID: <20220505013854.GE14615@dragon> References: <20220406153402.1265474-1-l.stach@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220406153402.1265474-1-l.stach@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Apr 06, 2022 at 05:33:51PM +0200, Lucas Stach wrote: > Hi all, > > this series adds a bunch more power domains that integrate with the blk-ctrls > to the i.MX8MP. It depends on the i.MX8MP GPCv2 support series posted in [1]. > > The HSIO blk-ctrl bindings are already applied upstream, so they are not part > of this series anymore. The DT description hasn't changed, but the > implementation of the HSIO blk-ctrl driver is reworked quite a bit from the > last round of patches, so I've dropped the review/tested-by tags. > > I've also picked up the pretty thoroughly reviewed and tested MEDIA blk-ctrl > patches from Paul and Laurent into this series, as they would conflict with > other patches from this series when applied separately. This should hopefully > make it easier for Shawn to pick things up. > > Finally this now also adds the HDMI blk-ctrl, not part of any previous series. > This one is pretty complex and the documentation in the reference manual > appears to be inaccurate. I found at least the following issues: > > 1. GLOBAL_XTAL24M_CLK_EN does not actually gate the 24MHz reference clock, > the PHY PLL happily locks and provides correct clocks without this clock being > ungated. It seems to gate some clock input of the HDMI TX controller instead, > register access to this controller fails without this clock. > > 2. HDMI_RTX_RESET_CTL0 bits 6 and 7 are marked as "reserved" in the manual, > but they are actually required to be configured. Bit 6 seems to keep something > in the display pixel clock path in inactive state and Bit 7 seems to reset > the HDMI TX i2c controller. > > The HDMI blk-ctrl part is tested quite extensively with a PoC HDMI support > patchset, which I will send out in a bit, so I'm pretty sure that the > support as implemented is working. I've put the patches last in the series > in case that this turns out to be controversial, so the other patches can > be applied independent from the HDMI support. > > Regards, > Lucas > > [1] https://lore.kernel.org/all/20220330104620.3600159-1-l.stach@pengutronix.de/ > > > Laurent Pinchart (1): > arm64: dts: imx8mp: Add MEDIAMIX power domains > > Lucas Stach (7): > soc: imx: imx8m-blk-ctrl: set power device name > soc: imx: add i.MX8MP HSIO blk-ctrl > dt-bindings: power: imx8mp: add defines for HDMI blk-ctrl domains > dt-bindings: soc: add binding for i.MX8MP HDMI blk-ctrl > soc: imx: add i.MX8MP HDMI blk-ctrl > arm64: dts: imx8mp: add HSIO power-domains > arm64: dts: imx8mp: add HDMI power-domains Applied all except this one. Shawn > > Paul Elder (3): > dt-bindings: soc: Add i.MX8MP media block control DT bindings > soc: imx: imx8m-blk-ctrl: Add i.MX8MP media blk-ctrl > arm64: dts: imx8mp: Add MEDIA_BLK_CTRL > > .../soc/imx/fsl,imx8mp-hdmi-blk-ctrl.yaml | 84 +++ > .../soc/imx/fsl,imx8mp-media-blk-ctrl.yaml | 104 +++ > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 153 +++- > drivers/soc/imx/Makefile | 1 + > drivers/soc/imx/imx8m-blk-ctrl.c | 124 +++- > drivers/soc/imx/imx8mp-blk-ctrl.c | 696 ++++++++++++++++++ > include/dt-bindings/power/imx8mp-power.h | 18 + > 7 files changed, 1172 insertions(+), 8 deletions(-) > create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-hdmi-blk-ctrl.yaml > create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml > create mode 100644 drivers/soc/imx/imx8mp-blk-ctrl.c > > -- > 2.30.2 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1EFD9C433F5 for ; Thu, 5 May 2022 01:40:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=R9FIzQgPukdHJKHgvfSDSHhYkreaqwL93FyY1YiklQI=; b=zHheOf/g70XMDs 7sqyc884rcHcq1ncMuonI0w0OPXuQiwH+3Ydt+d3IKEKjBqFbOOjxQD48EezxWMcYogU9H1ElKTMI wYWR5hzX9gQJ+ZPqUw80332ZM9d6pB0oJnmVWqk+Wdl7wv481upUO1HLBj1czY9O+HK81+IcelqgZ k/e7XN2u6lMU9H2RylM7xDBiYY7J73XQqeyGNR3byoj7oQQN2gkUnLz6VbgruU1fuLNQVpYaolxkd JBlLatEG9q42msM4+ZYmfeaj8ChZgj/E7fhKM5zNtsF9Exgusv7P8ZGEWs1aYgjUQqaZ8nPiBujn/ pNkXCUK5n/YxJBQ9AWYA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmQSS-00DWHD-G8; Thu, 05 May 2022 01:39:08 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmQSP-00DWFA-DO for linux-arm-kernel@lists.infradead.org; Thu, 05 May 2022 01:39:07 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9C11CB82A83; Thu, 5 May 2022 01:39:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB042C385A5; Thu, 5 May 2022 01:38:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651714742; bh=ik5Di7uV1iag3ez/E3W7W0tWUJSnYIRUediKmqnR8ng=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DKeKNOY1cwl8htld4UL83sbEi4l1R0+kGiJQqDnVw/+A/G5iy2kiMV8AllhvneOI1 mP6zB75AuOBqTK7C1efiOJfDW/Birj7EYU9xM8wlErpP0cMF77KW+Fct8gS0mChIsn /NzgqjtT3X/a9gbxeRZm3+1PT2LBsUZ1X0nXATUKO6rBt5UpuhTF0iuUVlxnmdkJAu iQtZC+Sq8GVz8XY53gs1Ui+Ot7RTvfUL+wHZ0pcWgov9gj3TGAPb6HbKcQHOYE+0mF GmqFgpJLkG9zxIvRpuYrLB7/v55vgt+CfCMX7LfWBWAMdvgkNRSx2UjFJBVhHOX88G 7UMRqtGXVBNbg== Date: Thu, 5 May 2022 09:38:54 +0800 From: Shawn Guo To: Lucas Stach Cc: Rob Herring , Krzysztof Kozlowski , Fabio Estevam , Pengutronix Kernel Team , NXP Linux Team , Laurent Pinchart , Paul Elder , Marek Vasut , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 00/11] consolidated i.MX8MP HSIO/MEDIA/HDMI blk-ctrl series Message-ID: <20220505013854.GE14615@dragon> References: <20220406153402.1265474-1-l.stach@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220406153402.1265474-1-l.stach@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220504_183905_778089_9763FDBD X-CRM114-Status: GOOD ( 31.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 06, 2022 at 05:33:51PM +0200, Lucas Stach wrote: > Hi all, > > this series adds a bunch more power domains that integrate with the blk-ctrls > to the i.MX8MP. It depends on the i.MX8MP GPCv2 support series posted in [1]. > > The HSIO blk-ctrl bindings are already applied upstream, so they are not part > of this series anymore. The DT description hasn't changed, but the > implementation of the HSIO blk-ctrl driver is reworked quite a bit from the > last round of patches, so I've dropped the review/tested-by tags. > > I've also picked up the pretty thoroughly reviewed and tested MEDIA blk-ctrl > patches from Paul and Laurent into this series, as they would conflict with > other patches from this series when applied separately. This should hopefully > make it easier for Shawn to pick things up. > > Finally this now also adds the HDMI blk-ctrl, not part of any previous series. > This one is pretty complex and the documentation in the reference manual > appears to be inaccurate. I found at least the following issues: > > 1. GLOBAL_XTAL24M_CLK_EN does not actually gate the 24MHz reference clock, > the PHY PLL happily locks and provides correct clocks without this clock being > ungated. It seems to gate some clock input of the HDMI TX controller instead, > register access to this controller fails without this clock. > > 2. HDMI_RTX_RESET_CTL0 bits 6 and 7 are marked as "reserved" in the manual, > but they are actually required to be configured. Bit 6 seems to keep something > in the display pixel clock path in inactive state and Bit 7 seems to reset > the HDMI TX i2c controller. > > The HDMI blk-ctrl part is tested quite extensively with a PoC HDMI support > patchset, which I will send out in a bit, so I'm pretty sure that the > support as implemented is working. I've put the patches last in the series > in case that this turns out to be controversial, so the other patches can > be applied independent from the HDMI support. > > Regards, > Lucas > > [1] https://lore.kernel.org/all/20220330104620.3600159-1-l.stach@pengutronix.de/ > > > Laurent Pinchart (1): > arm64: dts: imx8mp: Add MEDIAMIX power domains > > Lucas Stach (7): > soc: imx: imx8m-blk-ctrl: set power device name > soc: imx: add i.MX8MP HSIO blk-ctrl > dt-bindings: power: imx8mp: add defines for HDMI blk-ctrl domains > dt-bindings: soc: add binding for i.MX8MP HDMI blk-ctrl > soc: imx: add i.MX8MP HDMI blk-ctrl > arm64: dts: imx8mp: add HSIO power-domains > arm64: dts: imx8mp: add HDMI power-domains Applied all except this one. Shawn > > Paul Elder (3): > dt-bindings: soc: Add i.MX8MP media block control DT bindings > soc: imx: imx8m-blk-ctrl: Add i.MX8MP media blk-ctrl > arm64: dts: imx8mp: Add MEDIA_BLK_CTRL > > .../soc/imx/fsl,imx8mp-hdmi-blk-ctrl.yaml | 84 +++ > .../soc/imx/fsl,imx8mp-media-blk-ctrl.yaml | 104 +++ > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 153 +++- > drivers/soc/imx/Makefile | 1 + > drivers/soc/imx/imx8m-blk-ctrl.c | 124 +++- > drivers/soc/imx/imx8mp-blk-ctrl.c | 696 ++++++++++++++++++ > include/dt-bindings/power/imx8mp-power.h | 18 + > 7 files changed, 1172 insertions(+), 8 deletions(-) > create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-hdmi-blk-ctrl.yaml > create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml > create mode 100644 drivers/soc/imx/imx8mp-blk-ctrl.c > > -- > 2.30.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel