* [linux-next:master 408/8237] drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex'.
@ 2022-05-04 8:46 ` Dan Carpenter
0 siblings, 0 replies; 24+ messages in thread
From: kernel test robot @ 2022-05-03 14:36 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 5380 bytes --]
CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: Linux Memory Management List <linux-mm@kvack.org>
TO: Carl Huang <quic_cjhuang@quicinc.com>
CC: Kalle Valo <quic_kvalo@quicinc.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 44a2f39e611ac0bc1f17c288a583d7f2e5684aa7
commit: 90bf5c8d0f7ecddf96fc1cd9434af4e157b51970 [408/8237] ath11k: purge rx pktlog when entering WoW
:::::: branch date: 7 hours ago
:::::: commit date: 7 weeks ago
config: i386-randconfig-m021-20220502 (https://download.01.org/0day-ci/archive/20220503/202205032236.kofEquX3-lkp(a)intel.com/config)
compiler: gcc-11 (Debian 11.2.0-20) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex'.
vim +712 drivers/net/wireless/ath/ath11k/wow.c
ba9177fcef21fa Carl Huang 2022-03-14 652
ba9177fcef21fa Carl Huang 2022-03-14 653 int ath11k_wow_op_resume(struct ieee80211_hw *hw)
ba9177fcef21fa Carl Huang 2022-03-14 654 {
ba9177fcef21fa Carl Huang 2022-03-14 655 struct ath11k *ar = hw->priv;
ba9177fcef21fa Carl Huang 2022-03-14 656 int ret;
ba9177fcef21fa Carl Huang 2022-03-14 657
ba9177fcef21fa Carl Huang 2022-03-14 658 mutex_lock(&ar->conf_mutex);
ba9177fcef21fa Carl Huang 2022-03-14 659
ba9177fcef21fa Carl Huang 2022-03-14 660 ret = ath11k_hif_resume(ar->ab);
ba9177fcef21fa Carl Huang 2022-03-14 661 if (ret) {
ba9177fcef21fa Carl Huang 2022-03-14 662 ath11k_warn(ar->ab, "failed to resume hif: %d\n", ret);
ba9177fcef21fa Carl Huang 2022-03-14 663 goto exit;
ba9177fcef21fa Carl Huang 2022-03-14 664 }
ba9177fcef21fa Carl Huang 2022-03-14 665
ba9177fcef21fa Carl Huang 2022-03-14 666 ath11k_hif_ce_irq_enable(ar->ab);
ba9177fcef21fa Carl Huang 2022-03-14 667 ath11k_hif_irq_enable(ar->ab);
ba9177fcef21fa Carl Huang 2022-03-14 668
90bf5c8d0f7ecd Carl Huang 2022-03-14 669 ret = ath11k_dp_rx_pktlog_start(ar->ab);
90bf5c8d0f7ecd Carl Huang 2022-03-14 670 if (ret) {
90bf5c8d0f7ecd Carl Huang 2022-03-14 671 ath11k_warn(ar->ab, "failed to start rx pktlog from wow: %d\n", ret);
90bf5c8d0f7ecd Carl Huang 2022-03-14 672 return ret;
90bf5c8d0f7ecd Carl Huang 2022-03-14 673 }
90bf5c8d0f7ecd Carl Huang 2022-03-14 674
ba9177fcef21fa Carl Huang 2022-03-14 675 ret = ath11k_wow_wakeup(ar->ab);
fec4b898f369a9 Carl Huang 2022-03-14 676 if (ret) {
ba9177fcef21fa Carl Huang 2022-03-14 677 ath11k_warn(ar->ab, "failed to wakeup from wow: %d\n", ret);
fec4b898f369a9 Carl Huang 2022-03-14 678 goto exit;
fec4b898f369a9 Carl Huang 2022-03-14 679 }
fec4b898f369a9 Carl Huang 2022-03-14 680
fec4b898f369a9 Carl Huang 2022-03-14 681 ret = ath11k_wow_nlo_cleanup(ar);
fec4b898f369a9 Carl Huang 2022-03-14 682 if (ret) {
fec4b898f369a9 Carl Huang 2022-03-14 683 ath11k_warn(ar->ab, "failed to cleanup nlo: %d\n", ret);
fec4b898f369a9 Carl Huang 2022-03-14 684 goto exit;
fec4b898f369a9 Carl Huang 2022-03-14 685 }
ba9177fcef21fa Carl Huang 2022-03-14 686
c417b247ba0421 Carl Huang 2022-03-14 687 ret = ath11k_wow_clear_hw_filter(ar);
c417b247ba0421 Carl Huang 2022-03-14 688 if (ret) {
c417b247ba0421 Carl Huang 2022-03-14 689 ath11k_warn(ar->ab, "failed to clear hw filter: %d\n", ret);
c417b247ba0421 Carl Huang 2022-03-14 690 goto exit;
c417b247ba0421 Carl Huang 2022-03-14 691 }
c417b247ba0421 Carl Huang 2022-03-14 692
ba9177fcef21fa Carl Huang 2022-03-14 693 exit:
ba9177fcef21fa Carl Huang 2022-03-14 694 if (ret) {
ba9177fcef21fa Carl Huang 2022-03-14 695 switch (ar->state) {
ba9177fcef21fa Carl Huang 2022-03-14 696 case ATH11K_STATE_ON:
ba9177fcef21fa Carl Huang 2022-03-14 697 ar->state = ATH11K_STATE_RESTARTING;
ba9177fcef21fa Carl Huang 2022-03-14 698 ret = 1;
ba9177fcef21fa Carl Huang 2022-03-14 699 break;
ba9177fcef21fa Carl Huang 2022-03-14 700 case ATH11K_STATE_OFF:
ba9177fcef21fa Carl Huang 2022-03-14 701 case ATH11K_STATE_RESTARTING:
ba9177fcef21fa Carl Huang 2022-03-14 702 case ATH11K_STATE_RESTARTED:
ba9177fcef21fa Carl Huang 2022-03-14 703 case ATH11K_STATE_WEDGED:
ba9177fcef21fa Carl Huang 2022-03-14 704 ath11k_warn(ar->ab, "encountered unexpected device state %d on resume, cannot recover\n",
ba9177fcef21fa Carl Huang 2022-03-14 705 ar->state);
ba9177fcef21fa Carl Huang 2022-03-14 706 ret = -EIO;
ba9177fcef21fa Carl Huang 2022-03-14 707 break;
ba9177fcef21fa Carl Huang 2022-03-14 708 }
ba9177fcef21fa Carl Huang 2022-03-14 709 }
ba9177fcef21fa Carl Huang 2022-03-14 710
ba9177fcef21fa Carl Huang 2022-03-14 711 mutex_unlock(&ar->conf_mutex);
ba9177fcef21fa Carl Huang 2022-03-14 @712 return ret;
ba9177fcef21fa Carl Huang 2022-03-14 713 }
ba9177fcef21fa Carl Huang 2022-03-14 714
:::::: The code at line 712 was first introduced by commit
:::::: ba9177fcef21fa98406e73c472b5ac2eb4ec5f31 ath11k: Add basic WoW functionalities
:::::: TO: Carl Huang <quic_cjhuang@quicinc.com>
:::::: CC: Kalle Valo <quic_kvalo@quicinc.com>
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 24+ messages in thread* [linux-next:master 408/8237] drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex'. @ 2022-05-04 8:46 ` Dan Carpenter 0 siblings, 0 replies; 24+ messages in thread From: Dan Carpenter @ 2022-05-04 8:46 UTC (permalink / raw) To: kbuild-all [-- Attachment #1: Type: text/plain, Size: 4799 bytes --] tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 44a2f39e611ac0bc1f17c288a583d7f2e5684aa7 commit: 90bf5c8d0f7ecddf96fc1cd9434af4e157b51970 [408/8237] ath11k: purge rx pktlog when entering WoW config: i386-randconfig-m021-20220502 (https://download.01.org/0day-ci/archive/20220503/202205032236.kofEquX3-lkp(a)intel.com/config) compiler: gcc-11 (Debian 11.2.0-20) 11.2.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> Reported-by: Dan Carpenter <dan.carpenter@oracle.com> smatch warnings: drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex'. vim +712 drivers/net/wireless/ath/ath11k/wow.c ba9177fcef21fa Carl Huang 2022-03-14 653 int ath11k_wow_op_resume(struct ieee80211_hw *hw) ba9177fcef21fa Carl Huang 2022-03-14 654 { ba9177fcef21fa Carl Huang 2022-03-14 655 struct ath11k *ar = hw->priv; ba9177fcef21fa Carl Huang 2022-03-14 656 int ret; ba9177fcef21fa Carl Huang 2022-03-14 657 ba9177fcef21fa Carl Huang 2022-03-14 658 mutex_lock(&ar->conf_mutex); ba9177fcef21fa Carl Huang 2022-03-14 659 ba9177fcef21fa Carl Huang 2022-03-14 660 ret = ath11k_hif_resume(ar->ab); ba9177fcef21fa Carl Huang 2022-03-14 661 if (ret) { ba9177fcef21fa Carl Huang 2022-03-14 662 ath11k_warn(ar->ab, "failed to resume hif: %d\n", ret); ba9177fcef21fa Carl Huang 2022-03-14 663 goto exit; ba9177fcef21fa Carl Huang 2022-03-14 664 } ba9177fcef21fa Carl Huang 2022-03-14 665 ba9177fcef21fa Carl Huang 2022-03-14 666 ath11k_hif_ce_irq_enable(ar->ab); ba9177fcef21fa Carl Huang 2022-03-14 667 ath11k_hif_irq_enable(ar->ab); ba9177fcef21fa Carl Huang 2022-03-14 668 90bf5c8d0f7ecd Carl Huang 2022-03-14 669 ret = ath11k_dp_rx_pktlog_start(ar->ab); 90bf5c8d0f7ecd Carl Huang 2022-03-14 670 if (ret) { 90bf5c8d0f7ecd Carl Huang 2022-03-14 671 ath11k_warn(ar->ab, "failed to start rx pktlog from wow: %d\n", ret); 90bf5c8d0f7ecd Carl Huang 2022-03-14 672 return ret; goto exit; 90bf5c8d0f7ecd Carl Huang 2022-03-14 673 } 90bf5c8d0f7ecd Carl Huang 2022-03-14 674 ba9177fcef21fa Carl Huang 2022-03-14 675 ret = ath11k_wow_wakeup(ar->ab); fec4b898f369a9 Carl Huang 2022-03-14 676 if (ret) { ba9177fcef21fa Carl Huang 2022-03-14 677 ath11k_warn(ar->ab, "failed to wakeup from wow: %d\n", ret); fec4b898f369a9 Carl Huang 2022-03-14 678 goto exit; fec4b898f369a9 Carl Huang 2022-03-14 679 } fec4b898f369a9 Carl Huang 2022-03-14 680 fec4b898f369a9 Carl Huang 2022-03-14 681 ret = ath11k_wow_nlo_cleanup(ar); fec4b898f369a9 Carl Huang 2022-03-14 682 if (ret) { fec4b898f369a9 Carl Huang 2022-03-14 683 ath11k_warn(ar->ab, "failed to cleanup nlo: %d\n", ret); fec4b898f369a9 Carl Huang 2022-03-14 684 goto exit; fec4b898f369a9 Carl Huang 2022-03-14 685 } ba9177fcef21fa Carl Huang 2022-03-14 686 c417b247ba0421 Carl Huang 2022-03-14 687 ret = ath11k_wow_clear_hw_filter(ar); c417b247ba0421 Carl Huang 2022-03-14 688 if (ret) { c417b247ba0421 Carl Huang 2022-03-14 689 ath11k_warn(ar->ab, "failed to clear hw filter: %d\n", ret); c417b247ba0421 Carl Huang 2022-03-14 690 goto exit; c417b247ba0421 Carl Huang 2022-03-14 691 } c417b247ba0421 Carl Huang 2022-03-14 692 ba9177fcef21fa Carl Huang 2022-03-14 693 exit: ba9177fcef21fa Carl Huang 2022-03-14 694 if (ret) { ba9177fcef21fa Carl Huang 2022-03-14 695 switch (ar->state) { ba9177fcef21fa Carl Huang 2022-03-14 696 case ATH11K_STATE_ON: ba9177fcef21fa Carl Huang 2022-03-14 697 ar->state = ATH11K_STATE_RESTARTING; ba9177fcef21fa Carl Huang 2022-03-14 698 ret = 1; ba9177fcef21fa Carl Huang 2022-03-14 699 break; ba9177fcef21fa Carl Huang 2022-03-14 700 case ATH11K_STATE_OFF: ba9177fcef21fa Carl Huang 2022-03-14 701 case ATH11K_STATE_RESTARTING: ba9177fcef21fa Carl Huang 2022-03-14 702 case ATH11K_STATE_RESTARTED: ba9177fcef21fa Carl Huang 2022-03-14 703 case ATH11K_STATE_WEDGED: ba9177fcef21fa Carl Huang 2022-03-14 704 ath11k_warn(ar->ab, "encountered unexpected device state %d on resume, cannot recover\n", ba9177fcef21fa Carl Huang 2022-03-14 705 ar->state); ba9177fcef21fa Carl Huang 2022-03-14 706 ret = -EIO; ba9177fcef21fa Carl Huang 2022-03-14 707 break; ba9177fcef21fa Carl Huang 2022-03-14 708 } ba9177fcef21fa Carl Huang 2022-03-14 709 } ba9177fcef21fa Carl Huang 2022-03-14 710 ba9177fcef21fa Carl Huang 2022-03-14 711 mutex_unlock(&ar->conf_mutex); ba9177fcef21fa Carl Huang 2022-03-14 @712 return ret; ba9177fcef21fa Carl Huang 2022-03-14 713 } -- 0-DAY CI Kernel Test Service https://01.org/lkp ^ permalink raw reply [flat|nested] 24+ messages in thread
* [linux-next:master 408/8237] drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex'. @ 2022-05-04 8:46 ` Dan Carpenter 0 siblings, 0 replies; 24+ messages in thread From: Dan Carpenter @ 2022-05-04 8:46 UTC (permalink / raw) To: kbuild, Carl Huang Cc: lkp, kbuild-all, Linux Memory Management List, Kalle Valo tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 44a2f39e611ac0bc1f17c288a583d7f2e5684aa7 commit: 90bf5c8d0f7ecddf96fc1cd9434af4e157b51970 [408/8237] ath11k: purge rx pktlog when entering WoW config: i386-randconfig-m021-20220502 (https://download.01.org/0day-ci/archive/20220503/202205032236.kofEquX3-lkp@intel.com/config) compiler: gcc-11 (Debian 11.2.0-20) 11.2.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> Reported-by: Dan Carpenter <dan.carpenter@oracle.com> smatch warnings: drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex'. vim +712 drivers/net/wireless/ath/ath11k/wow.c ba9177fcef21fa Carl Huang 2022-03-14 653 int ath11k_wow_op_resume(struct ieee80211_hw *hw) ba9177fcef21fa Carl Huang 2022-03-14 654 { ba9177fcef21fa Carl Huang 2022-03-14 655 struct ath11k *ar = hw->priv; ba9177fcef21fa Carl Huang 2022-03-14 656 int ret; ba9177fcef21fa Carl Huang 2022-03-14 657 ba9177fcef21fa Carl Huang 2022-03-14 658 mutex_lock(&ar->conf_mutex); ba9177fcef21fa Carl Huang 2022-03-14 659 ba9177fcef21fa Carl Huang 2022-03-14 660 ret = ath11k_hif_resume(ar->ab); ba9177fcef21fa Carl Huang 2022-03-14 661 if (ret) { ba9177fcef21fa Carl Huang 2022-03-14 662 ath11k_warn(ar->ab, "failed to resume hif: %d\n", ret); ba9177fcef21fa Carl Huang 2022-03-14 663 goto exit; ba9177fcef21fa Carl Huang 2022-03-14 664 } ba9177fcef21fa Carl Huang 2022-03-14 665 ba9177fcef21fa Carl Huang 2022-03-14 666 ath11k_hif_ce_irq_enable(ar->ab); ba9177fcef21fa Carl Huang 2022-03-14 667 ath11k_hif_irq_enable(ar->ab); ba9177fcef21fa Carl Huang 2022-03-14 668 90bf5c8d0f7ecd Carl Huang 2022-03-14 669 ret = ath11k_dp_rx_pktlog_start(ar->ab); 90bf5c8d0f7ecd Carl Huang 2022-03-14 670 if (ret) { 90bf5c8d0f7ecd Carl Huang 2022-03-14 671 ath11k_warn(ar->ab, "failed to start rx pktlog from wow: %d\n", ret); 90bf5c8d0f7ecd Carl Huang 2022-03-14 672 return ret; goto exit; 90bf5c8d0f7ecd Carl Huang 2022-03-14 673 } 90bf5c8d0f7ecd Carl Huang 2022-03-14 674 ba9177fcef21fa Carl Huang 2022-03-14 675 ret = ath11k_wow_wakeup(ar->ab); fec4b898f369a9 Carl Huang 2022-03-14 676 if (ret) { ba9177fcef21fa Carl Huang 2022-03-14 677 ath11k_warn(ar->ab, "failed to wakeup from wow: %d\n", ret); fec4b898f369a9 Carl Huang 2022-03-14 678 goto exit; fec4b898f369a9 Carl Huang 2022-03-14 679 } fec4b898f369a9 Carl Huang 2022-03-14 680 fec4b898f369a9 Carl Huang 2022-03-14 681 ret = ath11k_wow_nlo_cleanup(ar); fec4b898f369a9 Carl Huang 2022-03-14 682 if (ret) { fec4b898f369a9 Carl Huang 2022-03-14 683 ath11k_warn(ar->ab, "failed to cleanup nlo: %d\n", ret); fec4b898f369a9 Carl Huang 2022-03-14 684 goto exit; fec4b898f369a9 Carl Huang 2022-03-14 685 } ba9177fcef21fa Carl Huang 2022-03-14 686 c417b247ba0421 Carl Huang 2022-03-14 687 ret = ath11k_wow_clear_hw_filter(ar); c417b247ba0421 Carl Huang 2022-03-14 688 if (ret) { c417b247ba0421 Carl Huang 2022-03-14 689 ath11k_warn(ar->ab, "failed to clear hw filter: %d\n", ret); c417b247ba0421 Carl Huang 2022-03-14 690 goto exit; c417b247ba0421 Carl Huang 2022-03-14 691 } c417b247ba0421 Carl Huang 2022-03-14 692 ba9177fcef21fa Carl Huang 2022-03-14 693 exit: ba9177fcef21fa Carl Huang 2022-03-14 694 if (ret) { ba9177fcef21fa Carl Huang 2022-03-14 695 switch (ar->state) { ba9177fcef21fa Carl Huang 2022-03-14 696 case ATH11K_STATE_ON: ba9177fcef21fa Carl Huang 2022-03-14 697 ar->state = ATH11K_STATE_RESTARTING; ba9177fcef21fa Carl Huang 2022-03-14 698 ret = 1; ba9177fcef21fa Carl Huang 2022-03-14 699 break; ba9177fcef21fa Carl Huang 2022-03-14 700 case ATH11K_STATE_OFF: ba9177fcef21fa Carl Huang 2022-03-14 701 case ATH11K_STATE_RESTARTING: ba9177fcef21fa Carl Huang 2022-03-14 702 case ATH11K_STATE_RESTARTED: ba9177fcef21fa Carl Huang 2022-03-14 703 case ATH11K_STATE_WEDGED: ba9177fcef21fa Carl Huang 2022-03-14 704 ath11k_warn(ar->ab, "encountered unexpected device state %d on resume, cannot recover\n", ba9177fcef21fa Carl Huang 2022-03-14 705 ar->state); ba9177fcef21fa Carl Huang 2022-03-14 706 ret = -EIO; ba9177fcef21fa Carl Huang 2022-03-14 707 break; ba9177fcef21fa Carl Huang 2022-03-14 708 } ba9177fcef21fa Carl Huang 2022-03-14 709 } ba9177fcef21fa Carl Huang 2022-03-14 710 ba9177fcef21fa Carl Huang 2022-03-14 711 mutex_unlock(&ar->conf_mutex); ba9177fcef21fa Carl Huang 2022-03-14 @712 return ret; ba9177fcef21fa Carl Huang 2022-03-14 713 } -- 0-DAY CI Kernel Test Service https://01.org/lkp ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [linux-next:master 408/8237] drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex'. 2022-05-04 8:46 ` Dan Carpenter (?) @ 2022-05-04 16:23 ` Kalle Valo -1 siblings, 0 replies; 24+ messages in thread From: Kalle Valo @ 2022-05-04 16:23 UTC (permalink / raw) To: Dan Carpenter Cc: kbuild, Carl Huang, lkp, kbuild-all, Linux Memory Management List, ath11k, Wen Gong + ath11k, wen Dan Carpenter <dan.carpenter@oracle.com> writes: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 44a2f39e611ac0bc1f17c288a583d7f2e5684aa7 > commit: 90bf5c8d0f7ecddf96fc1cd9434af4e157b51970 [408/8237] ath11k: > purge rx pktlog when entering WoW > config: i386-randconfig-m021-20220502 > (https://download.01.org/0day-ci/archive/20220503/202205032236.kofEquX3-lkp@intel.com/config) > compiler: gcc-11 (Debian 11.2.0-20) 11.2.0 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@intel.com> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > > smatch warnings: > drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: > inconsistent returns '&ar->conf_mutex'. > > vim +712 drivers/net/wireless/ath/ath11k/wow.c > > ba9177fcef21fa Carl Huang 2022-03-14 653 int > ath11k_wow_op_resume(struct ieee80211_hw *hw) > ba9177fcef21fa Carl Huang 2022-03-14 654 { > ba9177fcef21fa Carl Huang 2022-03-14 655 struct ath11k *ar = hw->priv; > ba9177fcef21fa Carl Huang 2022-03-14 656 int ret; > ba9177fcef21fa Carl Huang 2022-03-14 657 > ba9177fcef21fa Carl Huang 2022-03-14 658 mutex_lock(&ar->conf_mutex); > ba9177fcef21fa Carl Huang 2022-03-14 659 > ba9177fcef21fa Carl Huang 2022-03-14 660 ret = ath11k_hif_resume(ar->ab); > ba9177fcef21fa Carl Huang 2022-03-14 661 if (ret) { > ba9177fcef21fa Carl Huang 2022-03-14 662 ath11k_warn(ar->ab, "failed > to resume hif: %d\n", ret); > ba9177fcef21fa Carl Huang 2022-03-14 663 goto exit; > ba9177fcef21fa Carl Huang 2022-03-14 664 } > ba9177fcef21fa Carl Huang 2022-03-14 665 > ba9177fcef21fa Carl Huang 2022-03-14 666 ath11k_hif_ce_irq_enable(ar->ab); > ba9177fcef21fa Carl Huang 2022-03-14 667 ath11k_hif_irq_enable(ar->ab); > ba9177fcef21fa Carl Huang 2022-03-14 668 > 90bf5c8d0f7ecd Carl Huang 2022-03-14 669 ret = ath11k_dp_rx_pktlog_start(ar->ab); > 90bf5c8d0f7ecd Carl Huang 2022-03-14 670 if (ret) { > 90bf5c8d0f7ecd Carl Huang 2022-03-14 671 ath11k_warn(ar->ab, "failed > to start rx pktlog from wow: %d\n", ret); > 90bf5c8d0f7ecd Carl Huang 2022-03-14 672 return ret; > > goto exit; Carl or Wen, are you able to send a fix for this? ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [linux-next:master 408/8237] drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex'. @ 2022-05-04 16:23 ` Kalle Valo 0 siblings, 0 replies; 24+ messages in thread From: Kalle Valo @ 2022-05-04 16:23 UTC (permalink / raw) To: kbuild-all [-- Attachment #1: Type: text/plain, Size: 2313 bytes --] + ath11k, wen Dan Carpenter <dan.carpenter@oracle.com> writes: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 44a2f39e611ac0bc1f17c288a583d7f2e5684aa7 > commit: 90bf5c8d0f7ecddf96fc1cd9434af4e157b51970 [408/8237] ath11k: > purge rx pktlog when entering WoW > config: i386-randconfig-m021-20220502 > (https://download.01.org/0day-ci/archive/20220503/202205032236.kofEquX3-lkp(a)intel.com/config) > compiler: gcc-11 (Debian 11.2.0-20) 11.2.0 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@intel.com> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > > smatch warnings: > drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: > inconsistent returns '&ar->conf_mutex'. > > vim +712 drivers/net/wireless/ath/ath11k/wow.c > > ba9177fcef21fa Carl Huang 2022-03-14 653 int > ath11k_wow_op_resume(struct ieee80211_hw *hw) > ba9177fcef21fa Carl Huang 2022-03-14 654 { > ba9177fcef21fa Carl Huang 2022-03-14 655 struct ath11k *ar = hw->priv; > ba9177fcef21fa Carl Huang 2022-03-14 656 int ret; > ba9177fcef21fa Carl Huang 2022-03-14 657 > ba9177fcef21fa Carl Huang 2022-03-14 658 mutex_lock(&ar->conf_mutex); > ba9177fcef21fa Carl Huang 2022-03-14 659 > ba9177fcef21fa Carl Huang 2022-03-14 660 ret = ath11k_hif_resume(ar->ab); > ba9177fcef21fa Carl Huang 2022-03-14 661 if (ret) { > ba9177fcef21fa Carl Huang 2022-03-14 662 ath11k_warn(ar->ab, "failed > to resume hif: %d\n", ret); > ba9177fcef21fa Carl Huang 2022-03-14 663 goto exit; > ba9177fcef21fa Carl Huang 2022-03-14 664 } > ba9177fcef21fa Carl Huang 2022-03-14 665 > ba9177fcef21fa Carl Huang 2022-03-14 666 ath11k_hif_ce_irq_enable(ar->ab); > ba9177fcef21fa Carl Huang 2022-03-14 667 ath11k_hif_irq_enable(ar->ab); > ba9177fcef21fa Carl Huang 2022-03-14 668 > 90bf5c8d0f7ecd Carl Huang 2022-03-14 669 ret = ath11k_dp_rx_pktlog_start(ar->ab); > 90bf5c8d0f7ecd Carl Huang 2022-03-14 670 if (ret) { > 90bf5c8d0f7ecd Carl Huang 2022-03-14 671 ath11k_warn(ar->ab, "failed > to start rx pktlog from wow: %d\n", ret); > 90bf5c8d0f7ecd Carl Huang 2022-03-14 672 return ret; > > goto exit; Carl or Wen, are you able to send a fix for this? ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [linux-next:master 408/8237] drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex'. @ 2022-05-04 16:23 ` Kalle Valo 0 siblings, 0 replies; 24+ messages in thread From: Kalle Valo @ 2022-05-04 16:23 UTC (permalink / raw) To: Dan Carpenter Cc: kbuild, Carl Huang, lkp, kbuild-all, Linux Memory Management List, ath11k, Wen Gong + ath11k, wen Dan Carpenter <dan.carpenter@oracle.com> writes: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 44a2f39e611ac0bc1f17c288a583d7f2e5684aa7 > commit: 90bf5c8d0f7ecddf96fc1cd9434af4e157b51970 [408/8237] ath11k: > purge rx pktlog when entering WoW > config: i386-randconfig-m021-20220502 > (https://download.01.org/0day-ci/archive/20220503/202205032236.kofEquX3-lkp@intel.com/config) > compiler: gcc-11 (Debian 11.2.0-20) 11.2.0 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@intel.com> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > > smatch warnings: > drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: > inconsistent returns '&ar->conf_mutex'. > > vim +712 drivers/net/wireless/ath/ath11k/wow.c > > ba9177fcef21fa Carl Huang 2022-03-14 653 int > ath11k_wow_op_resume(struct ieee80211_hw *hw) > ba9177fcef21fa Carl Huang 2022-03-14 654 { > ba9177fcef21fa Carl Huang 2022-03-14 655 struct ath11k *ar = hw->priv; > ba9177fcef21fa Carl Huang 2022-03-14 656 int ret; > ba9177fcef21fa Carl Huang 2022-03-14 657 > ba9177fcef21fa Carl Huang 2022-03-14 658 mutex_lock(&ar->conf_mutex); > ba9177fcef21fa Carl Huang 2022-03-14 659 > ba9177fcef21fa Carl Huang 2022-03-14 660 ret = ath11k_hif_resume(ar->ab); > ba9177fcef21fa Carl Huang 2022-03-14 661 if (ret) { > ba9177fcef21fa Carl Huang 2022-03-14 662 ath11k_warn(ar->ab, "failed > to resume hif: %d\n", ret); > ba9177fcef21fa Carl Huang 2022-03-14 663 goto exit; > ba9177fcef21fa Carl Huang 2022-03-14 664 } > ba9177fcef21fa Carl Huang 2022-03-14 665 > ba9177fcef21fa Carl Huang 2022-03-14 666 ath11k_hif_ce_irq_enable(ar->ab); > ba9177fcef21fa Carl Huang 2022-03-14 667 ath11k_hif_irq_enable(ar->ab); > ba9177fcef21fa Carl Huang 2022-03-14 668 > 90bf5c8d0f7ecd Carl Huang 2022-03-14 669 ret = ath11k_dp_rx_pktlog_start(ar->ab); > 90bf5c8d0f7ecd Carl Huang 2022-03-14 670 if (ret) { > 90bf5c8d0f7ecd Carl Huang 2022-03-14 671 ath11k_warn(ar->ab, "failed > to start rx pktlog from wow: %d\n", ret); > 90bf5c8d0f7ecd Carl Huang 2022-03-14 672 return ret; > > goto exit; Carl or Wen, are you able to send a fix for this? -- ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [linux-next:master 408/8237] drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex'. 2022-05-04 16:23 ` Kalle Valo @ 2022-05-05 1:29 ` Carl Huang -1 siblings, 0 replies; 24+ messages in thread From: Carl Huang @ 2022-05-05 1:29 UTC (permalink / raw) To: Kalle Valo, Dan Carpenter Cc: kbuild, lkp, kbuild-all, Linux Memory Management List, ath11k, Wen Gong [-- Attachment #1: Type: text/plain, Size: 2646 bytes --] Hi Kalle, Is the below the same fix that you have already applied to ath.git? [-next] ath11k: fix missing unlock on error in ath11k_wow_op_resume() - Patchwork (kernel.org) <https://patchwork.kernel.org/project/linux-wireless/patch/20220408030912.3087293-1-yangyingliang@huawei.com/> Thanks, Carl On 5/5/2022 12:23 AM, Kalle Valo wrote: > + ath11k, wen > > Dan Carpenter<dan.carpenter@oracle.com> writes: > >> tree:https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master >> head: 44a2f39e611ac0bc1f17c288a583d7f2e5684aa7 >> commit: 90bf5c8d0f7ecddf96fc1cd9434af4e157b51970 [408/8237] ath11k: >> purge rx pktlog when entering WoW >> config: i386-randconfig-m021-20220502 >> (https://download.01.org/0day-ci/archive/20220503/202205032236.kofEquX3-lkp@intel.com/config) >> compiler: gcc-11 (Debian 11.2.0-20) 11.2.0 >> >> If you fix the issue, kindly add following tag as appropriate >> Reported-by: kernel test robot<lkp@intel.com> >> Reported-by: Dan Carpenter<dan.carpenter@oracle.com> >> >> smatch warnings: >> drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: >> inconsistent returns '&ar->conf_mutex'. >> >> vim +712 drivers/net/wireless/ath/ath11k/wow.c >> >> ba9177fcef21fa Carl Huang 2022-03-14 653 int >> ath11k_wow_op_resume(struct ieee80211_hw *hw) >> ba9177fcef21fa Carl Huang 2022-03-14 654 { >> ba9177fcef21fa Carl Huang 2022-03-14 655 struct ath11k *ar = hw->priv; >> ba9177fcef21fa Carl Huang 2022-03-14 656 int ret; >> ba9177fcef21fa Carl Huang 2022-03-14 657 >> ba9177fcef21fa Carl Huang 2022-03-14 658 mutex_lock(&ar->conf_mutex); >> ba9177fcef21fa Carl Huang 2022-03-14 659 >> ba9177fcef21fa Carl Huang 2022-03-14 660 ret = ath11k_hif_resume(ar->ab); >> ba9177fcef21fa Carl Huang 2022-03-14 661 if (ret) { >> ba9177fcef21fa Carl Huang 2022-03-14 662 ath11k_warn(ar->ab, "failed >> to resume hif: %d\n", ret); >> ba9177fcef21fa Carl Huang 2022-03-14 663 goto exit; >> ba9177fcef21fa Carl Huang 2022-03-14 664 } >> ba9177fcef21fa Carl Huang 2022-03-14 665 >> ba9177fcef21fa Carl Huang 2022-03-14 666 ath11k_hif_ce_irq_enable(ar->ab); >> ba9177fcef21fa Carl Huang 2022-03-14 667 ath11k_hif_irq_enable(ar->ab); >> ba9177fcef21fa Carl Huang 2022-03-14 668 >> 90bf5c8d0f7ecd Carl Huang 2022-03-14 669 ret = ath11k_dp_rx_pktlog_start(ar->ab); >> 90bf5c8d0f7ecd Carl Huang 2022-03-14 670 if (ret) { >> 90bf5c8d0f7ecd Carl Huang 2022-03-14 671 ath11k_warn(ar->ab, "failed >> to start rx pktlog from wow: %d\n", ret); >> 90bf5c8d0f7ecd Carl Huang 2022-03-14 672 return ret; >> >> goto exit; > Carl or Wen, are you able to send a fix for this? [-- Attachment #2: Type: text/html, Size: 3604 bytes --] ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [linux-next:master 408/8237] drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex'. @ 2022-05-05 1:29 ` Carl Huang 0 siblings, 0 replies; 24+ messages in thread From: Carl Huang @ 2022-05-05 1:29 UTC (permalink / raw) To: kbuild-all [-- Attachment #1: Type: text/plain, Size: 2711 bytes --] Hi Kalle, Is the below the same fix that you have already applied to ath.git? [-next] ath11k: fix missing unlock on error in ath11k_wow_op_resume() - Patchwork (kernel.org) <https://patchwork.kernel.org/project/linux-wireless/patch/20220408030912.3087293-1-yangyingliang@huawei.com/> Thanks, Carl On 5/5/2022 12:23 AM, Kalle Valo wrote: > + ath11k, wen > > Dan Carpenter<dan.carpenter@oracle.com> writes: > >> tree:https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master >> head: 44a2f39e611ac0bc1f17c288a583d7f2e5684aa7 >> commit: 90bf5c8d0f7ecddf96fc1cd9434af4e157b51970 [408/8237] ath11k: >> purge rx pktlog when entering WoW >> config: i386-randconfig-m021-20220502 >> (https://download.01.org/0day-ci/archive/20220503/202205032236.kofEquX3-lkp(a)intel.com/config) >> compiler: gcc-11 (Debian 11.2.0-20) 11.2.0 >> >> If you fix the issue, kindly add following tag as appropriate >> Reported-by: kernel test robot<lkp@intel.com> >> Reported-by: Dan Carpenter<dan.carpenter@oracle.com> >> >> smatch warnings: >> drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: >> inconsistent returns '&ar->conf_mutex'. >> >> vim +712 drivers/net/wireless/ath/ath11k/wow.c >> >> ba9177fcef21fa Carl Huang 2022-03-14 653 int >> ath11k_wow_op_resume(struct ieee80211_hw *hw) >> ba9177fcef21fa Carl Huang 2022-03-14 654 { >> ba9177fcef21fa Carl Huang 2022-03-14 655 struct ath11k *ar = hw->priv; >> ba9177fcef21fa Carl Huang 2022-03-14 656 int ret; >> ba9177fcef21fa Carl Huang 2022-03-14 657 >> ba9177fcef21fa Carl Huang 2022-03-14 658 mutex_lock(&ar->conf_mutex); >> ba9177fcef21fa Carl Huang 2022-03-14 659 >> ba9177fcef21fa Carl Huang 2022-03-14 660 ret = ath11k_hif_resume(ar->ab); >> ba9177fcef21fa Carl Huang 2022-03-14 661 if (ret) { >> ba9177fcef21fa Carl Huang 2022-03-14 662 ath11k_warn(ar->ab, "failed >> to resume hif: %d\n", ret); >> ba9177fcef21fa Carl Huang 2022-03-14 663 goto exit; >> ba9177fcef21fa Carl Huang 2022-03-14 664 } >> ba9177fcef21fa Carl Huang 2022-03-14 665 >> ba9177fcef21fa Carl Huang 2022-03-14 666 ath11k_hif_ce_irq_enable(ar->ab); >> ba9177fcef21fa Carl Huang 2022-03-14 667 ath11k_hif_irq_enable(ar->ab); >> ba9177fcef21fa Carl Huang 2022-03-14 668 >> 90bf5c8d0f7ecd Carl Huang 2022-03-14 669 ret = ath11k_dp_rx_pktlog_start(ar->ab); >> 90bf5c8d0f7ecd Carl Huang 2022-03-14 670 if (ret) { >> 90bf5c8d0f7ecd Carl Huang 2022-03-14 671 ath11k_warn(ar->ab, "failed >> to start rx pktlog from wow: %d\n", ret); >> 90bf5c8d0f7ecd Carl Huang 2022-03-14 672 return ret; >> >> goto exit; > Carl or Wen, are you able to send a fix for this? [-- Attachment #2: attachment.htm --] [-- Type: text/html, Size: 3604 bytes --] ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [linux-next:master 408/8237] drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex'. 2022-05-05 1:29 ` Carl Huang (?) (?) @ 2022-05-05 5:58 ` Dan Carpenter -1 siblings, 0 replies; 24+ messages in thread From: Dan Carpenter @ 2022-05-05 5:58 UTC (permalink / raw) To: Carl Huang, lkp Cc: Kalle Valo, kbuild, kbuild-all, Linux Memory Management List, ath11k, Wen Gong On Thu, May 05, 2022 at 09:29:40AM +0800, Carl Huang wrote: > Hi Kalle, > > Is the below the same fix that you have already applied to ath.git? > > [-next] ath11k: fix missing unlock on error in ath11k_wow_op_resume() - > Patchwork (kernel.org) <https://patchwork.kernel.org/project/linux-wireless/patch/20220408030912.3087293-1-yangyingliang@huawei.com/ > > That looks good. It's sort of annoying for me to send a bug report a month after the fix has been applied... Sorry about that. 1) These are kbuild warnings. The zero day bot generates the warnings and I look them over and hit send. I don't know why the kbuild bot seems to get confused by -mm. The subject says 408/8237 which is pretty crazy. Maybe I should just ignore the -mm patches? 2) The blamed patch came from a git tree but it had a Link tag to lore.kernel.org so we could have used that as an In-Reply-to tag. In an ideal world, all the bug reports for a patch would go to a standard location. Link: https://lore.kernel.org/r/1644308006-22784-5-git-send-email-quic_cjhuang@quicinc.com 3) Another idea is that the kbuild bot could search lore for Fixes to the original commit and include links to those threads? regards, dan carpenter ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [linux-next:master 408/8237] drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex'. @ 2022-05-05 5:58 ` Dan Carpenter 0 siblings, 0 replies; 24+ messages in thread From: Dan Carpenter @ 2022-05-05 5:58 UTC (permalink / raw) To: kbuild-all [-- Attachment #1: Type: text/plain, Size: 1247 bytes --] On Thu, May 05, 2022 at 09:29:40AM +0800, Carl Huang wrote: > Hi Kalle, > > Is the below the same fix that you have already applied to ath.git? > > [-next] ath11k: fix missing unlock on error in ath11k_wow_op_resume() - > Patchwork (kernel.org) <https://patchwork.kernel.org/project/linux-wireless/patch/20220408030912.3087293-1-yangyingliang@huawei.com/ > > That looks good. It's sort of annoying for me to send a bug report a month after the fix has been applied... Sorry about that. 1) These are kbuild warnings. The zero day bot generates the warnings and I look them over and hit send. I don't know why the kbuild bot seems to get confused by -mm. The subject says 408/8237 which is pretty crazy. Maybe I should just ignore the -mm patches? 2) The blamed patch came from a git tree but it had a Link tag to lore.kernel.org so we could have used that as an In-Reply-to tag. In an ideal world, all the bug reports for a patch would go to a standard location. Link: https://lore.kernel.org/r/1644308006-22784-5-git-send-email-quic_cjhuang(a)quicinc.com 3) Another idea is that the kbuild bot could search lore for Fixes to the original commit and include links to those threads? regards, dan carpenter ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [linux-next:master 408/8237] drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex'. @ 2022-05-05 5:58 ` Dan Carpenter 0 siblings, 0 replies; 24+ messages in thread From: Dan Carpenter @ 2022-05-05 5:58 UTC (permalink / raw) To: kbuild [-- Attachment #1: Type: text/plain, Size: 1247 bytes --] On Thu, May 05, 2022 at 09:29:40AM +0800, Carl Huang wrote: > Hi Kalle, > > Is the below the same fix that you have already applied to ath.git? > > [-next] ath11k: fix missing unlock on error in ath11k_wow_op_resume() - > Patchwork (kernel.org) <https://patchwork.kernel.org/project/linux-wireless/patch/20220408030912.3087293-1-yangyingliang@huawei.com/ > > That looks good. It's sort of annoying for me to send a bug report a month after the fix has been applied... Sorry about that. 1) These are kbuild warnings. The zero day bot generates the warnings and I look them over and hit send. I don't know why the kbuild bot seems to get confused by -mm. The subject says 408/8237 which is pretty crazy. Maybe I should just ignore the -mm patches? 2) The blamed patch came from a git tree but it had a Link tag to lore.kernel.org so we could have used that as an In-Reply-to tag. In an ideal world, all the bug reports for a patch would go to a standard location. Link: https://lore.kernel.org/r/1644308006-22784-5-git-send-email-quic_cjhuang(a)quicinc.com 3) Another idea is that the kbuild bot could search lore for Fixes to the original commit and include links to those threads? regards, dan carpenter ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [linux-next:master 408/8237] drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex'. @ 2022-05-05 5:58 ` Dan Carpenter 0 siblings, 0 replies; 24+ messages in thread From: Dan Carpenter @ 2022-05-05 5:58 UTC (permalink / raw) To: Carl Huang, lkp Cc: Kalle Valo, kbuild, kbuild-all, Linux Memory Management List, ath11k, Wen Gong On Thu, May 05, 2022 at 09:29:40AM +0800, Carl Huang wrote: > Hi Kalle, > > Is the below the same fix that you have already applied to ath.git? > > [-next] ath11k: fix missing unlock on error in ath11k_wow_op_resume() - > Patchwork (kernel.org) <https://patchwork.kernel.org/project/linux-wireless/patch/20220408030912.3087293-1-yangyingliang@huawei.com/ > > That looks good. It's sort of annoying for me to send a bug report a month after the fix has been applied... Sorry about that. 1) These are kbuild warnings. The zero day bot generates the warnings and I look them over and hit send. I don't know why the kbuild bot seems to get confused by -mm. The subject says 408/8237 which is pretty crazy. Maybe I should just ignore the -mm patches? 2) The blamed patch came from a git tree but it had a Link tag to lore.kernel.org so we could have used that as an In-Reply-to tag. In an ideal world, all the bug reports for a patch would go to a standard location. Link: https://lore.kernel.org/r/1644308006-22784-5-git-send-email-quic_cjhuang@quicinc.com 3) Another idea is that the kbuild bot could search lore for Fixes to the original commit and include links to those threads? regards, dan carpenter -- ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [linux-next:master 408/8237] drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex'. 2022-05-05 5:58 ` Dan Carpenter (?) @ 2022-05-06 8:46 ` Kalle Valo -1 siblings, 0 replies; 24+ messages in thread From: Kalle Valo @ 2022-05-06 8:46 UTC (permalink / raw) To: Dan Carpenter Cc: Carl Huang, lkp, kbuild, kbuild-all, Linux Memory Management List, ath11k, Wen Gong Dan Carpenter <dan.carpenter@oracle.com> writes: > On Thu, May 05, 2022 at 09:29:40AM +0800, Carl Huang wrote: >> Hi Kalle, >> >> Is the below the same fix that you have already applied to ath.git? >> >> [-next] ath11k: fix missing unlock on error in ath11k_wow_op_resume() - >> Patchwork (kernel.org) >> <https://patchwork.kernel.org/project/linux-wireless/patch/20220408030912.3087293-1-yangyingliang@huawei.com/ >> > > > That looks good. It's sort of annoying for me to send a bug report a > month after the fix has been applied... Sorry about that. My ath.git tree is not included in linux-wireless builds so there's also a delay before linux-next sees the fix. > 1) These are kbuild warnings. The zero day bot generates the > warnings and I look them over and hit send. I don't know why the kbuild > bot seems to get confused by -mm. The subject says 408/8237 which is > pretty crazy. Maybe I should just ignore the -mm patches? Yeah, I have been also wondering about using -mm for ath11k reports. Does anyone know why that's happening? > 2) The blamed patch came from a git tree but it had a Link tag to > lore.kernel.org so we could have used that as an In-Reply-to tag. > In an ideal world, all the bug reports for a patch would go to a > standard location. > > Link: > https://lore.kernel.org/r/1644308006-22784-5-git-send-email-quic_cjhuang@quicinc.com Yeah, that would be nice. > 3) Another idea is that the kbuild bot could search lore for Fixes to > the original commit and include links to those threads? Yeah. Also searching for all references to the commit id from git log would be nice. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [linux-next:master 408/8237] drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex'. @ 2022-05-06 8:46 ` Kalle Valo 0 siblings, 0 replies; 24+ messages in thread From: Kalle Valo @ 2022-05-06 8:46 UTC (permalink / raw) To: kbuild-all [-- Attachment #1: Type: text/plain, Size: 1809 bytes --] Dan Carpenter <dan.carpenter@oracle.com> writes: > On Thu, May 05, 2022 at 09:29:40AM +0800, Carl Huang wrote: >> Hi Kalle, >> >> Is the below the same fix that you have already applied to ath.git? >> >> [-next] ath11k: fix missing unlock on error in ath11k_wow_op_resume() - >> Patchwork (kernel.org) >> <https://patchwork.kernel.org/project/linux-wireless/patch/20220408030912.3087293-1-yangyingliang@huawei.com/ >> > > > That looks good. It's sort of annoying for me to send a bug report a > month after the fix has been applied... Sorry about that. My ath.git tree is not included in linux-wireless builds so there's also a delay before linux-next sees the fix. > 1) These are kbuild warnings. The zero day bot generates the > warnings and I look them over and hit send. I don't know why the kbuild > bot seems to get confused by -mm. The subject says 408/8237 which is > pretty crazy. Maybe I should just ignore the -mm patches? Yeah, I have been also wondering about using -mm for ath11k reports. Does anyone know why that's happening? > 2) The blamed patch came from a git tree but it had a Link tag to > lore.kernel.org so we could have used that as an In-Reply-to tag. > In an ideal world, all the bug reports for a patch would go to a > standard location. > > Link: > https://lore.kernel.org/r/1644308006-22784-5-git-send-email-quic_cjhuang(a)quicinc.com Yeah, that would be nice. > 3) Another idea is that the kbuild bot could search lore for Fixes to > the original commit and include links to those threads? Yeah. Also searching for all references to the commit id from git log would be nice. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [linux-next:master 408/8237] drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex'. @ 2022-05-06 8:46 ` Kalle Valo 0 siblings, 0 replies; 24+ messages in thread From: Kalle Valo @ 2022-05-06 8:46 UTC (permalink / raw) To: Dan Carpenter Cc: Carl Huang, lkp, kbuild, kbuild-all, Linux Memory Management List, ath11k, Wen Gong Dan Carpenter <dan.carpenter@oracle.com> writes: > On Thu, May 05, 2022 at 09:29:40AM +0800, Carl Huang wrote: >> Hi Kalle, >> >> Is the below the same fix that you have already applied to ath.git? >> >> [-next] ath11k: fix missing unlock on error in ath11k_wow_op_resume() - >> Patchwork (kernel.org) >> <https://patchwork.kernel.org/project/linux-wireless/patch/20220408030912.3087293-1-yangyingliang@huawei.com/ >> > > > That looks good. It's sort of annoying for me to send a bug report a > month after the fix has been applied... Sorry about that. My ath.git tree is not included in linux-wireless builds so there's also a delay before linux-next sees the fix. > 1) These are kbuild warnings. The zero day bot generates the > warnings and I look them over and hit send. I don't know why the kbuild > bot seems to get confused by -mm. The subject says 408/8237 which is > pretty crazy. Maybe I should just ignore the -mm patches? Yeah, I have been also wondering about using -mm for ath11k reports. Does anyone know why that's happening? > 2) The blamed patch came from a git tree but it had a Link tag to > lore.kernel.org so we could have used that as an In-Reply-to tag. > In an ideal world, all the bug reports for a patch would go to a > standard location. > > Link: > https://lore.kernel.org/r/1644308006-22784-5-git-send-email-quic_cjhuang@quicinc.com Yeah, that would be nice. > 3) Another idea is that the kbuild bot could search lore for Fixes to > the original commit and include links to those threads? Yeah. Also searching for all references to the commit id from git log would be nice. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches -- ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [kbuild-all] Re: [linux-next:master 408/8237] drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex'. 2022-05-06 8:46 ` Kalle Valo @ 2022-05-06 9:58 ` Chen, Rong A -1 siblings, 0 replies; 24+ messages in thread From: Chen, Rong A @ 2022-05-06 9:58 UTC (permalink / raw) To: Kalle Valo, Dan Carpenter Cc: Carl Huang, lkp, kbuild, kbuild-all, Linux Memory Management List, ath11k, Wen Gong On 5/6/2022 4:46 PM, Kalle Valo wrote: > Dan Carpenter <dan.carpenter@oracle.com> writes: > >> On Thu, May 05, 2022 at 09:29:40AM +0800, Carl Huang wrote: >>> Hi Kalle, >>> >>> Is the below the same fix that you have already applied to ath.git? >>> >>> [-next] ath11k: fix missing unlock on error in ath11k_wow_op_resume() - >>> Patchwork (kernel.org) >>> <https://patchwork.kernel.org/project/linux-wireless/patch/20220408030912.3087293-1-yangyingliang@huawei.com/ >>>> >> >> That looks good. It's sort of annoying for me to send a bug report a >> month after the fix has been applied... Sorry about that. > > My ath.git tree is not included in linux-wireless builds so there's also > a delay before linux-next sees the fix. Hi, Sorry for the overdue report , we'll take a look to prevent the same problem arising again. > >> 1) These are kbuild warnings. The zero day bot generates the >> warnings and I look them over and hit send. I don't know why the kbuild >> bot seems to get confused by -mm. The subject says 408/8237 which is >> pretty crazy. Maybe I should just ignore the -mm patches? > > Yeah, I have been also wondering about using -mm for ath11k reports. > Does anyone know why that's happening? We don't have a filter to ignore some warnings from specific branches, we can create one to only report ath11k issues if found in ath.git, please remind me if there are other rules. > >> 2) The blamed patch came from a git tree but it had a Link tag to >> lore.kernel.org so we could have used that as an In-Reply-to tag. >> In an ideal world, all the bug reports for a patch would go to a >> standard location. >> >> Link: >> https://lore.kernel.org/r/1644308006-22784-5-git-send-email-quic_cjhuang@quicinc.com > > Yeah, that would be nice. We have already linked the bug reports to the patch if the patch hasn't been applied, I'm not sure is it possible to find the link of patch if it's already applied in a branch. > >> 3) Another idea is that the kbuild bot could search lore for Fixes to >> the original commit and include links to those threads? > > Yeah. Also searching for all references to the commit id from git log > would be nice. > Yes, It could avoid such false positive, we'll give it a try. Best Regards, Rong Chen ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [kbuild-all] Re: [linux-next:master 408/8237] drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex'. @ 2022-05-06 9:58 ` Chen, Rong A 0 siblings, 0 replies; 24+ messages in thread From: Chen, Rong A @ 2022-05-06 9:58 UTC (permalink / raw) To: Kalle Valo, Dan Carpenter Cc: Carl Huang, lkp, kbuild, kbuild-all, Linux Memory Management List, ath11k, Wen Gong On 5/6/2022 4:46 PM, Kalle Valo wrote: > Dan Carpenter <dan.carpenter@oracle.com> writes: > >> On Thu, May 05, 2022 at 09:29:40AM +0800, Carl Huang wrote: >>> Hi Kalle, >>> >>> Is the below the same fix that you have already applied to ath.git? >>> >>> [-next] ath11k: fix missing unlock on error in ath11k_wow_op_resume() - >>> Patchwork (kernel.org) >>> <https://patchwork.kernel.org/project/linux-wireless/patch/20220408030912.3087293-1-yangyingliang@huawei.com/ >>>> >> >> That looks good. It's sort of annoying for me to send a bug report a >> month after the fix has been applied... Sorry about that. > > My ath.git tree is not included in linux-wireless builds so there's also > a delay before linux-next sees the fix. Hi, Sorry for the overdue report , we'll take a look to prevent the same problem arising again. > >> 1) These are kbuild warnings. The zero day bot generates the >> warnings and I look them over and hit send. I don't know why the kbuild >> bot seems to get confused by -mm. The subject says 408/8237 which is >> pretty crazy. Maybe I should just ignore the -mm patches? > > Yeah, I have been also wondering about using -mm for ath11k reports. > Does anyone know why that's happening? We don't have a filter to ignore some warnings from specific branches, we can create one to only report ath11k issues if found in ath.git, please remind me if there are other rules. > >> 2) The blamed patch came from a git tree but it had a Link tag to >> lore.kernel.org so we could have used that as an In-Reply-to tag. >> In an ideal world, all the bug reports for a patch would go to a >> standard location. >> >> Link: >> https://lore.kernel.org/r/1644308006-22784-5-git-send-email-quic_cjhuang@quicinc.com > > Yeah, that would be nice. We have already linked the bug reports to the patch if the patch hasn't been applied, I'm not sure is it possible to find the link of patch if it's already applied in a branch. > >> 3) Another idea is that the kbuild bot could search lore for Fixes to >> the original commit and include links to those threads? > > Yeah. Also searching for all references to the commit id from git log > would be nice. > Yes, It could avoid such false positive, we'll give it a try. Best Regards, Rong Chen -- ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [kbuild-all] Re: [linux-next:master 408/8237] drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex'. 2022-05-06 9:58 ` Chen, Rong A (?) (?) @ 2022-05-06 10:24 ` Dan Carpenter -1 siblings, 0 replies; 24+ messages in thread From: Dan Carpenter @ 2022-05-06 10:24 UTC (permalink / raw) To: Chen, Rong A Cc: Kalle Valo, Carl Huang, lkp, kbuild, kbuild-all, Linux Memory Management List, ath11k, Wen Gong On Fri, May 06, 2022 at 05:58:22PM +0800, Chen, Rong A wrote: > > > On 5/6/2022 4:46 PM, Kalle Valo wrote: > > Dan Carpenter <dan.carpenter@oracle.com> writes: > > > > > On Thu, May 05, 2022 at 09:29:40AM +0800, Carl Huang wrote: > > > > Hi Kalle, > > > > > > > > Is the below the same fix that you have already applied to ath.git? > > > > > > > > [-next] ath11k: fix missing unlock on error in ath11k_wow_op_resume() - > > > > Patchwork (kernel.org) > > > > <https://patchwork.kernel.org/project/linux-wireless/patch/20220408030912.3087293-1-yangyingliang@huawei.com/ > > > > > > > > > > > That looks good. It's sort of annoying for me to send a bug report a > > > month after the fix has been applied... Sorry about that. > > > > My ath.git tree is not included in linux-wireless builds so there's also > > a delay before linux-next sees the fix. > > Hi, > > Sorry for the overdue report , we'll take a look to prevent the same > problem arising again. > > > > > > 1) These are kbuild warnings. The zero day bot generates the > > > warnings and I look them over and hit send. I don't know why the kbuild > > > bot seems to get confused by -mm. The subject says 408/8237 which is > > > pretty crazy. Maybe I should just ignore the -mm patches? > > > > Yeah, I have been also wondering about using -mm for ath11k reports. > > Does anyone know why that's happening? > > We don't have a filter to ignore some warnings from specific branches, > we can create one to only report ath11k issues if found in ath.git, > please remind me if there are other rules. > The problem is really specific to the -mm tree. They always have look like they're a part of a 1000+ series of patches. There was another one today: [kbuild] [linux-next:master 5904/9357] kernel/bpf/verifier.c:5331 process_kptr_func() warn: passing zero to 'PTR_ERR' That warning is a false positive but a high quality false positive. A lot of the "passing valid pointers" to PTR_ERR() bugs are caused because Smatch thinks some arches have signed pointers. I'm not sure what's up with that... :/ My bad. Those are on me. > > > > > 2) The blamed patch came from a git tree but it had a Link tag to > > > lore.kernel.org so we could have used that as an In-Reply-to tag. > > > In an ideal world, all the bug reports for a patch would go to a > > > standard location. > > > > > > Link: > > > https://lore.kernel.org/r/1644308006-22784-5-git-send-email-quic_cjhuang@quicinc.com > > > > Yeah, that would be nice. > > We have already linked the bug reports to the patch if the patch hasn't > been applied, I'm not sure is it possible to find the link of patch if > it's already applied in a branch. You could git do: git show 90bf5c8d0f7ecddf96fc1cd9434af4e157b51970 | grep "Link: https://lore.kernel.org/r/" Some of the links are to freedesktop which also has the msgid. Link: https://patchwork.freedesktop.org/patch/msgid/20220504090229.2506560-1-l.stach@pengutronix.de We're really trying to discourage links to other websites because it's not under our control and it will break. And you wouldn't have the CC list either... But I still think it's useful. regards, dan carpenter ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [linux-next:master 408/8237] drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex'. @ 2022-05-06 10:24 ` Dan Carpenter 0 siblings, 0 replies; 24+ messages in thread From: Dan Carpenter @ 2022-05-06 10:24 UTC (permalink / raw) To: kbuild-all [-- Attachment #1: Type: text/plain, Size: 3264 bytes --] On Fri, May 06, 2022 at 05:58:22PM +0800, Chen, Rong A wrote: > > > On 5/6/2022 4:46 PM, Kalle Valo wrote: > > Dan Carpenter <dan.carpenter@oracle.com> writes: > > > > > On Thu, May 05, 2022 at 09:29:40AM +0800, Carl Huang wrote: > > > > Hi Kalle, > > > > > > > > Is the below the same fix that you have already applied to ath.git? > > > > > > > > [-next] ath11k: fix missing unlock on error in ath11k_wow_op_resume() - > > > > Patchwork (kernel.org) > > > > <https://patchwork.kernel.org/project/linux-wireless/patch/20220408030912.3087293-1-yangyingliang@huawei.com/ > > > > > > > > > > > That looks good. It's sort of annoying for me to send a bug report a > > > month after the fix has been applied... Sorry about that. > > > > My ath.git tree is not included in linux-wireless builds so there's also > > a delay before linux-next sees the fix. > > Hi, > > Sorry for the overdue report , we'll take a look to prevent the same > problem arising again. > > > > > > 1) These are kbuild warnings. The zero day bot generates the > > > warnings and I look them over and hit send. I don't know why the kbuild > > > bot seems to get confused by -mm. The subject says 408/8237 which is > > > pretty crazy. Maybe I should just ignore the -mm patches? > > > > Yeah, I have been also wondering about using -mm for ath11k reports. > > Does anyone know why that's happening? > > We don't have a filter to ignore some warnings from specific branches, > we can create one to only report ath11k issues if found in ath.git, > please remind me if there are other rules. > The problem is really specific to the -mm tree. They always have look like they're a part of a 1000+ series of patches. There was another one today: [kbuild] [linux-next:master 5904/9357] kernel/bpf/verifier.c:5331 process_kptr_func() warn: passing zero to 'PTR_ERR' That warning is a false positive but a high quality false positive. A lot of the "passing valid pointers" to PTR_ERR() bugs are caused because Smatch thinks some arches have signed pointers. I'm not sure what's up with that... :/ My bad. Those are on me. > > > > > 2) The blamed patch came from a git tree but it had a Link tag to > > > lore.kernel.org so we could have used that as an In-Reply-to tag. > > > In an ideal world, all the bug reports for a patch would go to a > > > standard location. > > > > > > Link: > > > https://lore.kernel.org/r/1644308006-22784-5-git-send-email-quic_cjhuang(a)quicinc.com > > > > Yeah, that would be nice. > > We have already linked the bug reports to the patch if the patch hasn't > been applied, I'm not sure is it possible to find the link of patch if > it's already applied in a branch. You could git do: git show 90bf5c8d0f7ecddf96fc1cd9434af4e157b51970 | grep "Link: https://lore.kernel.org/r/" Some of the links are to freedesktop which also has the msgid. Link: https://patchwork.freedesktop.org/patch/msgid/20220504090229.2506560-1-l.stach(a)pengutronix.de We're really trying to discourage links to other websites because it's not under our control and it will break. And you wouldn't have the CC list either... But I still think it's useful. regards, dan carpenter ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [kbuild-all] Re: [linux-next:master 408/8237] drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex'. @ 2022-05-06 10:24 ` Dan Carpenter 0 siblings, 0 replies; 24+ messages in thread From: Dan Carpenter @ 2022-05-06 10:24 UTC (permalink / raw) To: kbuild [-- Attachment #1: Type: text/plain, Size: 3264 bytes --] On Fri, May 06, 2022 at 05:58:22PM +0800, Chen, Rong A wrote: > > > On 5/6/2022 4:46 PM, Kalle Valo wrote: > > Dan Carpenter <dan.carpenter@oracle.com> writes: > > > > > On Thu, May 05, 2022 at 09:29:40AM +0800, Carl Huang wrote: > > > > Hi Kalle, > > > > > > > > Is the below the same fix that you have already applied to ath.git? > > > > > > > > [-next] ath11k: fix missing unlock on error in ath11k_wow_op_resume() - > > > > Patchwork (kernel.org) > > > > <https://patchwork.kernel.org/project/linux-wireless/patch/20220408030912.3087293-1-yangyingliang@huawei.com/ > > > > > > > > > > > That looks good. It's sort of annoying for me to send a bug report a > > > month after the fix has been applied... Sorry about that. > > > > My ath.git tree is not included in linux-wireless builds so there's also > > a delay before linux-next sees the fix. > > Hi, > > Sorry for the overdue report , we'll take a look to prevent the same > problem arising again. > > > > > > 1) These are kbuild warnings. The zero day bot generates the > > > warnings and I look them over and hit send. I don't know why the kbuild > > > bot seems to get confused by -mm. The subject says 408/8237 which is > > > pretty crazy. Maybe I should just ignore the -mm patches? > > > > Yeah, I have been also wondering about using -mm for ath11k reports. > > Does anyone know why that's happening? > > We don't have a filter to ignore some warnings from specific branches, > we can create one to only report ath11k issues if found in ath.git, > please remind me if there are other rules. > The problem is really specific to the -mm tree. They always have look like they're a part of a 1000+ series of patches. There was another one today: [kbuild] [linux-next:master 5904/9357] kernel/bpf/verifier.c:5331 process_kptr_func() warn: passing zero to 'PTR_ERR' That warning is a false positive but a high quality false positive. A lot of the "passing valid pointers" to PTR_ERR() bugs are caused because Smatch thinks some arches have signed pointers. I'm not sure what's up with that... :/ My bad. Those are on me. > > > > > 2) The blamed patch came from a git tree but it had a Link tag to > > > lore.kernel.org so we could have used that as an In-Reply-to tag. > > > In an ideal world, all the bug reports for a patch would go to a > > > standard location. > > > > > > Link: > > > https://lore.kernel.org/r/1644308006-22784-5-git-send-email-quic_cjhuang(a)quicinc.com > > > > Yeah, that would be nice. > > We have already linked the bug reports to the patch if the patch hasn't > been applied, I'm not sure is it possible to find the link of patch if > it's already applied in a branch. You could git do: git show 90bf5c8d0f7ecddf96fc1cd9434af4e157b51970 | grep "Link: https://lore.kernel.org/r/" Some of the links are to freedesktop which also has the msgid. Link: https://patchwork.freedesktop.org/patch/msgid/20220504090229.2506560-1-l.stach(a)pengutronix.de We're really trying to discourage links to other websites because it's not under our control and it will break. And you wouldn't have the CC list either... But I still think it's useful. regards, dan carpenter ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [kbuild-all] Re: [linux-next:master 408/8237] drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex'. @ 2022-05-06 10:24 ` Dan Carpenter 0 siblings, 0 replies; 24+ messages in thread From: Dan Carpenter @ 2022-05-06 10:24 UTC (permalink / raw) To: Chen, Rong A Cc: Kalle Valo, Carl Huang, lkp, kbuild, kbuild-all, Linux Memory Management List, ath11k, Wen Gong On Fri, May 06, 2022 at 05:58:22PM +0800, Chen, Rong A wrote: > > > On 5/6/2022 4:46 PM, Kalle Valo wrote: > > Dan Carpenter <dan.carpenter@oracle.com> writes: > > > > > On Thu, May 05, 2022 at 09:29:40AM +0800, Carl Huang wrote: > > > > Hi Kalle, > > > > > > > > Is the below the same fix that you have already applied to ath.git? > > > > > > > > [-next] ath11k: fix missing unlock on error in ath11k_wow_op_resume() - > > > > Patchwork (kernel.org) > > > > <https://patchwork.kernel.org/project/linux-wireless/patch/20220408030912.3087293-1-yangyingliang@huawei.com/ > > > > > > > > > > > That looks good. It's sort of annoying for me to send a bug report a > > > month after the fix has been applied... Sorry about that. > > > > My ath.git tree is not included in linux-wireless builds so there's also > > a delay before linux-next sees the fix. > > Hi, > > Sorry for the overdue report , we'll take a look to prevent the same > problem arising again. > > > > > > 1) These are kbuild warnings. The zero day bot generates the > > > warnings and I look them over and hit send. I don't know why the kbuild > > > bot seems to get confused by -mm. The subject says 408/8237 which is > > > pretty crazy. Maybe I should just ignore the -mm patches? > > > > Yeah, I have been also wondering about using -mm for ath11k reports. > > Does anyone know why that's happening? > > We don't have a filter to ignore some warnings from specific branches, > we can create one to only report ath11k issues if found in ath.git, > please remind me if there are other rules. > The problem is really specific to the -mm tree. They always have look like they're a part of a 1000+ series of patches. There was another one today: [kbuild] [linux-next:master 5904/9357] kernel/bpf/verifier.c:5331 process_kptr_func() warn: passing zero to 'PTR_ERR' That warning is a false positive but a high quality false positive. A lot of the "passing valid pointers" to PTR_ERR() bugs are caused because Smatch thinks some arches have signed pointers. I'm not sure what's up with that... :/ My bad. Those are on me. > > > > > 2) The blamed patch came from a git tree but it had a Link tag to > > > lore.kernel.org so we could have used that as an In-Reply-to tag. > > > In an ideal world, all the bug reports for a patch would go to a > > > standard location. > > > > > > Link: > > > https://lore.kernel.org/r/1644308006-22784-5-git-send-email-quic_cjhuang@quicinc.com > > > > Yeah, that would be nice. > > We have already linked the bug reports to the patch if the patch hasn't > been applied, I'm not sure is it possible to find the link of patch if > it's already applied in a branch. You could git do: git show 90bf5c8d0f7ecddf96fc1cd9434af4e157b51970 | grep "Link: https://lore.kernel.org/r/" Some of the links are to freedesktop which also has the msgid. Link: https://patchwork.freedesktop.org/patch/msgid/20220504090229.2506560-1-l.stach@pengutronix.de We're really trying to discourage links to other websites because it's not under our control and it will break. And you wouldn't have the CC list either... But I still think it's useful. regards, dan carpenter -- ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [linux-next:master 408/8237] drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex'. 2022-05-05 1:29 ` Carl Huang (?) @ 2022-05-06 13:25 ` Kalle Valo -1 siblings, 0 replies; 24+ messages in thread From: Kalle Valo @ 2022-05-06 13:25 UTC (permalink / raw) To: Carl Huang Cc: Dan Carpenter, kbuild, lkp, kbuild-all, Linux Memory Management List, ath11k, Wen Gong Carl Huang <quic_cjhuang@quicinc.com> writes: > Hi Kalle, > > Is the below the same fix that you have already applied to ath.git? > > [-next] ath11k: fix missing unlock on error in ath11k_wow_op_resume() - Patchwork (kernel.org) BT please don't use HTML in emails, linux lists drop HTML email. ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [linux-next:master 408/8237] drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex'. @ 2022-05-06 13:25 ` Kalle Valo 0 siblings, 0 replies; 24+ messages in thread From: Kalle Valo @ 2022-05-06 13:25 UTC (permalink / raw) To: kbuild-all [-- Attachment #1: Type: text/plain, Size: 303 bytes --] Carl Huang <quic_cjhuang@quicinc.com> writes: > Hi Kalle, > > Is the below the same fix that you have already applied to ath.git? > > [-next] ath11k: fix missing unlock on error in ath11k_wow_op_resume() - Patchwork (kernel.org) BT please don't use HTML in emails, linux lists drop HTML email. ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [linux-next:master 408/8237] drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex'. @ 2022-05-06 13:25 ` Kalle Valo 0 siblings, 0 replies; 24+ messages in thread From: Kalle Valo @ 2022-05-06 13:25 UTC (permalink / raw) To: Carl Huang Cc: Dan Carpenter, kbuild, lkp, kbuild-all, Linux Memory Management List, ath11k, Wen Gong Carl Huang <quic_cjhuang@quicinc.com> writes: > Hi Kalle, > > Is the below the same fix that you have already applied to ath.git? > > [-next] ath11k: fix missing unlock on error in ath11k_wow_op_resume() - Patchwork (kernel.org) BT please don't use HTML in emails, linux lists drop HTML email. -- ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k ^ permalink raw reply [flat|nested] 24+ messages in thread
end of thread, other threads:[~2022-05-06 13:30 UTC | newest] Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-05-03 14:36 [linux-next:master 408/8237] drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex' kernel test robot 2022-05-04 8:46 ` Dan Carpenter 2022-05-04 8:46 ` Dan Carpenter 2022-05-04 16:23 ` Kalle Valo 2022-05-04 16:23 ` Kalle Valo 2022-05-04 16:23 ` Kalle Valo 2022-05-05 1:29 ` Carl Huang 2022-05-05 1:29 ` Carl Huang 2022-05-05 5:58 ` Dan Carpenter 2022-05-05 5:58 ` Dan Carpenter 2022-05-05 5:58 ` Dan Carpenter 2022-05-05 5:58 ` Dan Carpenter 2022-05-06 8:46 ` Kalle Valo 2022-05-06 8:46 ` Kalle Valo 2022-05-06 8:46 ` Kalle Valo 2022-05-06 9:58 ` [kbuild-all] " Chen, Rong A 2022-05-06 9:58 ` Chen, Rong A 2022-05-06 10:24 ` Dan Carpenter 2022-05-06 10:24 ` Dan Carpenter 2022-05-06 10:24 ` [kbuild-all] " Dan Carpenter 2022-05-06 10:24 ` Dan Carpenter 2022-05-06 13:25 ` Kalle Valo 2022-05-06 13:25 ` Kalle Valo 2022-05-06 13:25 ` Kalle Valo
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.