From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F8B8C433F5 for ; Thu, 5 May 2022 06:41:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237870AbiEEGpW (ORCPT ); Thu, 5 May 2022 02:45:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233799AbiEEGpV (ORCPT ); Thu, 5 May 2022 02:45:21 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC6BC4704B for ; Wed, 4 May 2022 23:41:42 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmVBA-0005Pp-0K; Thu, 05 May 2022 08:41:36 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nmVB5-0004zN-Cf; Thu, 05 May 2022 08:41:31 +0200 Date: Thu, 5 May 2022 08:41:31 +0200 From: Sascha Hauer To: Heiko =?iso-8859-15?Q?St=FCbner?= Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Andy Yan , Benjamin Gaignard , Michael Riesch , Sandy Huang , Peter Geis , Rob Herring Subject: Re: [PATCH v11 16/24] arm64: dts: rockchip: rk356x: Add VOP2 nodes Message-ID: <20220505064131.GF4012@pengutronix.de> References: <20220422072841.2206452-1-s.hauer@pengutronix.de> <20220422072841.2206452-17-s.hauer@pengutronix.de> <1911394.usQuhbGJ8B@diego> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1911394.usQuhbGJ8B@diego> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 08:39:55 up 35 days, 19:09, 74 users, load average: 0.09, 0.10, 0.10 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, May 05, 2022 at 02:28:24AM +0200, Heiko Stübner wrote: > Am Freitag, 22. April 2022, 09:28:33 CEST schrieb Sascha Hauer: > > The VOP2 is the display output controller on the RK3568. Add the node > > for it to the dtsi file along with the required display-subsystem node > > and the iommu node. > > > > Signed-off-by: Sascha Hauer > > Acked-by: Rob Herring > > --- > > + vop: vop@fe040000 { > > + reg = <0x0 0xfe040000 0x0 0x3000>, <0x0 0xfe044000 0x0 0x1000>; > > + reg-names = "regs", "gamma_lut"; > > reg-names does not seem to be part of the dt-binding. > Though now in the vop2-driver I see that the code uses that naming. > > I guess we might want to just go the vop1-way by using numbered > platform-resources via a follow-up patch and drop the regnames here? Or we could document the reg-names properties in a follow-up patch. Wouldn't that be better? Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA276C433F5 for ; Thu, 5 May 2022 06:41:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/Rn+50fBVzE5z0lNnvacDsyNbr+4qsQUribIGMyllEc=; b=sngEgKpljFh38E 8e1s5nUP/pQOj5rcKOU0Gh26/zNpJmY4W5m2etwTeVZy7rZW2FunlD7wfdA3ky7OH/VWtxiUReuEW M6w2S9/fLzfax70nDzjY6A06HeoLm9R2OUku3BUwlHn4PnLhZYKlFOkpdQiPmAq9vHIp94ATPeCEL 84Z/A7IM5tVbwTr5jW4GhlMEZtiXuIT6fchWQ7Wvit/40IfFlepMrtyXBxsERhDQXI9Lyvi8DaDLt 6JTHGq/KfyIpzy7zDYaUsb+7VEXcvUUU94UPccIdEJ09fLz/eI+7aRAU4tYRMWzRkyVOxJfGHZ2dT k/iRGbuP8Skp8XDQE67w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmVBG-00EFoW-9G; Thu, 05 May 2022 06:41:42 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmVBD-00EFnR-N7 for linux-rockchip@lists.infradead.org; Thu, 05 May 2022 06:41:41 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmVBA-0005Pp-0K; Thu, 05 May 2022 08:41:36 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nmVB5-0004zN-Cf; Thu, 05 May 2022 08:41:31 +0200 Date: Thu, 5 May 2022 08:41:31 +0200 From: Sascha Hauer To: Heiko =?iso-8859-15?Q?St=FCbner?= Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Andy Yan , Benjamin Gaignard , Michael Riesch , Sandy Huang , Peter Geis , Rob Herring Subject: Re: [PATCH v11 16/24] arm64: dts: rockchip: rk356x: Add VOP2 nodes Message-ID: <20220505064131.GF4012@pengutronix.de> References: <20220422072841.2206452-1-s.hauer@pengutronix.de> <20220422072841.2206452-17-s.hauer@pengutronix.de> <1911394.usQuhbGJ8B@diego> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1911394.usQuhbGJ8B@diego> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 08:39:55 up 35 days, 19:09, 74 users, load average: 0.09, 0.10, 0.10 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-rockchip@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220504_234139_815806_94A37A24 X-CRM114-Status: GOOD ( 22.96 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Thu, May 05, 2022 at 02:28:24AM +0200, Heiko St=FCbner wrote: > Am Freitag, 22. April 2022, 09:28:33 CEST schrieb Sascha Hauer: > > The VOP2 is the display output controller on the RK3568. Add the node > > for it to the dtsi file along with the required display-subsystem node > > and the iommu node. > > = > > Signed-off-by: Sascha Hauer > > Acked-by: Rob Herring > > --- > > + vop: vop@fe040000 { > > + reg =3D <0x0 0xfe040000 0x0 0x3000>, <0x0 0xfe044000 0x0 0x1000>; > > + reg-names =3D "regs", "gamma_lut"; > = > reg-names does not seem to be part of the dt-binding. > Though now in the vop2-driver I see that the code uses that naming. > = > I guess we might want to just go the vop1-way by using numbered > platform-resources via a follow-up patch and drop the regnames here? Or we could document the reg-names properties in a follow-up patch. Wouldn't that be better? Sascha -- = Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 75172C433EF for ; Thu, 5 May 2022 06:41:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 93F7910FBFE; Thu, 5 May 2022 06:41:39 +0000 (UTC) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1B03A10FBFE for ; Thu, 5 May 2022 06:41:38 +0000 (UTC) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmVBA-0005Pp-0K; Thu, 05 May 2022 08:41:36 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nmVB5-0004zN-Cf; Thu, 05 May 2022 08:41:31 +0200 Date: Thu, 5 May 2022 08:41:31 +0200 From: Sascha Hauer To: Heiko =?iso-8859-15?Q?St=FCbner?= Subject: Re: [PATCH v11 16/24] arm64: dts: rockchip: rk356x: Add VOP2 nodes Message-ID: <20220505064131.GF4012@pengutronix.de> References: <20220422072841.2206452-1-s.hauer@pengutronix.de> <20220422072841.2206452-17-s.hauer@pengutronix.de> <1911394.usQuhbGJ8B@diego> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1911394.usQuhbGJ8B@diego> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 08:39:55 up 35 days, 19:09, 74 users, load average: 0.09, 0.10, 0.10 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Benjamin Gaignard , Peter Geis , Sandy Huang , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Michael Riesch , kernel@pengutronix.de, Andy Yan , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, May 05, 2022 at 02:28:24AM +0200, Heiko Stübner wrote: > Am Freitag, 22. April 2022, 09:28:33 CEST schrieb Sascha Hauer: > > The VOP2 is the display output controller on the RK3568. Add the node > > for it to the dtsi file along with the required display-subsystem node > > and the iommu node. > > > > Signed-off-by: Sascha Hauer > > Acked-by: Rob Herring > > --- > > + vop: vop@fe040000 { > > + reg = <0x0 0xfe040000 0x0 0x3000>, <0x0 0xfe044000 0x0 0x1000>; > > + reg-names = "regs", "gamma_lut"; > > reg-names does not seem to be part of the dt-binding. > Though now in the vop2-driver I see that the code uses that naming. > > I guess we might want to just go the vop1-way by using numbered > platform-resources via a follow-up patch and drop the regnames here? Or we could document the reg-names properties in a follow-up patch. Wouldn't that be better? Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14423C433EF for ; Thu, 5 May 2022 06:42:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GQERfezkptiIAHPAg3RqWU6WChf8bY/qNyR6tv5Zpu4=; b=prKrsl4fMuXf5S mJRi9QrxG6eMfgPN0XbQJIc79QAnB7joa1m1junCPwqK+F1u2blPCrFaLdVV/DhPz1aIQg+AvFqU9 uLp43o6voQo8pJWkRvaBG82/Ovtycpw87bKlstvbwcF5ix3P5oGL7FbO6dZflKi6V1V34tIu4L1pb j+VApbmYqINLj0fPenqDhCbUj/RfQsX/MHY/vriXwFPqcDCWVAQxAWh19DB1TB+VirhoTnyuGRABk tN6cBbUdG3cwQF4DeQ5iQYemx9aZGK+PrX/J1eKKsQrZgdcaUpA3OdmcHQF/FfZ/iXYZOloyletJF +8UCYOAznExxd43AGRSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmVBH-00EFon-69; Thu, 05 May 2022 06:41:43 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmVBD-00EFnB-N6 for linux-arm-kernel@lists.infradead.org; Thu, 05 May 2022 06:41:41 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmVBA-0005Pp-0K; Thu, 05 May 2022 08:41:36 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nmVB5-0004zN-Cf; Thu, 05 May 2022 08:41:31 +0200 Date: Thu, 5 May 2022 08:41:31 +0200 From: Sascha Hauer To: Heiko =?iso-8859-15?Q?St=FCbner?= Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Andy Yan , Benjamin Gaignard , Michael Riesch , Sandy Huang , Peter Geis , Rob Herring Subject: Re: [PATCH v11 16/24] arm64: dts: rockchip: rk356x: Add VOP2 nodes Message-ID: <20220505064131.GF4012@pengutronix.de> References: <20220422072841.2206452-1-s.hauer@pengutronix.de> <20220422072841.2206452-17-s.hauer@pengutronix.de> <1911394.usQuhbGJ8B@diego> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1911394.usQuhbGJ8B@diego> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 08:39:55 up 35 days, 19:09, 74 users, load average: 0.09, 0.10, 0.10 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220504_234139_815979_80D3C3A7 X-CRM114-Status: GOOD ( 23.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 05, 2022 at 02:28:24AM +0200, Heiko St=FCbner wrote: > Am Freitag, 22. April 2022, 09:28:33 CEST schrieb Sascha Hauer: > > The VOP2 is the display output controller on the RK3568. Add the node > > for it to the dtsi file along with the required display-subsystem node > > and the iommu node. > > = > > Signed-off-by: Sascha Hauer > > Acked-by: Rob Herring > > --- > > + vop: vop@fe040000 { > > + reg =3D <0x0 0xfe040000 0x0 0x3000>, <0x0 0xfe044000 0x0 0x1000>; > > + reg-names =3D "regs", "gamma_lut"; > = > reg-names does not seem to be part of the dt-binding. > Though now in the vop2-driver I see that the code uses that naming. > = > I guess we might want to just go the vop1-way by using numbered > platform-resources via a follow-up patch and drop the regnames here? Or we could document the reg-names properties in a follow-up patch. Wouldn't that be better? Sascha -- = Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel