From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5870C433EF for ; Thu, 5 May 2022 07:50:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346025AbiEEHyI (ORCPT ); Thu, 5 May 2022 03:54:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243146AbiEEHyH (ORCPT ); Thu, 5 May 2022 03:54:07 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3A61205CF for ; Thu, 5 May 2022 00:50:27 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmWFe-0005Nb-AM; Thu, 05 May 2022 09:50:18 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nmWFd-0000oa-KA; Thu, 05 May 2022 09:50:17 +0200 Date: Thu, 5 May 2022 09:50:17 +0200 From: Sascha Hauer To: Shengjiu Wang Cc: nicoleotsuka@gmail.com, Xiubo.Lee@gmail.com, festevam@gmail.com, shengjiu.wang@gmail.com, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: fsl_micfil: fix the naming style for mask definition Message-ID: <20220505075017.GJ4012@pengutronix.de> References: <1651736047-28809-1-git-send-email-shengjiu.wang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1651736047-28809-1-git-send-email-shengjiu.wang@nxp.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 09:49:44 up 35 days, 20:19, 82 users, load average: 0.27, 0.17, 0.11 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 05, 2022 at 03:34:07PM +0800, Shengjiu Wang wrote: > Remove the _SHIFT for the mask definition. > > Fixes: 17f2142bae4b ("ASoC: fsl_micfil: use GENMASK to define register bit fields") > Signed-off-by: Shengjiu Wang > --- Acked-by: Sascha Hauer Sascha > sound/soc/fsl/fsl_micfil.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/sound/soc/fsl/fsl_micfil.h b/sound/soc/fsl/fsl_micfil.h > index 08901827047d..053caba3caf3 100644 > --- a/sound/soc/fsl/fsl_micfil.h > +++ b/sound/soc/fsl/fsl_micfil.h > @@ -74,9 +74,9 @@ > #define MICFIL_FIFO_STAT_FIFOX_UNDER(ch) BIT((ch) + 8) > > /* MICFIL HWVAD0 Control 1 Register -- REG_MICFIL_VAD0_CTRL1*/ > -#define MICFIL_VAD0_CTRL1_CHSEL_SHIFT GENMASK(26, 24) > -#define MICFIL_VAD0_CTRL1_CICOSR_SHIFT GENMASK(19, 16) > -#define MICFIL_VAD0_CTRL1_INITT_SHIFT GENMASK(12, 8) > +#define MICFIL_VAD0_CTRL1_CHSEL GENMASK(26, 24) > +#define MICFIL_VAD0_CTRL1_CICOSR GENMASK(19, 16) > +#define MICFIL_VAD0_CTRL1_INITT GENMASK(12, 8) > #define MICFIL_VAD0_CTRL1_ST10 BIT(4) > #define MICFIL_VAD0_CTRL1_ERIE BIT(3) > #define MICFIL_VAD0_CTRL1_IE BIT(2) > @@ -106,7 +106,7 @@ > > /* MICFIL HWVAD0 Zero-Crossing Detector - REG_MICFIL_VAD0_ZCD */ > #define MICFIL_VAD0_ZCD_ZCDTH GENMASK(25, 16) > -#define MICFIL_VAD0_ZCD_ZCDADJ_SHIFT GENMASK(11, 8) > +#define MICFIL_VAD0_ZCD_ZCDADJ GENMASK(11, 8) > #define MICFIL_VAD0_ZCD_ZCDAND BIT(4) > #define MICFIL_VAD0_ZCD_ZCDAUT BIT(2) > #define MICFIL_VAD0_ZCD_ZCDEN BIT(0) > -- > 2.17.1 > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E96DEC433F5 for ; Thu, 5 May 2022 07:51:02 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Kv5VF3dJjz3c8T for ; Thu, 5 May 2022 17:51:01 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=pengutronix.de (client-ip=2001:67c:670:201:290:27ff:fe1d:cc33; helo=metis.ext.pengutronix.de; envelope-from=sha@pengutronix.de; receiver=) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Kv5Tl2VsCz2xnM for ; Thu, 5 May 2022 17:50:33 +1000 (AEST) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmWFe-0005Nb-AM; Thu, 05 May 2022 09:50:18 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nmWFd-0000oa-KA; Thu, 05 May 2022 09:50:17 +0200 Date: Thu, 5 May 2022 09:50:17 +0200 From: Sascha Hauer To: Shengjiu Wang Subject: Re: [PATCH] ASoC: fsl_micfil: fix the naming style for mask definition Message-ID: <20220505075017.GJ4012@pengutronix.de> References: <1651736047-28809-1-git-send-email-shengjiu.wang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1651736047-28809-1-git-send-email-shengjiu.wang@nxp.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 09:49:44 up 35 days, 20:19, 82 users, load average: 0.27, 0.17, 0.11 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linuxppc-dev@lists.ozlabs.org X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, Xiubo.Lee@gmail.com, festevam@gmail.com, tiwai@suse.com, lgirdwood@gmail.com, perex@perex.cz, nicoleotsuka@gmail.com, broonie@kernel.org, shengjiu.wang@gmail.com, linux-kernel@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, May 05, 2022 at 03:34:07PM +0800, Shengjiu Wang wrote: > Remove the _SHIFT for the mask definition. > > Fixes: 17f2142bae4b ("ASoC: fsl_micfil: use GENMASK to define register bit fields") > Signed-off-by: Shengjiu Wang > --- Acked-by: Sascha Hauer Sascha > sound/soc/fsl/fsl_micfil.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/sound/soc/fsl/fsl_micfil.h b/sound/soc/fsl/fsl_micfil.h > index 08901827047d..053caba3caf3 100644 > --- a/sound/soc/fsl/fsl_micfil.h > +++ b/sound/soc/fsl/fsl_micfil.h > @@ -74,9 +74,9 @@ > #define MICFIL_FIFO_STAT_FIFOX_UNDER(ch) BIT((ch) + 8) > > /* MICFIL HWVAD0 Control 1 Register -- REG_MICFIL_VAD0_CTRL1*/ > -#define MICFIL_VAD0_CTRL1_CHSEL_SHIFT GENMASK(26, 24) > -#define MICFIL_VAD0_CTRL1_CICOSR_SHIFT GENMASK(19, 16) > -#define MICFIL_VAD0_CTRL1_INITT_SHIFT GENMASK(12, 8) > +#define MICFIL_VAD0_CTRL1_CHSEL GENMASK(26, 24) > +#define MICFIL_VAD0_CTRL1_CICOSR GENMASK(19, 16) > +#define MICFIL_VAD0_CTRL1_INITT GENMASK(12, 8) > #define MICFIL_VAD0_CTRL1_ST10 BIT(4) > #define MICFIL_VAD0_CTRL1_ERIE BIT(3) > #define MICFIL_VAD0_CTRL1_IE BIT(2) > @@ -106,7 +106,7 @@ > > /* MICFIL HWVAD0 Zero-Crossing Detector - REG_MICFIL_VAD0_ZCD */ > #define MICFIL_VAD0_ZCD_ZCDTH GENMASK(25, 16) > -#define MICFIL_VAD0_ZCD_ZCDADJ_SHIFT GENMASK(11, 8) > +#define MICFIL_VAD0_ZCD_ZCDADJ GENMASK(11, 8) > #define MICFIL_VAD0_ZCD_ZCDAND BIT(4) > #define MICFIL_VAD0_ZCD_ZCDAUT BIT(2) > #define MICFIL_VAD0_ZCD_ZCDEN BIT(0) > -- > 2.17.1 > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A3EBC433F5 for ; Thu, 5 May 2022 07:51:25 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0E7431798; Thu, 5 May 2022 09:50:33 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0E7431798 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1651737083; bh=8dNuoh6SLylvxcZb3aIIezwYFrh+1vb4aKJVCYBOKxc=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ClEKJ0cew+Jat2tV7uYy/BW/W02qrVKAbR2VhzY+RlkoABxjQlux7IYh1uurSi7g8 E0H6jct8wsJSK1zvUAUBj2Jmdm1dZvAlg39lKYpp7u8f1X78blYwE3QnKOhJDA/6Fd O6ypWnDvduFQGuGhh6gQWIvVResVZ7jE0AHCGH5w= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id A3B5FF8016A; Thu, 5 May 2022 09:50:32 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6DFE3F800D3; Thu, 5 May 2022 09:50:31 +0200 (CEST) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 661D2F800F0 for ; Thu, 5 May 2022 09:50:25 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 661D2F800F0 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmWFe-0005Nb-AM; Thu, 05 May 2022 09:50:18 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nmWFd-0000oa-KA; Thu, 05 May 2022 09:50:17 +0200 Date: Thu, 5 May 2022 09:50:17 +0200 From: Sascha Hauer To: Shengjiu Wang Subject: Re: [PATCH] ASoC: fsl_micfil: fix the naming style for mask definition Message-ID: <20220505075017.GJ4012@pengutronix.de> References: <1651736047-28809-1-git-send-email-shengjiu.wang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1651736047-28809-1-git-send-email-shengjiu.wang@nxp.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 09:49:44 up 35 days, 20:19, 82 users, load average: 0.27, 0.17, 0.11 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: alsa-devel@alsa-project.org Cc: alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, Xiubo.Lee@gmail.com, festevam@gmail.com, tiwai@suse.com, lgirdwood@gmail.com, nicoleotsuka@gmail.com, broonie@kernel.org, shengjiu.wang@gmail.com, linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, May 05, 2022 at 03:34:07PM +0800, Shengjiu Wang wrote: > Remove the _SHIFT for the mask definition. > > Fixes: 17f2142bae4b ("ASoC: fsl_micfil: use GENMASK to define register bit fields") > Signed-off-by: Shengjiu Wang > --- Acked-by: Sascha Hauer Sascha > sound/soc/fsl/fsl_micfil.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/sound/soc/fsl/fsl_micfil.h b/sound/soc/fsl/fsl_micfil.h > index 08901827047d..053caba3caf3 100644 > --- a/sound/soc/fsl/fsl_micfil.h > +++ b/sound/soc/fsl/fsl_micfil.h > @@ -74,9 +74,9 @@ > #define MICFIL_FIFO_STAT_FIFOX_UNDER(ch) BIT((ch) + 8) > > /* MICFIL HWVAD0 Control 1 Register -- REG_MICFIL_VAD0_CTRL1*/ > -#define MICFIL_VAD0_CTRL1_CHSEL_SHIFT GENMASK(26, 24) > -#define MICFIL_VAD0_CTRL1_CICOSR_SHIFT GENMASK(19, 16) > -#define MICFIL_VAD0_CTRL1_INITT_SHIFT GENMASK(12, 8) > +#define MICFIL_VAD0_CTRL1_CHSEL GENMASK(26, 24) > +#define MICFIL_VAD0_CTRL1_CICOSR GENMASK(19, 16) > +#define MICFIL_VAD0_CTRL1_INITT GENMASK(12, 8) > #define MICFIL_VAD0_CTRL1_ST10 BIT(4) > #define MICFIL_VAD0_CTRL1_ERIE BIT(3) > #define MICFIL_VAD0_CTRL1_IE BIT(2) > @@ -106,7 +106,7 @@ > > /* MICFIL HWVAD0 Zero-Crossing Detector - REG_MICFIL_VAD0_ZCD */ > #define MICFIL_VAD0_ZCD_ZCDTH GENMASK(25, 16) > -#define MICFIL_VAD0_ZCD_ZCDADJ_SHIFT GENMASK(11, 8) > +#define MICFIL_VAD0_ZCD_ZCDADJ GENMASK(11, 8) > #define MICFIL_VAD0_ZCD_ZCDAND BIT(4) > #define MICFIL_VAD0_ZCD_ZCDAUT BIT(2) > #define MICFIL_VAD0_ZCD_ZCDEN BIT(0) > -- > 2.17.1 > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |