From: Dan Carpenter <dan.carpenter@oracle.com>
To: Wen Gong <quic_wgong@quicinc.com>
Cc: ath11k@lists.infradead.org
Subject: Re: [bug report] ath11k: report rssi of each chain to mac80211 for QCA6390/WCN6855
Date: Thu, 5 May 2022 14:05:00 +0300 [thread overview]
Message-ID: <20220505110500.GS4031@kadam> (raw)
In-Reply-To: <30bdad0a-4cbf-b800-5451-99bdda144555@quicinc.com>
On Thu, May 05, 2022 at 06:32:48PM +0800, Wen Gong wrote:
> On 5/5/2022 6:25 PM, Dan Carpenter wrote:
> > Hello Wen Gong,
> >
> > The patch b488c766442f: "ath11k: report rssi of each chain to
> > mac80211 for QCA6390/WCN6855" from Dec 17, 2021, leads to the
> > following Smatch static checker warning:
> >
> > drivers/net/wireless/ath/ath11k/wmi.c:5800 ath11k_wmi_tlv_rssi_chain_parse()
> > warn: missing error code here? 'ieee80211_find_sta_by_ifaddr()' failed. 'ret' = '0'
>
> yes, it should return 0.
>
> please see this commit:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/drivers/net/wireless/ath/ath11k?id=7330e1ec9748948177830c6e1a13379835d577f9
>
> ath11k: fix warning of not found station for bssid in message
>
We could silence the warning and make the code more obvious by setting
the "ret = 0;" explicitly or another option would be to add a comment.
regards,
dan carpenter
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
prev parent reply other threads:[~2022-05-05 11:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 10:25 [bug report] ath11k: report rssi of each chain to mac80211 for QCA6390/WCN6855 Dan Carpenter
2022-05-05 10:32 ` Wen Gong
2022-05-05 11:05 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220505110500.GS4031@kadam \
--to=dan.carpenter@oracle.com \
--cc=ath11k@lists.infradead.org \
--cc=quic_wgong@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.