From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 443E8C433F5 for ; Thu, 5 May 2022 15:13:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1381147AbiEEPQn (ORCPT ); Thu, 5 May 2022 11:16:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238972AbiEEPQl (ORCPT ); Thu, 5 May 2022 11:16:41 -0400 Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17BAA3B286 for ; Thu, 5 May 2022 08:13:01 -0700 (PDT) Received: by mail-pl1-x631.google.com with SMTP id s14so4674544plk.8 for ; Thu, 05 May 2022 08:13:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=2wlYERcgnCLAaGqsbd7fOqZETRKFZxGs9XvcdQRYFMs=; b=geKVNTNybY/+Px2TIQnqPrDLrg1uBwMBSLGE63bW3i0sNfKa3mK3gWax7DeNsunYtm hSOxNTEc26AJDT2ECSyByFzApv+60AcKRxp2wR4PFZej2jd6D9mUAJMo23d5DU11haGO UD4iP9anlo0EqdPJigsRRshmq0G2BnYFzeVbOeZNa5uO+m2oafjNk8FdQuXpfgz+zXjy 5M9dKwvPEaZuitQ3EN+bdVyC9l8ND5rvSg8jB8q0xKmrmDCE6HOnazl4yvEaUAKvCQdN b8L4RI6//Pm84428VhysfgaRtAy2xtzY3NyGt1SrjMn3W2zc8dFVlrV6fjNMIa/AeBw7 +fwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2wlYERcgnCLAaGqsbd7fOqZETRKFZxGs9XvcdQRYFMs=; b=W4ItBAI0PjZOJEyScz+uFFRQy/Ij6Qtdvfn+wtv1LTsP8l52PlTAr85QgPxXtoEQYq PsNSkwjva/b0L1kPdev0jDzZzxeD+rvnxKt+tfYBbsqckKufU+F5DT+IrmwPyNJbKZ1q sKGCqzWiZfUjjy2rr2b++HWU2lrY7yaR+BDIU0bNEPqC0JGLS1Qc/GNwePMb6tf/5DNo PuQskYz2M9TgboJ4fF4HkHSKngkRVsaKu6CbHcuyq5/EkF114Pk4bRM/LGOzhqvRb3nj jxOiKUvSALbJM9gMarre1d+Pcqd3GLrX8RTgVPqEEO84XDDvqqkp6TWvHXJ0OnJzU3qM fZug== X-Gm-Message-State: AOAM533J6AZiaLBGzwNmvJaLpcKPRMGbua3qARPuuRZF0RPBzuvZu9mX qmVF3FqpMvh0q4j6jumR1SBDAg== X-Google-Smtp-Source: ABdhPJzh79O/u5pjw8Y1QV9h1YnDrFnPoODtYCbRorbI8cztRbFTiFVP2Lawy8XaqC/QmEMUvVHglA== X-Received: by 2002:a17:90a:4898:b0:1d9:50aa:2a62 with SMTP id b24-20020a17090a489800b001d950aa2a62mr6704326pjh.115.1651763580458; Thu, 05 May 2022 08:13:00 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([134.195.101.46]) by smtp.gmail.com with ESMTPSA id c17-20020a63ef51000000b003c2f9540127sm1414485pgk.93.2022.05.05.08.12.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 May 2022 08:12:59 -0700 (PDT) Date: Thu, 5 May 2022 23:12:50 +0800 From: Leo Yan To: German Gomez Cc: Ali Saidi , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, acme@kernel.org, benh@kernel.crashing.org, Nick.Forrington@arm.com, alexander.shishkin@linux.intel.com, andrew.kilroy@arm.com, james.clark@arm.com, john.garry@huawei.com, jolsa@kernel.org, kjain@linux.ibm.com, lihuafei1@huawei.com, mark.rutland@arm.com, mathieu.poirier@linaro.org, mingo@redhat.com, namhyung@kernel.org, peterz@infradead.org, will@kernel.org Subject: Re: [PATCH v7 5/5] perf arm-spe: Use SPE data source for neoverse cores Message-ID: <20220505151250.GC136333@leoy-ThinkPad-X240s> References: <20220426135937.18497-1-alisaidi@amazon.com> <20220426135937.18497-6-alisaidi@amazon.com> <458a2de1-dc93-7e2d-5dc5-fbcd670572b6@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <458a2de1-dc93-7e2d-5dc5-fbcd670572b6@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 03, 2022 at 10:58:15AM +0100, German Gomez wrote: [...] > > +static void arm_spe__synth_data_source_generic(const struct arm_spe_record *record, > > + union perf_mem_data_src *data_src) > > +{ > > if (record->type & (ARM_SPE_LLC_ACCESS | ARM_SPE_LLC_MISS)) { > > - data_src.mem_lvl = PERF_MEM_LVL_L3; > > + data_src->mem_lvl = PERF_MEM_LVL_L3; > > Thanks for addressing my previous comment about filling both mem_lvl and mem_lvl_num. > > I wonder if it's also worth updating for the non-Neoverse cores as well while we're at it. I'll let Leo decide since this patchset is only focused on Neoverse. Thanks for pointing out this. Yeah, Let's use this patch set for enabling Neoverse data source. We can use a new patch to updating cache level for non-Neoverse cores (it's better also set store cache level as LVL_NA for non-Neoverse cores). Thanks, Leo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ACC1EC433EF for ; Thu, 5 May 2022 15:14:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dZdyGRbUdrZqiUsdgMeZt693wvifKP9FsQOUBuH5pw4=; b=rUfr8N1SIo2lr9 D1Dgx3dAqjYVLMrxN1nX/+Ah5zL+KDxTvvrtNUNvMYeKdc0hTw+5by9BhvBOPR2baMen04wRj7rnr bP2LIOxkXF9Y3Zilq2Vr6WfVHCa9CwGzJ7q5RjtYptshuu961FysjOJ8Rv9aB8gdb65NJvHgkts+w Tm5O+z6AGdUmRq1c/2veEaw7IcGaTmrH5fdF3LXC/qOnjTt3XPfjYcQLD/p2W/quhag6iFiUAPDrw g/Pa4JPP7aoNogsqW6FcdYOAI0HjckymDbcozli07x+PCkF7+QkfTNTgtOwjlXsZ0jGo+yQQXqVMM bCu7PvJ5EoP/cCW6cqDQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmdAG-00Gasi-KR; Thu, 05 May 2022 15:13:12 +0000 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmdAD-00Gao6-5R for linux-arm-kernel@lists.infradead.org; Thu, 05 May 2022 15:13:11 +0000 Received: by mail-pl1-x62d.google.com with SMTP id d17so4706999plg.0 for ; Thu, 05 May 2022 08:13:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=2wlYERcgnCLAaGqsbd7fOqZETRKFZxGs9XvcdQRYFMs=; b=geKVNTNybY/+Px2TIQnqPrDLrg1uBwMBSLGE63bW3i0sNfKa3mK3gWax7DeNsunYtm hSOxNTEc26AJDT2ECSyByFzApv+60AcKRxp2wR4PFZej2jd6D9mUAJMo23d5DU11haGO UD4iP9anlo0EqdPJigsRRshmq0G2BnYFzeVbOeZNa5uO+m2oafjNk8FdQuXpfgz+zXjy 5M9dKwvPEaZuitQ3EN+bdVyC9l8ND5rvSg8jB8q0xKmrmDCE6HOnazl4yvEaUAKvCQdN b8L4RI6//Pm84428VhysfgaRtAy2xtzY3NyGt1SrjMn3W2zc8dFVlrV6fjNMIa/AeBw7 +fwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2wlYERcgnCLAaGqsbd7fOqZETRKFZxGs9XvcdQRYFMs=; b=hmdIW7mo3e6FJXkJQ5RvKnKPDPJ72IlKjtwS/h7V4M7ellshyBQJ3QOq1eqZ+QKWfx 3YqonD1VXP2b82C9LAPeZcdounPMjy5DJgSWUc7RC1JDEbbDZTYEYCMbZhJ8d16NLWJY FFDQGh6rRZGNxZjX9rEk62QMv33OvMwPX6o5zgpJKuDmdXaGBnIvEmnLaNTaSm438Jee wq5eDUvZ45rH0yq5jvI88xiOgLAYB7u5E24g1ezM3X+TxE9nEvZ5o+OTfQRdlzDN0u4Z uftgZEHQ8qg09zqQBSyfC05z7BZ+kQF+aA8p3iM+THhtdKMx4uyang9BCIibXsgeYi8C Sgmw== X-Gm-Message-State: AOAM5324fSj+05eOnEUOj34V4g/8uqSJwq7jiGAyIvpFBnecq3YaPPGF A3vIspkvmVOWHrXcRzW9p6Eg9A== X-Google-Smtp-Source: ABdhPJzh79O/u5pjw8Y1QV9h1YnDrFnPoODtYCbRorbI8cztRbFTiFVP2Lawy8XaqC/QmEMUvVHglA== X-Received: by 2002:a17:90a:4898:b0:1d9:50aa:2a62 with SMTP id b24-20020a17090a489800b001d950aa2a62mr6704326pjh.115.1651763580458; Thu, 05 May 2022 08:13:00 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([134.195.101.46]) by smtp.gmail.com with ESMTPSA id c17-20020a63ef51000000b003c2f9540127sm1414485pgk.93.2022.05.05.08.12.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 May 2022 08:12:59 -0700 (PDT) Date: Thu, 5 May 2022 23:12:50 +0800 From: Leo Yan To: German Gomez Cc: Ali Saidi , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, acme@kernel.org, benh@kernel.crashing.org, Nick.Forrington@arm.com, alexander.shishkin@linux.intel.com, andrew.kilroy@arm.com, james.clark@arm.com, john.garry@huawei.com, jolsa@kernel.org, kjain@linux.ibm.com, lihuafei1@huawei.com, mark.rutland@arm.com, mathieu.poirier@linaro.org, mingo@redhat.com, namhyung@kernel.org, peterz@infradead.org, will@kernel.org Subject: Re: [PATCH v7 5/5] perf arm-spe: Use SPE data source for neoverse cores Message-ID: <20220505151250.GC136333@leoy-ThinkPad-X240s> References: <20220426135937.18497-1-alisaidi@amazon.com> <20220426135937.18497-6-alisaidi@amazon.com> <458a2de1-dc93-7e2d-5dc5-fbcd670572b6@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <458a2de1-dc93-7e2d-5dc5-fbcd670572b6@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220505_081309_257692_7AFD18EF X-CRM114-Status: GOOD ( 11.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 03, 2022 at 10:58:15AM +0100, German Gomez wrote: [...] > > +static void arm_spe__synth_data_source_generic(const struct arm_spe_record *record, > > + union perf_mem_data_src *data_src) > > +{ > > if (record->type & (ARM_SPE_LLC_ACCESS | ARM_SPE_LLC_MISS)) { > > - data_src.mem_lvl = PERF_MEM_LVL_L3; > > + data_src->mem_lvl = PERF_MEM_LVL_L3; > > Thanks for addressing my previous comment about filling both mem_lvl and mem_lvl_num. > > I wonder if it's also worth updating for the non-Neoverse cores as well while we're at it. I'll let Leo decide since this patchset is only focused on Neoverse. Thanks for pointing out this. Yeah, Let's use this patch set for enabling Neoverse data source. We can use a new patch to updating cache level for non-Neoverse cores (it's better also set store cache level as LVL_NA for non-Neoverse cores). Thanks, Leo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel