From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AFA2C433F5 for ; Thu, 5 May 2022 19:21:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244695AbiEETYt (ORCPT ); Thu, 5 May 2022 15:24:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244603AbiEETYs (ORCPT ); Thu, 5 May 2022 15:24:48 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54334532E7 for ; Thu, 5 May 2022 12:21:06 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmh1x-0006U1-H7; Thu, 05 May 2022 21:20:53 +0200 Received: from pengutronix.de (unknown [46.183.103.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id DAF3E76CDB; Thu, 5 May 2022 19:20:48 +0000 (UTC) Date: Thu, 5 May 2022 21:20:46 +0200 From: Marc Kleine-Budde To: Steffen Trumtrar Cc: linux-crypto@vger.kernel.org, io-uring@vger.kernel.org, kernel@pengutronix.de, Horia =?utf-8?Q?Geant=C4=83?= , Pankaj Gupta , Gaurav Jain , Jens Axboe , Pavel Begunkov , Boris Pismenny , John Fastabend , Daniel Borkmann , Jakub Kicinski , netdev@vger.kernel.org Subject: Re: [BUG] Layerscape CAAM+kTLS+io_uring Message-ID: <20220505192046.hczmzg7k6tz2rjv3@pengutronix.de> References: <878rrqrgaj.fsf@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xmctf7v3rssq5mte" Content-Disposition: inline In-Reply-To: <878rrqrgaj.fsf@pengutronix.de> X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-crypto@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org --xmctf7v3rssq5mte Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello, no one seems to care about this problem. :/ Maybe too many components are involved, I'm the respective maintainers on Cc. Cc +=3D the CAAM maintainers Cc +=3D the io_uring maintainers Cc +=3D the kTLS maintainers On 27.04.2022 10:20:40, Steffen Trumtrar wrote: > Hi all, >=20 > I have a Layerscape-1046a based board where I'm trying to use a > combination of liburing (v2.0) with splice, kTLS and CAAM (kernel > v5.17). The problem I see is that on shutdown the last bytes are > missing. It looks like io_uring is not waiting for all completions > from the CAAM driver. >=20 > With ARM-ASM instead of the CAAM, the setup works fine. What's the difference between the CAAM and ARM-ASM crypto? Without looking into the code I think the CAAM is asynchron while ARM-ASM is synchron. Is this worth investigating? > I tried to debug with ftrace and see where it goes wrong. Here is what > seems to be (at least to me) some of the last bytes: >=20 > webserver-612 [002] ..... 135.300350: io_uring_file_get: ring 0000= 000078f4a859, fd 6 00078f4a859, fd 7 > webserver-612 [002] ..... 135.300352: io_uring_submit_sqe: r= ing 0000000078f4a859, req 00000000fbb9b849, op 30, data 0xf3e096f0, flags 8= 196, non block 1, sq_thread 0 > webserver-612 [002] ..... 135.300353: io_uring_submit_sqe: r= ing 0000000078f4a859, req 00000000ff858bdf, op 15, data 0x0, flags 2097152,= non block 1, sq_thread 0 > webserver-612 [002] ..... 135.300353: io_uring_link: ring 00= 00000078f4a859, request 00000000ff858bdf linked after 00000000fbb9b849 > webserver-612 [002] ..... 135.300354: io_uring_queue_async_w= ork: ring 0000000078f4a859, request 00000000fbb9b849, flags 798724, normal = queue, work 0000000060cd323f > webserver-612 [002] ..... 135.300358: io_uring_cqring_wait: = ring 0000000078f4a859, min_events 1 > iou-wrk-612-647 [003] ...1. 135.300375: io_uring_complete: rin= g 0000000078f4a859, user_data 0xf3e096f0, result 4352, cflags 0 > iou-wrk-612-647 [003] d..2. 135.300379: io_uring_complete: rin= g 0000000078f4a859, user_data 0x0, result -125, cflags 0 > webserver-612 [002] ..... 135.300388: io_uring_file_get: rin= g 0000000078f4a859, fd 6 > webserver-612 [002] ..... 135.300389: io_uring_file_get: rin= g 0000000078f4a859, fd 7 0000078f4a859, req 000000008c2bf2be, op 30, data 0= xf3e096f0, flags 8196, non block 1, sq_thread 0 > webserver-612 [002] ..... 135.300390: io_uring_submit_sqe: r= ing 0000000078f4a859, req 00000000fe4e50d1, op 15, data 0x0, flags 2097152,= non block 1, sq_thread 0 > webserver-612 [002] ..... 135.300391: io_uring_link: ring 00= 00000078f4a859, request 00000000fe4e50d1 linked after 000000008c2bf2be > webserver-612 [002] ..... 135.300392: io_uring_queue_async_w= ork: ring 0000000078f4a859, request 000000008c2bf2be, flags 798724, normal = queue, work 00000000f2b434fc > webserver-612 [002] ..... 135.300396: io_uring_cqring_wait: = ring 0000000078f4a859, min_events 1 > iou-wrk-612-647 [003] ...1. 135.300410: io_uring_complete: rin= g 0000000078f4a859, user_data 0xf3e096f0, result 4352, cflags 0 > iou-wrk-612-647 [003] d..2. 135.300414: io_uring_complete: rin= g 0000000078f4a859, user_data 0x0, result -125, cflags 0 > webserver-612 [002] ..... 135.300423: io_uring_file_get: rin= g 0000000078f4a859, fd 6 > webserver-612 [002] ..... 135.300424: io_uring_file_get: rin= g 0000000078f4a859, fd 7 > webserver-612 [002] ..... 135.300424: io_uring_submit_sqe: r= ing 0000000078f4a859, req 00000000e48f3098, op 30, data 0xf3e096f0, flags 8= 196, non block 1, sq_thread 0 > webserver-612 [002] ..... 135.300426: io_uring_submit_sqe: r= ing 0000000078f4a859, req 00000000ec67d53c, op 15, data 0x0, flags 2097152,= non block 1, sq_thread 0 > webserver-612 [002] ..... 135.300426: io_uring_link: ring 00= 00000078f4a859, request 00000000ec67d53c linked after 00000000e48f3098 > webserver-612 [002] ..... 135.300427: io_uring_queue_async_w= ork: ring 0000000078f4a859, request 00000000e48f3098, flags 798724, normal = queue, work 000000009e3701da > webserver-612 [002] ..... 135.300431: io_uring_cqring_wait: = ring 0000000078f4a859, min_events 1 > iou-wrk-612-647 [003] ...1. 135.300447: io_uring_complete: rin= g 0000000078f4a859, user_data 0xf3e096f0, result 4352, cflags 0 > iou-wrk-612-647 [003] d..2. 135.300452: io_uring_complete: rin= g 0000000078f4a859, user_data 0x0, result -125, cflags 0 > webserver-612 [002] ..... 135.300461: io_uring_file_get: rin= g 0000000078f4a859, fd 6 > webserver-612 [002] ..... 135.300462: io_uring_file_get: rin= g 0000000078f4a859, fd 7 > webserver-612 [002] ..... 135.300462: io_uring_submit_sqe: r= ing 0000000078f4a859, req 00000000f658f96f, op 30, data 0xf3e096f0, flags 8= 196, non block 1, sq_thread 0, sq_thread 0 > webserver-612 [002] ..... 135.300464: io_uring_link: ring 00= 00000078f4a859, request 000000006c29e721 linked after 00000000f658f96f > webserver-612 [002] ..... 135.300465: io_uring_queue_async_w= ork: ring 0000000078f4a859, request 00000000f658f96f, flags 798724, normal = queue, work 000000007434c68b > webserver-612 [002] ..... 135.300469: io_uring_cqring_wait: = ring 0000000078f4a859, min_events 1 > iou-wrk-612-647 [003] ...1. 135.300479: io_uring_complete: rin= g 0000000078f4a859, user_data 0xf3e096f0, result 4608, cflags 0 > iou-wrk-612-647 [003] d..2. 135.300483: io_uring_complete: rin= g 0000000078f4a859, user_data 0x0, result -125, cflags 0 > webserver-612 [002] ..... 135.300492: io_uring_file_get: rin= g 0000000078f4a859, fd 6 > webserver-612 [002] ..... 135.300493: io_uring_file_get: rin= g 0000000078f4a859, fd 7 > webserver-612 [002] ..... 135.300494: io_uring_submit_sqe: r= ing 0000000078f4a859, req 00000000757ef148, op 30, data 0xf3e096f0, flags 8= 196, non block 1, sq_thread 0 > webserver-612 [002] ..... 135.300495: io_uring_submit_sqe: r= ing 0000000078f4a859, req 00000000e5c82137, op 15, data 0x0, flags 2097152,= non block 1, sq_thread 0 8f4a859, request 00000000e5c82137 linked after 00= 000000757ef148 > webserver-612 [002] ..... 135.300496: io_uring_queue_async_w= ork: ring 0000000078f4a859, request 00000000757ef148, flags 798724, normal = queue, work 00000000b55630dd > webserver-612 [002] ..... 135.300500: io_uring_cqring_wait: = ring 0000000078f4a859, min_events 1 > iou-wrk-612-647 [003] ...1. 135.300516: io_uring_complete: rin= g 0000000078f4a859, user_data 0xf3e096f0, result 4608, cflags 0 > iou-wrk-612-647 [003] d..2. 135.300520: io_uring_complete: rin= g 0000000078f4a859, user_data 0x0, result -125, cflags 0 > webserver-612 [002] ..... 135.300529: io_uring_file_get: rin= g 0000000078f4a859, fd 6 > webserver-612 [002] ..... 135.300530: io_uring_file_get: rin= g 0000000078f4a859, fd 7 > webserver-612 [002] ..... 135.300531: io_uring_submit_sqe: r= ing 0000000078f4a859, req 0000000085e5cac4, op 30, data 0xf3e096f0, flags 8= 196, non block 1, sq_thread 0 > webserver-612 [002] ..... 135.300532: io_uring_submit_sqe: r= ing 0000000078f4a859, req 0000000008e6a863, op 15, data 0x0, flags 2097152,= non block 1, sq_thread 0 > webserver-612 [002] ..... 135.300532: io_uring_link: ring 00= 00000078f4a859, request 0000000008e6a863 linked after 0000000085e5cac4 ng 0= 000000078f4a859, request 0000000085e5cac4, flags 798724, normal queue, work= 0000000036c4ff52 > webserver-612 [002] ..... 135.300537: io_uring_cqring_wait: = ring 0000000078f4a859, min_events 1 > iou-wrk-612-647 [003] ...1. 135.300553: io_uring_complete: rin= g 0000000078f4a859, user_data 0xf3e096f0, result 4608, cflags 0 > iou-wrk-612-647 [003] d..2. 135.300557: io_uring_complete: rin= g 0000000078f4a859, user_data 0x0, result -125, cflags 0 > webserver-612 [002] ..... 135.300566: io_uring_file_get: rin= g 0000000078f4a859, fd 6 > webserver-612 [002] ..... 135.300567: io_uring_file_get: rin= g 0000000078f4a859, fd 7 > webserver-612 [002] ..... 135.300567: io_uring_submit_sqe: r= ing 0000000078f4a859, req 000000000f7fdd39, op 30, data 0xf3e096f0, flags 8= 196, non block 1, sq_thread 0 > webserver-612 [002] ..... 135.300568: io_uring_submit_sqe: r= ing 0000000078f4a859, req 00000000741c64e1, op 15, data 0x0, flags 2097152,= non block 1, sq_thread 0 > webserver-612 [002] ..... 135.300569: io_uring_link: ring 00= 00000078f4a859, request 00000000741c64e1 linked after 000000000f7fdd39 > webserver-612 [002] ..... 135.300570: io_uring_queue_async_w= ork: ring 0000000078f4a859, request 000000000f7fdd39, flags 798724, normal = queue, work 00000000fc4accf1 > webserver-612 [002] ..... 135.300574: io_uring_cqring_wait: = ring 0000000078f4a859, min_events 1 > iou-wrk-612-647 [003] ...1. 135.300594: io_uring_complete: rin= g 0000000078f4a859, user_data 0xf3e096f0, result 4352, cflags 0 > iou-wrk-612-647 [003] d..2. 135.300598: io_uring_complete: rin= g 0000000078f4a859, user_data 0x0, result -125, cflags 0 > webserver-612 [002] ..... 135.300607: io_uring_file_get: rin= g 0000000078f4a859, fd 6 > webserver-612 [002] ..... 135.300608: io_uring_file_get: rin= g 0000000078f4a859, fd 7 > webserver-612 [002] ..... 135.300608: io_uring_submit_sqe: r= ing 0000000078f4a859, req 0000000052b47765, op 30, data 0xf3e096f0, flags 8= 196, non block 1, sq_thread 0 > webserver-612 [002] ..... 135.300610: io_uring_submit_sqe: r= ing 0000000078f4a859, req 000000003904ded9, op 15, data 0x0, flags 2097152,= non block 1, sq_thread 0 > webserver-612 [002] ..... 135.300611: io_uring_link: ring 00= 00000078f4a859, request 000000003904ded9 linked after 0000000052b47765 > webserver-612 [002] ..... 135.300612: io_uring_queue_async_w= ork: ring 0000000078f4a859, request 0000000052b47765, flags 798724, normal = queue, work 00000000e11c8599 > webserver-612 [002] ..... 135.300615: io_uring_cqring_wait: = ring 0000000078f4a859, min_events 1 > iou-wrk-612-647 [003] ...1. 135.300631: io_uring_complete: rin= g 0000000078f4a859, user_data 0xf3e096f0, result 768, cflags 0 > iou-wrk-612-647 [003] d..2. 135.300634: io_uring_complete: rin= g 0000000078f4a859, user_data 0x0, result -125, cflags 0 > webserver-612 [002] ..... 135.301668: io_uring_file_get: rin= g 0000000078f4a859, fd 6 > webserver-612 [002] ..... 135.301669: io_uring_submit_sqe: r= ing 0000000078f4a859, req 0000000012863980, op 34, data 0x0, flags 8, non b= lock 1, sq_thread 0 > webserver-612 [002] ..... 135.301670: io_uring_submit_sqe: r= ing 0000000078f4a859, req 00000000f4b07ff9, op 19, data 0x0, flags 0, non b= lock 1, sq_thread 0 > webserver-612 [002] ..... 135.301671: io_uring_link: ring 00= 00000078f4a859, request 00000000f4b07ff9 linked after 0000000012863980 > webserver-612 [002] ..... 135.301672: io_uring_queue_async_w= ork: ring 0000000078f4a859, request 0000000012863980, flags 262152, normal = queue, work 00000000102270ed > webserver-612 [002] ..... 135.301740: io_uring_cqring_wait: = ring 0000000078f4a859, min_events 1 > iou-wrk-612-648 [000] ...1. 135.301757: io_uring_complete: rin= g 0000000078f4a859, user_data 0x0, result 0, cflags 0 > iou-wrk-612-648 [000] ...1. 135.301767: io_uring_complete: rin= g 0000000078f4a859, user_data 0x0, result 0, cflags 0 > webserver-612 [002] ..... 135.301769: io_uring_cqring_wait: = ring 0000000078f4a859, min_events 1 >=20 >=20 > Userspace said that 768 bytes where missing. >=20 > Any ideas for how to debug this or why the async work queue doesn't work = with > the CAMM but does with ARM-ASM? > If I can provide more info that might help, I'll try to produce and > provide it. As there are multiple components involved, I'm not sure > where to start or what information is useful. Currently looks like CAAM > is the culprit. Can you provide test code or at least illustrate with code how you plug the components together? Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --xmctf7v3rssq5mte Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmJ0I4wACgkQrX5LkNig 011SSAf+LZh93GgtIwBJ809iPElSMdRYIi9XWArqcAF+wPlT5Ra3dPIBk51lecnM DMi2jJeefRP6KYLUkBTOcw6BD44WOPLDHmxe6HukF/B0kVyAMNorQQmnWyRZOrk4 VCxeILebccTs75nSY+vM0lPDOpcGp6Nk+i95yQ7HQcRRcLf2baRvocLy8vuWEFl1 Jfg4SzSOIngWcG9Dp8gL44Ey7UXeC/UxvB7ieTivKX0M5VZjadxHQiGn/R1txef5 Z5ZmB9sQNxy6AnnPz31xLccydqrPi+5DLewYth1pCNaoHuUFmxMnOXd0keUv9R9i YXHR8vvtAF0n4isRU8aHD9YoTrLXkA== =J+2o -----END PGP SIGNATURE----- --xmctf7v3rssq5mte--