All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: sbabic@denx.de, festevam@gmail.com,
	ariel.dalessandro@collabora.com, michael@amarulasolutions.com,
	tharvey@gateworks.com, sjg@chromium.org,
	alpernebiyasak@gmail.com, marek.behun@nic.cz, pali@kernel.org,
	sr@denx.de, ricardo@foundries.io, patrick.delaunay@foss.st.com,
	trini@konsulko.com
Cc: u-boot@lists.denx.de, Peng Fan <peng.fan@nxp.com>
Subject: [PATCH V2 7/7] binman_sym: guard with CONFIG_SPL_BINMAN_SYMBOLS
Date: Sat,  7 May 2022 19:04:01 +0800	[thread overview]
Message-ID: <20220507110402.21355-8-peng.fan@oss.nxp.com> (raw)
In-Reply-To: <20220507110402.21355-1-peng.fan@oss.nxp.com>

From: Peng Fan <peng.fan@nxp.com>

There is case that CONFIG_BINMAN is defined, but
CONFIG_SPL_BINMAN_SYMBOLS is not defined. In that case, there will be
build failure. So use CONFIG_SPL_BINMAN_SYMBOLS to guard the macros, and
define CONFIG_SPL_BINMAN_SYMBOLS in binman syms test.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 include/binman_sym.h                        | 2 +-
 tools/binman/test/u_boot_binman_syms.c      | 1 +
 tools/binman/test/u_boot_binman_syms_size.c | 1 +
 3 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/include/binman_sym.h b/include/binman_sym.h
index 72e6765fe52..548d8f5654c 100644
--- a/include/binman_sym.h
+++ b/include/binman_sym.h
@@ -13,7 +13,7 @@
 
 #define BINMAN_SYM_MISSING	(-1UL)
 
-#ifdef CONFIG_BINMAN
+#ifdef CONFIG_SPL_BINMAN_SYMBOLS
 
 /**
  * binman_symname() - Internal function to get a binman symbol name
diff --git a/tools/binman/test/u_boot_binman_syms.c b/tools/binman/test/u_boot_binman_syms.c
index 37fc339ce84..f4a4d1f6846 100644
--- a/tools/binman/test/u_boot_binman_syms.c
+++ b/tools/binman/test/u_boot_binman_syms.c
@@ -6,6 +6,7 @@
  */
 
 #define CONFIG_BINMAN
+#define CONFIG_SPL_BINMAN_SYMBOLS
 #include <binman_sym.h>
 
 binman_sym_declare(unsigned long, u_boot_spl_any, offset);
diff --git a/tools/binman/test/u_boot_binman_syms_size.c b/tools/binman/test/u_boot_binman_syms_size.c
index 7224bc1863c..3a01d8ca4be 100644
--- a/tools/binman/test/u_boot_binman_syms_size.c
+++ b/tools/binman/test/u_boot_binman_syms_size.c
@@ -6,6 +6,7 @@
  */
 
 #define CONFIG_BINMAN
+#define CONFIG_SPL_BINMAN_SYMBOLS
 #include <binman_sym.h>
 
 binman_sym_declare(char, u_boot_spl, pos);
-- 
2.36.0


  parent reply	other threads:[~2022-05-07 10:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-07 11:03 [PATCH V2 0/7] arm64: binman: use binman symbols for imx Peng Fan (OSS)
2022-05-07 11:03 ` [PATCH V2 1/7] spl: guard u_boot_any with X86 Peng Fan (OSS)
2022-05-07 11:03 ` [PATCH V2 2/7] arm: dts: imx8m: update binman ddr firmware node name Peng Fan (OSS)
2022-05-07 11:03 ` [PATCH V2 3/7] armv8: u-boot-spl.lds: mark __image_copy_start as symbol Peng Fan (OSS)
2022-05-07 11:03 ` [PATCH V2 4/7] tools: binman: section: replace @ with - Peng Fan (OSS)
2022-05-08 15:30   ` Tom Rini
2022-05-07 11:03 ` [PATCH V2 5/7] ddr: imx8m: helper: load ddr firmware according to binman symbols Peng Fan (OSS)
2022-05-09 17:32   ` Tim Harvey
2022-05-10  9:26     ` Peng Fan (OSS)
2022-05-07 11:04 ` [PATCH V2 6/7] arm: dts: imx8m: shrink ddr firmware size to actual file size Peng Fan (OSS)
2022-05-07 11:04 ` Peng Fan (OSS) [this message]
2022-05-08 15:30   ` [PATCH V2 7/7] binman_sym: guard with CONFIG_SPL_BINMAN_SYMBOLS Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220507110402.21355-8-peng.fan@oss.nxp.com \
    --to=peng.fan@oss.nxp.com \
    --cc=alpernebiyasak@gmail.com \
    --cc=ariel.dalessandro@collabora.com \
    --cc=festevam@gmail.com \
    --cc=marek.behun@nic.cz \
    --cc=michael@amarulasolutions.com \
    --cc=pali@kernel.org \
    --cc=patrick.delaunay@foss.st.com \
    --cc=peng.fan@nxp.com \
    --cc=ricardo@foundries.io \
    --cc=sbabic@denx.de \
    --cc=sjg@chromium.org \
    --cc=sr@denx.de \
    --cc=tharvey@gateworks.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.