Re: [PATCH 00/11] rename & split tests

[Christian Brauner <brauner@kernel.org>]

On Sun, May 01, 2022 at 07:46:43PM +0800, Zorro Lang wrote:
> On Thu, Apr 28, 2022 at 05:15:48PM +0200, Christian Brauner wrote:
> > From: "Christian Brauner (Microsoft)" <brauner@kernel.org>
> > 
> > Hey everyone,
> > 
> > As announced multiple times already we need to rename and split the
> > idmapped mount testsuite into separate source files and also give it a
> > better name to reflect the fact that it covers a lot more than just
> > idmapped mounts.
> > 
> > I have decided against compiling different binaries for now. Instead we
> > compile a single vfstest binary that can be called with various command
> > line switches to run the various test suites. This is not different than
> > what we did for the idmapped-mounts binary. Of course, nothing prevents
> > us from using multiple binaries in the future.
> > 
> > Note that this will have a conflict with Jan's series at:
> > https://lore.kernel.org/fstests/20220425131809.qzjrah7cw67mzzcw@zlang-mailbox/T/#m47d8da68ef1aff250918398e8d2228729a6acf97
> 
> Hi Christian,
> 
> Thanks for your patches! But even without above conflict patches, I still can't
> merge your patchset, failures as below [1].

Hi Zorro!

The fstests list has a limit on how large a single patch can be in terms
of number of lines (10.000, I believe). Since this patchset contains
patches that change about 10.000 lines the fstests list drops those
patches. I ran into this issue before when we added the testsuite in the
first place but it has never been fixed.

The consequence of this is that b4 is missing patches since they are on
no list. This becomes more obvious if you use b4's quilt option which
creates a folder with individual patches:

  0001_src_rename_idmapped_mounts_folder.patch
  0002_src_vfs_rename_idmapped_mounts_c_file.patch
  0003_vfstest_rename_struct_t_idmapped_mounts.patch
  0004_utils_add_missing_global_h_include.patch
  0006_utils_move_helpers_into_utils.patch
  0007_missing_move_sys_execveat_to_missing_h.patch
  0008_utils_add_struct_test_suite.patch
  0011_vfstest_split_out_remaining_idmapped_mount_tests.patch
  series

so this is missing patches 9 and 10...

> May you rebase your patches on latest fstests for-next branch, and send out
> again? As Christoph Hellwig has Acked your patchset, we'd better to make it

I think we will have the same problem, i.e., patches will not be on the
list since they are too large and so b4 won't work. To work around this
I'll give you a signed tag to pull from in the cover letter.

Christian