All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
To: Masahiro Yamada <yamada.masahiro@socionext.com>,
	Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Tom Rix <trix@redhat.com>
Cc: linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Rikard Falkeborn <rikard.falkeborn@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Kees Cook <keescook@chromium.org>, Will Deacon <will@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Subject: [RFC PATCH v2 0/2] call check-atomics.sh only if prerequisites change
Date: Sat,  7 May 2022 22:11:43 +0900	[thread overview]
Message-ID: <20220507131146.834810-1-mailhol.vincent@wanadoo.fr> (raw)
In-Reply-To: <20220426155229.436681-1-mailhol.vincent@wanadoo.fr>

Currently, check-atomics.sh is executed unconditionally despite the
fact that most developers do not need this to execute this check on
each iterative make instance.

This series first make check-atomics.sh raise an error instead of a
warning when CONFIG_WERROR is set. The second and last patch modifies
Kbuild so that the script is only called when dependencies are
changed.


* Changelog *

v1 -> v2

  * drop the changes on checksyscalls.sh. v1 assumed that
    checksyscalls.sh would only be called from ./Kbuild. It appears
    that there is another user: arch/mips/Makefile c.f. kernel test
    robot's report:
    https://lore.kernel.org/llvm/202205030015.JCmg5yPS-lkp@intel.com/

  * add a patch to the to make Kbuild stop if check-atomics fails and
    if CONFIG_WERROR is set.

Vincent Mailhol (2):
  check-atomiscs: stop build if CONFIG_WERROR=y
  kbuild: call check-atomics.sh only if prerequisites change

 Kbuild                          | 7 ++++---
 Makefile                        | 3 ++-
 scripts/atomic/check-atomics.sh | 9 +++++++--
 3 files changed, 13 insertions(+), 6 deletions(-)

-- 
2.35.1


  parent reply	other threads:[~2022-05-07 13:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-26 15:52 [RFC PATCH] kbuild: call checksyscalls.sh and check-atomics.sh only if prerequisites change Vincent Mailhol
2022-04-29 17:11 ` Masahiro Yamada
2022-05-07 11:43   ` Vincent MAILHOL
2022-05-02 16:52 ` kernel test robot
2022-05-07 13:11 ` Vincent Mailhol [this message]
2022-05-07 13:11   ` [RFC PATCH v2 1/2] check-atomiscs: stop build if CONFIG_WERROR=y Vincent Mailhol
2022-05-07 13:11   ` [RFC PATCH v2 2/2] kbuild: call check-atomics.sh only if prerequisites change Vincent Mailhol
2022-05-13 19:01     ` Masahiro Yamada
2022-05-14  3:21       ` Vincent MAILHOL
2022-05-14 13:14       ` Peter Zijlstra
2022-05-14 14:55         ` Peter Zijlstra
2022-05-14 16:26           ` Masahiro Yamada
2022-05-16  8:02             ` Peter Zijlstra
2022-05-14 16:07         ` Masahiro Yamada
2022-05-16  7:59           ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220507131146.834810-1-mailhol.vincent@wanadoo.fr \
    --to=mailhol.vincent@wanadoo.fr \
    --cc=akpm@linux-foundation.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=arnd@arndb.de \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=peterz@infradead.org \
    --cc=rikard.falkeborn@gmail.com \
    --cc=trix@redhat.com \
    --cc=will@kernel.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.