From: Andrew Morton <akpm@linux-foundation.org>
To: David Disseldorp <ddiss@suse.de>
Cc: mm-commits@vger.kernel.org, Martin Wilck <mwilck@suse.com>
Subject: Re: + initramfs-add-initramfs_preserve_mtime-kconfig-option.patch added to -mm tree
Date: Sat, 7 May 2022 13:16:59 -0700 [thread overview]
Message-ID: <20220507131659.e061e7f96c901f45c19e2220@linux-foundation.org> (raw)
In-Reply-To: <20220504164645.15fd6577@suse.de>
On Wed, 4 May 2022 16:46:45 +0200 David Disseldorp <ddiss@suse.de> wrote:
> > Benchmarks with a one million directory cpio archive extracted 20 times
> > demonstrated: mean extraction time (s) std dev INITRAMFS_PRESERVE_MTIME=y
> > 3.808 0.006 INITRAMFS_PRESERVE_MTIME unset 3.056 0.004
>
> The benchmark table above has been collapsed, making it mostly
> incomprehensible.
Fat fingers, thanks, fixed.
> > The above extraction times were measured using ftrace (initcall_finish -
> > initcall_start) values for populate_rootfs() with initramfs_async
> > disabled.
> >
> > [ddiss@suse.de: rebase atop dir_entry.name flexible array member and drop separate initramfs_mtime.h header]
> > Link: https://lkml.org/lkml/2008/9/3/424
> > Link: https://lkml.kernel.org/r/20220404093429.27570-4-ddiss@suse.de
> > Signed-off-by: David Disseldorp <ddiss@suse.de>
> > Reviewed-by: Martin Wilck <mwilck@suse.com>
>
> The reordering of the tags above is also somewhat confusing - I added
> the [ddiss@suse.de: rebase atop ...] to reflect minor changes that I
> made to the patch *after* Martin had provided his Reviewed-by tag.
Alas, I don't think anyone would interpret it that way.
I do think it would make sense to order these things chronologically,
to provide an account of who-did-what-and-when. But I'm not aware of
that presently being a convention with subsystem teams. Maybe I'm
wrong about that.
prev parent reply other threads:[~2022-05-07 20:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 20:44 + initramfs-add-initramfs_preserve_mtime-kconfig-option.patch added to -mm tree Andrew Morton
2022-05-04 14:46 ` David Disseldorp
2022-05-07 20:16 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220507131659.e061e7f96c901f45c19e2220@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ddiss@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=mwilck@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.