All of lore.kernel.org
 help / color / mirror / Atom feed
From: "José Roberto de Souza" <jose.souza@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH 02/16] drm/i915: Drop has_ipc from device info
Date: Sat,  7 May 2022 06:28:36 -0700	[thread overview]
Message-ID: <20220507132850.10272-2-jose.souza@intel.com> (raw)
In-Reply-To: <20220507132850.10272-1-jose.souza@intel.com>

No need to have this parameter in intel_device_info struct
as all platforms with display version 9 or newer supports this
feature.

As a side effect of the of removal this flag, it will not be printed
in dmesg during driver load anymore and developers will have to rely
on to check the macro and compare with platform being used and IP
versions of it.

v2:
- making this available to all platforms 9 and newer

Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Matt Roper <matthew.d.roper@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 drivers/gpu/drm/i915/i915_drv.h          | 2 +-
 drivers/gpu/drm/i915/i915_pci.c          | 3 ---
 drivers/gpu/drm/i915/intel_device_info.h | 1 -
 3 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index fd5269845e9ad..8d00d24e16dc5 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -1350,7 +1350,7 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
  */
 #define NEEDS_COMPACT_PT(dev_priv) (INTEL_INFO(dev_priv)->needs_compact_pt)
 
-#define HAS_IPC(dev_priv)		 (INTEL_INFO(dev_priv)->display.has_ipc)
+#define HAS_IPC(dev_priv)		 (DISPLAY_VER(dev_priv) >= 9)
 
 #define HAS_REGION(i915, i) (INTEL_INFO(i915)->memory_regions & (i))
 #define HAS_LMEM(i915) HAS_REGION(i915, REGION_LMEM)
diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
index 30a32a5d0e3c9..8a7f7aad1a5d2 100644
--- a/drivers/gpu/drm/i915/i915_pci.c
+++ b/drivers/gpu/drm/i915/i915_pci.c
@@ -632,7 +632,6 @@ static const struct intel_device_info chv_info = {
 	GEN9_DEFAULT_PAGE_SIZES, \
 	.display.has_dmc = 1, \
 	.display.has_hdcp = 1, \
-	.display.has_ipc = 1, \
 	.display.has_psr_hw_tracking = 1, \
 	.dbuf.size = 896 - 4, /* 4 blocks for bypass path allocation */ \
 	.dbuf.slice_mask = BIT(DBUF_S1)
@@ -691,7 +690,6 @@ static const struct intel_device_info skl_gt4_info = {
 	.ppgtt_size = 48, \
 	.has_snoop = true, \
 	.has_coherent_ggtt = false, \
-	.display.has_ipc = 1, \
 	HSW_PIPE_OFFSETS, \
 	IVB_CURSOR_OFFSETS, \
 	IVB_COLORS, \
@@ -930,7 +928,6 @@ static const struct intel_device_info adl_s_info = {
 	.display.has_fpga_dbg = 1,						\
 	.display.has_hdcp = 1,							\
 	.display.has_hotplug = 1,						\
-	.display.has_ipc = 1,							\
 	.display.ver = 13,							\
 	.display.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C) | BIT(PIPE_D),	\
 	.pipe_offsets = {							\
diff --git a/drivers/gpu/drm/i915/intel_device_info.h b/drivers/gpu/drm/i915/intel_device_info.h
index e8d53c7a1bd83..f614f29267273 100644
--- a/drivers/gpu/drm/i915/intel_device_info.h
+++ b/drivers/gpu/drm/i915/intel_device_info.h
@@ -173,7 +173,6 @@ enum intel_ppgtt_type {
 	func(has_hdcp); \
 	func(has_hotplug); \
 	func(has_hti); \
-	func(has_ipc); \
 	func(has_modular_fia); \
 	func(has_overlay); \
 	func(has_psr_hw_tracking); \
-- 
2.36.0


  reply	other threads:[~2022-05-07 13:29 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-07 13:28 [Intel-gfx] [PATCH 01/16] drm/i915: Drop has_llc from device info José Roberto de Souza
2022-05-07 13:28 ` José Roberto de Souza [this message]
2022-05-07 13:28 ` [Intel-gfx] [PATCH 03/16] drm/i915/display: Disable DSB for DG2 and Alderlake-P José Roberto de Souza
2022-05-07 13:28 ` [Intel-gfx] [PATCH 04/16] drm/i915: Drop has_rc6p from device info José Roberto de Souza
2022-05-07 13:28 ` [Intel-gfx] [PATCH 05/16] drm/i915: Drop has_psr_hw_tracking " José Roberto de Souza
2022-05-07 13:28 ` [Intel-gfx] [PATCH 06/16] drm/i915: Drop supports_tv " José Roberto de Souza
2022-05-07 13:28 ` [Intel-gfx] [PATCH 07/16] drm/i915: Drop has_4tile " José Roberto de Souza
2022-05-07 13:28 ` [Intel-gfx] [PATCH 08/16] drm/i915: Drop has_64bit_reloc " José Roberto de Souza
2022-05-07 13:28 ` [Intel-gfx] [PATCH 09/16] drm/i915: Drop has_global_mocs " José Roberto de Souza
2022-05-07 13:28 ` [Intel-gfx] [PATCH 10/16] drm/i915: Drop has_guc_deprivilege " José Roberto de Souza
2022-05-07 13:28 ` [Intel-gfx] [PATCH 11/16] drm/i915: Drop has_pxp " José Roberto de Souza
2022-05-07 18:05   ` kernel test robot
2022-05-07 19:47   ` kernel test robot
2022-05-07 13:28 ` [Intel-gfx] [PATCH 12/16] drm/i915: Drop has_heci_gscfi " José Roberto de Souza
2022-05-07 13:28 ` [Intel-gfx] [PATCH 13/16] " José Roberto de Souza
2022-05-07 13:28 ` [Intel-gfx] [PATCH 14/16] drm/i915: Drop has_runtime_pm " José Roberto de Souza
2022-05-07 13:28 ` [Intel-gfx] [PATCH 15/16] drm/i915: Drop has_logical_ring_contexts " José Roberto de Souza
2022-05-07 13:28 ` [Intel-gfx] [PATCH 16/16] drm/i915: Drop display.has_fpga_db " José Roberto de Souza
2022-05-09 12:38   ` Joonas Lahtinen
2022-05-09 14:19     ` Souza, Jose
2022-05-10  6:25       ` Joonas Lahtinen
2022-05-10  7:41         ` Jani Nikula
2022-05-11  7:39           ` Tvrtko Ursulin
2022-05-11 13:56             ` Souza, Jose
2022-05-07 13:43 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/16] drm/i915: Drop has_llc " Patchwork
2022-05-07 13:43 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-05-07 13:52 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-05-07 15:01 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-05-09 11:09 ` [Intel-gfx] [PATCH 01/16] " Matthew Auld
2022-05-09 14:05   ` Souza, Jose
2022-05-09 14:52     ` Matthew Auld
2022-05-09 14:55       ` Souza, Jose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220507132850.10272-2-jose.souza@intel.com \
    --to=jose.souza@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.