All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: linux-mm@kvack.org
Subject: Re: [PATCH 1/2] mm/mlock: not handle NULL vma specially
Date: Sat, 7 May 2022 14:03:46 -0700	[thread overview]
Message-ID: <20220507140346.e6e44657af1c98fea411239c@linux-foundation.org> (raw)
In-Reply-To: <20220504003958.18402-1-richard.weiyang@gmail.com>

On Wed,  4 May 2022 00:39:57 +0000 Wei Yang <richard.weiyang@gmail.com> wrote:

> If we can't find a proper vma, the loop would terminate as expected.
> 
> It's not necessary to handle it specially.
> 
> ...
>
> --- a/mm/mlock.c
> +++ b/mm/mlock.c
> @@ -504,11 +504,7 @@ static unsigned long count_mm_mlocked_page_nr(struct mm_struct *mm,
>  	if (mm == NULL)
>  		mm = current->mm;
>  
> -	vma = find_vma(mm, start);
> -	if (vma == NULL)
> -		return 0;
> -
> -	for (; vma ; vma = vma->vm_next) {
> +	for (vma = find_vma(mm, start); vma ; vma = vma->vm_next) {
>  		if (start >= vma->vm_end)
>  			continue;
>  		if (start + len <=  vma->vm_start)

The mapletree patches mangle this code a lot.

Please take a look at linux-next or the mm-unstabe branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm early to mid next
week, see if you see anything which should be addressed.



  parent reply	other threads:[~2022-05-07 21:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-04  0:39 [PATCH 1/2] mm/mlock: not handle NULL vma specially Wei Yang
2022-05-04  0:39 ` [PATCH 2/2] mm/mlock: start is always smaller then vm_end Wei Yang
2022-05-07 21:03 ` Andrew Morton [this message]
2022-05-07 21:56   ` [PATCH 1/2] mm/mlock: not handle NULL vma specially Wei Yang
2022-05-07 22:44     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220507140346.e6e44657af1c98fea411239c@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=linux-mm@kvack.org \
    --cc=richard.weiyang@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.