All of lore.kernel.org
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
To: Gautam Menghani <gautammenghani201@gmail.com>
Cc: sj@kernel.org, skhan@linuxfoundation.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add documentation for Enum value 'NR_DAMON_OPS' in
Date: Sat,  7 May 2022 20:15:07 +0000	[thread overview]
Message-ID: <20220507201507.46050-1-sj@kernel.org> (raw)
In-Reply-To: <20220507165620.110706-1-gautammenghani201@gmail.com>

Hi Gautam,


On Sat, 7 May 2022 22:26:20 +0530 Gautam Menghani <gautammenghani201@gmail.com> wrote:

> Fix the warning - "Enum value 'NR_DAMON_OPS' not described in 
> enum 'damon_ops_id'" generated by the command "make pdfdocs"
> 
> Signed-off-by: Gautam Menghani <gautammenghani201@gmail.com>
> ---
> Changes in v2:
> - Fix checkpatch warning of 75 characters per line
> - Fix email mismatch in from and signed by field

Thank you for the fix, but please read below.

Could you please adjust the subject so that we can know for what subsystem this
change is made?  E.g., mm/damon: Add documentation for ...

> 
>  include/linux/damon.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/damon.h b/include/linux/damon.h
> index f23cbfa4248d..b972a7a3b6f0 100644
> --- a/include/linux/damon.h
> +++ b/include/linux/damon.h
> @@ -262,6 +262,7 @@ struct damos {
>   *
>   * @DAMON_OPS_VADDR:	Monitoring operations for virtual address spaces
>   * @DAMON_OPS_PADDR:	Monitoring operations for the physical address space
> + * @NR_DAMON_OPS:	Number of monitoring operations for a particular implementation

My previous comment to this part seems not answered?  I'd suggest
's/for a particular implementation/implementations/'


Thanks,
SJ

>   */
>  enum damon_ops_id {
>  	DAMON_OPS_VADDR,
> -- 
> 2.25.1
> 

      reply	other threads:[~2022-05-07 20:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-07  7:08 [PATCH] Add documentation for Enum value 'NR_DAMON_OPS' in enum 'damon_ops_id' Gautam Menghani
2022-05-07 15:52 ` SeongJae Park
2022-05-07 16:56   ` [PATCH] Add documentation for Enum value 'NR_DAMON_OPS' in Gautam Menghani
2022-05-07 20:15     ` SeongJae Park [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220507201507.46050-1-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=gautammenghani201@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.