From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m17638.qiye.163.com (mail-m17638.qiye.163.com [59.111.176.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7A67184D for ; Sun, 8 May 2022 15:25:36 +0000 (UTC) Received: from localhost.localdomain (unknown [IPV6:2001:250:6801:5501:163d:f2ff:fecb:5632]) by mail-m17638.qiye.163.com (Hmail) with ESMTPA id 5C89C1C0243; Sun, 8 May 2022 23:25:27 +0800 (CST) From: Chukun Pan To: Jernej Skrabec Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Chukun Pan Subject: Re: Re: [PATCH] arm64: dts: allwinner: define USB3 Ethernet on NanoPi R1S H5 Date: Sun, 8 May 2022 23:25:05 +0800 Message-Id: <20220508152505.7762-1-amadeus@jmu.edu.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <4393725.LvFx2qVVIh@kista> References: <4393725.LvFx2qVVIh@kista> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUhPN1dZLVlBSVdZDwkaFQgSH1lBWUJOQkNWS0JITEsdH08aQh oaVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWU9LSFVKSktISkNVS1kG X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6OTY6DQw5UT04KgwZGkICOT86 EAMaCjpVSlVKTU5JS0lITklMTE5LVTMWGhIXVRoWGh8eDgg7ERYOVR4fDlUYFUVZV1kSC1lBWUlL S0pBSU5LQU1DS0pBTk5LSkFKTUgfQR1JHR1BHR4YGUFOTUhJWVdZCAFZQUpMSE03Bg++ X-HM-Tid: 0a80a4468858d993kuws5c89c1c0243 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts > > @@ -21,7 +21,8 @@ / { > > > > aliases { > > ethernet0 = &emac; > > - ethernet1 = &rtl8189etv; > > + ethernet1 = &rtl8153; > > + ethernet2 = &rtl8189etv; > Additionally, it's not a good idea to change order of ethernet nodes. It can > affect mac address assigning procedure in bootloader. There is no eth1addr in uboot, so this doesn't affect the mac address. The network order in the kernel is eth0(emac) / eth1(rtl8153) / wlan0, so I think it would be better to change it this way. Thanks, Chukun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73117C433F5 for ; Sun, 8 May 2022 15:26:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=H5IlcqC3pYUSAM2+lkgpRWS43xWKDLvRrsKcLbrsjyA=; b=YlqD1CzXKDw6iL 7oexc11wvI3TiO1RSLcl3sSIof/CunfPM+/fkTDrvnzG9HmGsDrgU/Le+VIsl3Q5oevjnsZmM2HwW 09ShNkU7DJ15oIDRXRoc++5sWtSmU3IHigTnYKbYLuj0OxUQMZ4uPb9qaSC9jpnKLvOCf/XfD/iTq bHOe2pILGGl+jY2cewGd4g4Hdsv1uk41DXkgg4PKYjFT/LT51gvO5YKqJPi57Oj3EnTubWcizX6sL YMYGspULWIXkMynVteE/LYq6Ax2X9TQbIKyn5Oi+EBy4yFsfx1Lw9oA7gAkFBpuNbZj9gIsD/bMGs hCXtHHyzBCwzR5+yaa+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nnimw-00AUPC-HC; Sun, 08 May 2022 15:25:38 +0000 Received: from mail-m17638.qiye.163.com ([59.111.176.38]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nnimr-00AUN1-R3 for linux-arm-kernel@lists.infradead.org; Sun, 08 May 2022 15:25:36 +0000 Received: from localhost.localdomain (unknown [IPV6:2001:250:6801:5501:163d:f2ff:fecb:5632]) by mail-m17638.qiye.163.com (Hmail) with ESMTPA id 5C89C1C0243; Sun, 8 May 2022 23:25:27 +0800 (CST) From: Chukun Pan To: Jernej Skrabec Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Chukun Pan Subject: Re: Re: [PATCH] arm64: dts: allwinner: define USB3 Ethernet on NanoPi R1S H5 Date: Sun, 8 May 2022 23:25:05 +0800 Message-Id: <20220508152505.7762-1-amadeus@jmu.edu.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <4393725.LvFx2qVVIh@kista> References: <4393725.LvFx2qVVIh@kista> MIME-Version: 1.0 X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUhPN1dZLVlBSVdZDwkaFQgSH1lBWUJOQkNWS0JITEsdH08aQh oaVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWU9LSFVKSktISkNVS1kG X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6OTY6DQw5UT04KgwZGkICOT86 EAMaCjpVSlVKTU5JS0lITklMTE5LVTMWGhIXVRoWGh8eDgg7ERYOVR4fDlUYFUVZV1kSC1lBWUlL S0pBSU5LQU1DS0pBTk5LSkFKTUgfQR1JHR1BHR4YGUFOTUhJWVdZCAFZQUpMSE03Bg++ X-HM-Tid: 0a80a4468858d993kuws5c89c1c0243 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220508_082534_597931_337BD634 X-CRM114-Status: GOOD ( 10.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts > > @@ -21,7 +21,8 @@ / { > > > > aliases { > > ethernet0 = &emac; > > - ethernet1 = &rtl8189etv; > > + ethernet1 = &rtl8153; > > + ethernet2 = &rtl8189etv; > Additionally, it's not a good idea to change order of ethernet nodes. It can > affect mac address assigning procedure in bootloader. There is no eth1addr in uboot, so this doesn't affect the mac address. The network order in the kernel is eth0(emac) / eth1(rtl8153) / wlan0, so I think it would be better to change it this way. Thanks, Chukun _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel