From: Francesco Dolcini <francesco.dolcini@toradex.com>
To: Marek Vasut <marex@denx.de>, Adam Ford <aford173@gmail.com>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
Tim Harvey <tharvey@gateworks.com>,
andrejs.cainikovs@toradex.com,
Francesco Dolcini <francesco.dolcini@toradex.com>,
Stefano Babic <sbabic@denx.de>,
Fabio Estevam <festevam@gmail.com>,
"NXP i.MX U-Boot Team" <uboot-imx@nxp.com>,
Peng Fan <peng.fan@nxp.com>, Ye Li <ye.li@nxp.com>,
Frieder Schrempf <frieder.schrempf@kontron.de>,
Ricardo Salveti <ricardo@foundries.io>,
Michael Trimarchi <michael@amarulasolutions.com>
Subject: Re: [PATCH V2] ARM: imx: imx8m: Adjust thermal trip points for Industrial parts
Date: Sun, 8 May 2022 18:55:52 +0200 [thread overview]
Message-ID: <20220508165552.GA5046@francesco-nb.int.toradex.com> (raw)
In-Reply-To: <af5ae3b1-8f81-3039-e27f-54c31966508f@denx.de>
On Sun, May 08, 2022 at 03:42:31PM +0200, Marek Vasut wrote:
> On 5/8/22 04:59, Adam Ford wrote:
> > On Sat, May 7, 2022 at 5:00 PM Marek Vasut <marex@denx.de> wrote:
> > >
> > > On 5/7/22 14:04, Adam Ford wrote:
> > > > If the thermal sensor is enabled in U-Boot, adjust the cpu-thermal
> > > > trip points for industrial rated parts. This should apply to 8MQ,
> > > > 8MM, 8MN, and 8MP.
> > > >
> > > > Signed-off-by: Adam Ford <aford173@gmail.com>
> > > > Reviewed-by: Tim Harvey <tharvey@gateworks.com>
> > > > ---
> > > > V2: Switch the check from looking for industrial or checkoing for
> > > > anything but commerical. This expands the trip point updates
> > > > other grades as well.
> > >
> > > Are the industrial and automotive trip points identical ?
> >
> > I do not know nor do I have any to test, but Francisco asked for the
> > change. I would expect the corresponding values would be fetched with
> > get_cpu_temp_grade()
>
> Ah, I see. But then I have to wonder, why are we updating only
> non-commercial trip points ? Why not update them always ?
I didn't think through it enough, I agree on updating the trip points
always.
Francesco
next prev parent reply other threads:[~2022-05-08 16:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-07 12:04 [PATCH V2] ARM: imx: imx8m: Adjust thermal trip points for Industrial parts Adam Ford
2022-05-07 22:00 ` Marek Vasut
2022-05-08 2:59 ` Adam Ford
2022-05-08 13:42 ` Marek Vasut
2022-05-08 16:55 ` Francesco Dolcini [this message]
2022-05-09 7:38 ` Andrejs Cainikovs
2022-05-12 10:12 ` Andrejs Cainikovs
2022-05-12 10:12 ` [PATCH] imx8m: fixup thermal trips Andrejs Cainikovs
2022-05-25 11:41 ` Adam Ford
2022-05-25 12:19 ` Andrejs Cainikovs
2022-05-25 12:21 ` Adam Ford
2022-05-25 12:24 ` Andrejs Cainikovs
2022-05-25 12:26 ` Adam Ford
2022-05-25 12:28 ` Andrejs Cainikovs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220508165552.GA5046@francesco-nb.int.toradex.com \
--to=francesco.dolcini@toradex.com \
--cc=aford173@gmail.com \
--cc=andrejs.cainikovs@toradex.com \
--cc=festevam@gmail.com \
--cc=frieder.schrempf@kontron.de \
--cc=marex@denx.de \
--cc=michael@amarulasolutions.com \
--cc=peng.fan@nxp.com \
--cc=ricardo@foundries.io \
--cc=sbabic@denx.de \
--cc=tharvey@gateworks.com \
--cc=u-boot@lists.denx.de \
--cc=uboot-imx@nxp.com \
--cc=ye.li@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.