* [PATCH] drm/amdgpu/vcn: fixed no previous prototype warning.
@ 2022-05-08 17:30 James Zhu
2022-05-08 18:00 ` James Zhu
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: James Zhu @ 2022-05-08 17:30 UTC (permalink / raw)
To: amd-gfx; +Cc: kernel test robot
Fixed warning: no previous prototype for 'vcn_dec_sw_ring_emit_fence'
Signed-off-by: James Zhu <James.Zhu@amd.com>
Reported-by: kernel test robot <lkp@intel.com>
---
drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c b/drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c
index 08fd61622f95..1ceda3d0cd5b 100644
--- a/drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c
+++ b/drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c
@@ -21,7 +21,8 @@
*
*/
-#include "amdgpu_vcn.h"
+#include "amdgpu.h"
+#include "vcn_sw_ring.h"
void vcn_dec_sw_ring_emit_fence(struct amdgpu_ring *ring, u64 addr,
u64 seq, uint32_t flags)
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] drm/amdgpu/vcn: fixed no previous prototype warning.
2022-05-08 17:30 [PATCH] drm/amdgpu/vcn: fixed no previous prototype warning James Zhu
@ 2022-05-08 18:00 ` James Zhu
2022-05-09 11:46 ` Paul Menzel
2022-05-09 6:58 ` Christian König
2022-05-09 18:19 ` [PATCH v3] drm/amdgpu/vcn: include header for vcn_dec_sw_ring_emit_fence James Zhu
2 siblings, 1 reply; 6+ messages in thread
From: James Zhu @ 2022-05-08 18:00 UTC (permalink / raw)
To: amd-gfx; +Cc: kernel test robot
Fixed warning: no previous prototype for 'vcn_dec_sw_ring_emit_fence'
Signed-off-by: James Zhu <James.Zhu@amd.com>
Reported-by: kernel test robot <lkp@intel.com>
---
drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c b/drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c
index f4f97f0f5c64..1ceda3d0cd5b 100644
--- a/drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c
+++ b/drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c
@@ -22,6 +22,7 @@
*/
#include "amdgpu.h"
+#include "vcn_sw_ring.h"
void vcn_dec_sw_ring_emit_fence(struct amdgpu_ring *ring, u64 addr,
u64 seq, uint32_t flags)
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amdgpu/vcn: fixed no previous prototype warning.
2022-05-08 17:30 [PATCH] drm/amdgpu/vcn: fixed no previous prototype warning James Zhu
2022-05-08 18:00 ` James Zhu
@ 2022-05-09 6:58 ` Christian König
2022-05-09 18:19 ` [PATCH v3] drm/amdgpu/vcn: include header for vcn_dec_sw_ring_emit_fence James Zhu
2 siblings, 0 replies; 6+ messages in thread
From: Christian König @ 2022-05-09 6:58 UTC (permalink / raw)
To: James Zhu, amd-gfx; +Cc: kernel test robot
Am 08.05.22 um 19:30 schrieb James Zhu:
> Fixed warning: no previous prototype for 'vcn_dec_sw_ring_emit_fence'
>
> Signed-off-by: James Zhu <James.Zhu@amd.com>
> Reported-by: kernel test robot <lkp@intel.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c b/drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c
> index 08fd61622f95..1ceda3d0cd5b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c
> +++ b/drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c
> @@ -21,7 +21,8 @@
> *
> */
>
> -#include "amdgpu_vcn.h"
> +#include "amdgpu.h"
> +#include "vcn_sw_ring.h"
>
> void vcn_dec_sw_ring_emit_fence(struct amdgpu_ring *ring, u64 addr,
> u64 seq, uint32_t flags)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amdgpu/vcn: fixed no previous prototype warning.
2022-05-08 18:00 ` James Zhu
@ 2022-05-09 11:46 ` Paul Menzel
0 siblings, 0 replies; 6+ messages in thread
From: Paul Menzel @ 2022-05-09 11:46 UTC (permalink / raw)
To: James Zhu; +Cc: kernel test robot, amd-gfx
Dear James,
You sent this message 30 minutes after sending the same message before
(Message-ID: <20220508173008.281673-1-James.Zhu@amd.com>). Are there any
differences?
Am 08.05.22 um 20:00 schrieb James Zhu:
> Fixed warning: no previous prototype for 'vcn_dec_sw_ring_emit_fence'
Please use imperative mood in the commit message summary. Maybe even:
> Include header for `vcn_dec_sw_ring_emit_fence()`
Also, please do not add a dot/period to the end of commit messages.
Kind regards,
Paul
> Signed-off-by: James Zhu <James.Zhu@amd.com>
> Reported-by: kernel test robot <lkp@intel.com>
> ---
> drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c b/drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c
> index f4f97f0f5c64..1ceda3d0cd5b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c
> +++ b/drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c
> @@ -22,6 +22,7 @@
> */
>
> #include "amdgpu.h"
> +#include "vcn_sw_ring.h"
>
> void vcn_dec_sw_ring_emit_fence(struct amdgpu_ring *ring, u64 addr,
> u64 seq, uint32_t flags)
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v3] drm/amdgpu/vcn: include header for vcn_dec_sw_ring_emit_fence
2022-05-08 17:30 [PATCH] drm/amdgpu/vcn: fixed no previous prototype warning James Zhu
2022-05-08 18:00 ` James Zhu
2022-05-09 6:58 ` Christian König
@ 2022-05-09 18:19 ` James Zhu
2022-05-09 18:20 ` Alex Deucher
2 siblings, 1 reply; 6+ messages in thread
From: James Zhu @ 2022-05-09 18:19 UTC (permalink / raw)
To: amd-gfx; +Cc: pmenzel, kernel test robot
Fixed warning: no previous prototype for 'vcn_dec_sw_ring_emit_fence'.
v2: regenerate patch after git rebase.
v3: update commit message.
Signed-off-by: James Zhu <James.Zhu@amd.com>
Reported-by: kernel test robot <lkp@intel.com>
---
drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c b/drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c
index f4f97f0f5c64..1ceda3d0cd5b 100644
--- a/drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c
+++ b/drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c
@@ -22,6 +22,7 @@
*/
#include "amdgpu.h"
+#include "vcn_sw_ring.h"
void vcn_dec_sw_ring_emit_fence(struct amdgpu_ring *ring, u64 addr,
u64 seq, uint32_t flags)
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v3] drm/amdgpu/vcn: include header for vcn_dec_sw_ring_emit_fence
2022-05-09 18:19 ` [PATCH v3] drm/amdgpu/vcn: include header for vcn_dec_sw_ring_emit_fence James Zhu
@ 2022-05-09 18:20 ` Alex Deucher
0 siblings, 0 replies; 6+ messages in thread
From: Alex Deucher @ 2022-05-09 18:20 UTC (permalink / raw)
To: James Zhu; +Cc: Paul Menzel, kernel test robot, amd-gfx list
On Mon, May 9, 2022 at 2:19 PM James Zhu <James.Zhu@amd.com> wrote:
>
> Fixed warning: no previous prototype for 'vcn_dec_sw_ring_emit_fence'.
>
> v2: regenerate patch after git rebase.
> v3: update commit message.
>
> Signed-off-by: James Zhu <James.Zhu@amd.com>
> Reported-by: kernel test robot <lkp@intel.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c b/drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c
> index f4f97f0f5c64..1ceda3d0cd5b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c
> +++ b/drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c
> @@ -22,6 +22,7 @@
> */
>
> #include "amdgpu.h"
> +#include "vcn_sw_ring.h"
>
> void vcn_dec_sw_ring_emit_fence(struct amdgpu_ring *ring, u64 addr,
> u64 seq, uint32_t flags)
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-05-09 18:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-08 17:30 [PATCH] drm/amdgpu/vcn: fixed no previous prototype warning James Zhu
2022-05-08 18:00 ` James Zhu
2022-05-09 11:46 ` Paul Menzel
2022-05-09 6:58 ` Christian König
2022-05-09 18:19 ` [PATCH v3] drm/amdgpu/vcn: include header for vcn_dec_sw_ring_emit_fence James Zhu
2022-05-09 18:20 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.