All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: sound/soc/qcom/sc7180.c:163 sc7180_snd_startup() error: uninitialized symbol 'pll_id'.
Date: Sun, 08 May 2022 22:34:13 +0800	[thread overview]
Message-ID: <202205082224.48VUvLc2-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 6172 bytes --]

CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: lvzhaoxiong <lvzhaoxiong@huaqin.corp-partner.google.com>
CC: Mark Brown <broonie@kernel.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   30c8e80f79329617012f07b09b70114592092ea4
commit: 425c5fce8a03c9da70a4c763cd7db22fbb422dcf ASoC: qcom: Add support for ALC5682I-VS codec
date:   5 months ago
:::::: branch date: 21 hours ago
:::::: commit date: 5 months ago
config: openrisc-randconfig-m031-20220506 (https://download.01.org/0day-ci/archive/20220508/202205082224.48VUvLc2-lkp(a)intel.com/config)
compiler: or1k-linux-gcc (GCC) 11.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
sound/soc/qcom/sc7180.c:163 sc7180_snd_startup() error: uninitialized symbol 'pll_id'.
sound/soc/qcom/sc7180.c:163 sc7180_snd_startup() error: uninitialized symbol 'pll_source'.
sound/soc/qcom/sc7180.c:164 sc7180_snd_startup() error: uninitialized symbol 'pll_in'.
sound/soc/qcom/sc7180.c:164 sc7180_snd_startup() error: uninitialized symbol 'pll_out'.
sound/soc/qcom/sc7180.c:171 sc7180_snd_startup() error: uninitialized symbol 'clk_id'.

vim +/pll_id +163 sound/soc/qcom/sc7180.c

9e3ecb5b16818a Ajit Pandey 2020-10-27  124  
9e3ecb5b16818a Ajit Pandey 2020-10-27  125  static int sc7180_snd_startup(struct snd_pcm_substream *substream)
9e3ecb5b16818a Ajit Pandey 2020-10-27  126  {
9e3ecb5b16818a Ajit Pandey 2020-10-27  127  	struct snd_soc_pcm_runtime *rtd = substream->private_data;
9e3ecb5b16818a Ajit Pandey 2020-10-27  128  	struct snd_soc_card *card = rtd->card;
9e3ecb5b16818a Ajit Pandey 2020-10-27  129  	struct sc7180_snd_data *data = snd_soc_card_get_drvdata(card);
9e3ecb5b16818a Ajit Pandey 2020-10-27  130  	struct snd_soc_dai *cpu_dai = asoc_rtd_to_cpu(rtd, 0);
9e3ecb5b16818a Ajit Pandey 2020-10-27  131  	struct snd_soc_dai *codec_dai = asoc_rtd_to_codec(rtd, 0);
425c5fce8a03c9 lvzhaoxiong 2021-11-23  132  	int pll_id, pll_source, pll_in, pll_out, clk_id, ret;
425c5fce8a03c9 lvzhaoxiong 2021-11-23  133  
425c5fce8a03c9 lvzhaoxiong 2021-11-23  134  	if (!(strcmp(card->name, "sc7180-rt5682-max98357a-1mic"))) {
425c5fce8a03c9 lvzhaoxiong 2021-11-23  135  		pll_source = RT5682_PLL1_S_MCLK;
425c5fce8a03c9 lvzhaoxiong 2021-11-23  136  		pll_id = 0;
425c5fce8a03c9 lvzhaoxiong 2021-11-23  137  		clk_id = RT5682_SCLK_S_PLL1;
425c5fce8a03c9 lvzhaoxiong 2021-11-23  138  		pll_out = RT5682_PLL1_FREQ;
425c5fce8a03c9 lvzhaoxiong 2021-11-23  139  		pll_in = DEFAULT_MCLK_RATE;
425c5fce8a03c9 lvzhaoxiong 2021-11-23  140  	} else if (!(strcmp(card->name, "sc7180-rt5682s-max98357a-1mic"))) {
425c5fce8a03c9 lvzhaoxiong 2021-11-23  141  		pll_source = RT5682S_PLL_S_MCLK;
425c5fce8a03c9 lvzhaoxiong 2021-11-23  142  		pll_id = RT5682S_PLL2;
425c5fce8a03c9 lvzhaoxiong 2021-11-23  143  		clk_id = RT5682S_SCLK_S_PLL2;
425c5fce8a03c9 lvzhaoxiong 2021-11-23  144  		pll_out = RT5682_PLL1_FREQ;
425c5fce8a03c9 lvzhaoxiong 2021-11-23  145  		pll_in = DEFAULT_MCLK_RATE;
425c5fce8a03c9 lvzhaoxiong 2021-11-23  146  	}
9e3ecb5b16818a Ajit Pandey 2020-10-27  147  
9e3ecb5b16818a Ajit Pandey 2020-10-27  148  	switch (cpu_dai->id) {
9e3ecb5b16818a Ajit Pandey 2020-10-27  149  	case MI2S_PRIMARY:
9e3ecb5b16818a Ajit Pandey 2020-10-27  150  		if (++data->pri_mi2s_clk_count == 1) {
9e3ecb5b16818a Ajit Pandey 2020-10-27  151  			snd_soc_dai_set_sysclk(cpu_dai,
9e3ecb5b16818a Ajit Pandey 2020-10-27  152  					       LPASS_MCLK0,
9e3ecb5b16818a Ajit Pandey 2020-10-27  153  					       DEFAULT_MCLK_RATE,
9e3ecb5b16818a Ajit Pandey 2020-10-27  154  					       SNDRV_PCM_STREAM_PLAYBACK);
9e3ecb5b16818a Ajit Pandey 2020-10-27  155  		}
9e3ecb5b16818a Ajit Pandey 2020-10-27  156  
9e3ecb5b16818a Ajit Pandey 2020-10-27  157  		snd_soc_dai_set_fmt(codec_dai,
9e3ecb5b16818a Ajit Pandey 2020-10-27  158  				    SND_SOC_DAIFMT_CBS_CFS |
9e3ecb5b16818a Ajit Pandey 2020-10-27  159  				    SND_SOC_DAIFMT_NB_NF |
9e3ecb5b16818a Ajit Pandey 2020-10-27  160  				    SND_SOC_DAIFMT_I2S);
9e3ecb5b16818a Ajit Pandey 2020-10-27  161  
9e3ecb5b16818a Ajit Pandey 2020-10-27  162  		/* Configure PLL1 for codec */
425c5fce8a03c9 lvzhaoxiong 2021-11-23 @163  		ret = snd_soc_dai_set_pll(codec_dai, pll_id, pll_source,
425c5fce8a03c9 lvzhaoxiong 2021-11-23 @164  					  pll_in, pll_out);
9e3ecb5b16818a Ajit Pandey 2020-10-27  165  		if (ret) {
9e3ecb5b16818a Ajit Pandey 2020-10-27  166  			dev_err(rtd->dev, "can't set codec pll: %d\n", ret);
9e3ecb5b16818a Ajit Pandey 2020-10-27  167  			return ret;
9e3ecb5b16818a Ajit Pandey 2020-10-27  168  		}
9e3ecb5b16818a Ajit Pandey 2020-10-27  169  
9e3ecb5b16818a Ajit Pandey 2020-10-27  170  		/* Configure sysclk for codec */
425c5fce8a03c9 lvzhaoxiong 2021-11-23 @171  		ret = snd_soc_dai_set_sysclk(codec_dai, clk_id, pll_out,
9e3ecb5b16818a Ajit Pandey 2020-10-27  172  					     SND_SOC_CLOCK_IN);
9e3ecb5b16818a Ajit Pandey 2020-10-27  173  		if (ret)
9e3ecb5b16818a Ajit Pandey 2020-10-27  174  			dev_err(rtd->dev, "snd_soc_dai_set_sysclk err = %d\n",
9e3ecb5b16818a Ajit Pandey 2020-10-27  175  				ret);
9e3ecb5b16818a Ajit Pandey 2020-10-27  176  
9e3ecb5b16818a Ajit Pandey 2020-10-27  177  		break;
9e3ecb5b16818a Ajit Pandey 2020-10-27  178  	case MI2S_SECONDARY:
9e3ecb5b16818a Ajit Pandey 2020-10-27  179  		break;
9e3ecb5b16818a Ajit Pandey 2020-10-27  180  	case LPASS_DP_RX:
9e3ecb5b16818a Ajit Pandey 2020-10-27  181  		break;
9e3ecb5b16818a Ajit Pandey 2020-10-27  182  	default:
9e3ecb5b16818a Ajit Pandey 2020-10-27  183  		dev_err(rtd->dev, "%s: invalid dai id 0x%x\n", __func__,
9e3ecb5b16818a Ajit Pandey 2020-10-27  184  			cpu_dai->id);
9e3ecb5b16818a Ajit Pandey 2020-10-27  185  		return -EINVAL;
9e3ecb5b16818a Ajit Pandey 2020-10-27  186  	}
9e3ecb5b16818a Ajit Pandey 2020-10-27  187  	return 0;
9e3ecb5b16818a Ajit Pandey 2020-10-27  188  }
9e3ecb5b16818a Ajit Pandey 2020-10-27  189  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

             reply	other threads:[~2022-05-08 14:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-08 14:34 kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-07-26 11:31 sound/soc/qcom/sc7180.c:163 sc7180_snd_startup() error: uninitialized symbol 'pll_id' kernel test robot
2022-03-15  4:08 kernel test robot
2022-01-19  5:13 Dan Carpenter
2022-01-18 11:13 ` kernel test robot
2022-01-19  5:13 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202205082224.48VUvLc2-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.