From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 031B0C433F5 for ; Mon, 9 May 2022 05:18:08 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E5D7683AE1; Mon, 9 May 2022 07:18:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="XlBFm19b"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BF31E83B32; Mon, 9 May 2022 07:18:05 +0200 (CEST) Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DB26D801F5 for ; Mon, 9 May 2022 07:18:01 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pj1-x102f.google.com with SMTP id fv2so12135400pjb.4 for ; Sun, 08 May 2022 22:18:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=neAF6PcFI+8/G8sVXuIEeJn5+oI7FeIlHpLVxkrHsnc=; b=XlBFm19bSN3Aex9AbT5FQ8+DKQ2uh0DKl2WFIXX+Hqa3I6ZlZ2uKzJ5C6thjm7RMRp q1qlsCXhUvXAWl6K+nYUwTU6ZeoKDj7Wo6IrkYmv11rt1N7DyqHp+6kUrOO2KBEuYWeZ ZZj3WyiZudcZrZ4/QR9lI/jcaBpMO6dcJFaZ+/yVVsiirJqHKOoeWKFnLFAaTfBYZQqx JU00h4/ymp4sIQ6hRRgdNppaW9TBTBUiMUDQhTVDH2My/mZ+xmeFMA0Y3c3CjFKSY+e7 S3XfkS1xHLRpbQRlo0ybkn65cMyvSxMMGHOTwVf/YMonSpxhZjzo0SHmn0msT53tznjm bn4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=neAF6PcFI+8/G8sVXuIEeJn5+oI7FeIlHpLVxkrHsnc=; b=5CxYL5vPzjzJ8dFZvScUGPr/dFB+AiG0IzL+ge3ozLhZzVca8CgEFeG0ObZ9Bn1JCm 8GuVzZzDfNajolIkJpe2fJKeapXH3JmyzM0gxZiZ2XBhN9ofkIFwYp+LMzmrqdPc4ksR VI5wGDMV71Ewin+sezHWhu3ZSxOZQTcMl/Nm4nWjX43CkMXcnxvpTxkcLYYHceddwgfx w0oIylkZmWuVb+7ThiN/9QpGliq8K0sybpcRSqxpanUjAmNNgXQ6vUtmrBusU2provqL WlmLI7cAnFlwX2CCCHfMtWRt18tsiIfmW6G5H6LOuCifNg3i1zmzl9dB14zOVfvKgnHt WCkQ== X-Gm-Message-State: AOAM533XfcCDLv9hSShGJA1Ty6PuLuUynI0NFDVcq5iBdVr9YGc7XVBN P+9IfjHbF/4gRN3D9F1nJDYyLeugML3Ykg== X-Google-Smtp-Source: ABdhPJygpa9J5mXCoN951EW0KYs/ZCJMw5+PIUWykJF2gNR6UvsztMq2hnikWoZ+UgADVPLfZCAaFw== X-Received: by 2002:a17:903:240f:b0:156:8e81:a0a3 with SMTP id e15-20020a170903240f00b001568e81a0a3mr14516638plo.13.1652073480259; Sun, 08 May 2022 22:18:00 -0700 (PDT) Received: from laputa ([2400:4050:c3e1:100:61c9:1f8:7f1b:d632]) by smtp.gmail.com with ESMTPSA id ob12-20020a17090b390c00b001d95c09f877sm7774093pjb.35.2022.05.08.22.17.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 May 2022 22:17:59 -0700 (PDT) Date: Mon, 9 May 2022 14:17:56 +0900 From: AKASHI Takahiro To: Heinrich Schuchardt Cc: u-boot@lists.denx.de Subject: Re: [PATCH 1/1] test: fix some pylint problems in test_capsule_firmware_raw.py Message-ID: <20220509051756.GB34398@laputa> Mail-Followup-To: AKASHI Takahiro , Heinrich Schuchardt , u-boot@lists.denx.de References: <20220430135541.60784-1-heinrich.schuchardt@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220430135541.60784-1-heinrich.schuchardt@canonical.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Sat, Apr 30, 2022 at 03:55:41PM +0200, Heinrich Schuchardt wrote: > * improve doc-string formatting > * remove unused imports Similar changes should be applied to test_capsule_firmware_fit.py and test_capsule_firmware_signed.py as well. -Takahiro Akashi > Signed-off-by: Heinrich Schuchardt > --- > .../test_capsule_firmware_raw.py | 42 +++++++++---------- > 1 file changed, 20 insertions(+), 22 deletions(-) > > diff --git a/test/py/tests/test_efi_capsule/test_capsule_firmware_raw.py b/test/py/tests/test_efi_capsule/test_capsule_firmware_raw.py > index ae99f080ff..c8c647d0b1 100644 > --- a/test/py/tests/test_efi_capsule/test_capsule_firmware_raw.py > +++ b/test/py/tests/test_efi_capsule/test_capsule_firmware_raw.py > @@ -1,17 +1,13 @@ > # SPDX-License-Identifier: GPL-2.0+ > # Copyright (c) 2020, Linaro Limited > # Author: AKASHI Takahiro > -# > -# U-Boot UEFI: Firmware Update Test > > -""" > +""" U-Boot UEFI: Firmware Update Test > This test verifies capsule-on-disk firmware update for raw images > """ > > -from subprocess import check_call, check_output, CalledProcessError > import pytest > -from capsule_defs import * > - > +from capsule_defs import CAPSULE_DATA_DIR, CAPSULE_INSTALL_DIR > > @pytest.mark.boardspec('sandbox') > @pytest.mark.buildconfigspec('efi_capsule_firmware_raw') > @@ -24,15 +20,18 @@ from capsule_defs import * > @pytest.mark.buildconfigspec('cmd_nvedit_efi') > @pytest.mark.buildconfigspec('cmd_sf') > @pytest.mark.slow > -class TestEfiCapsuleFirmwareRaw(object): > +class TestEfiCapsuleFirmwareRaw: > + """ Tests verifying capsule-on-disk firmware update for raw images > + """ > + > def test_efi_capsule_fw1( > self, u_boot_config, u_boot_console, efi_capsule_data): > - """ > - Test Case 1 - Update U-Boot and U-Boot environment on SPI Flash > - but with an incorrect GUID value in the capsule > - No update should happen > - 0x100000-0x150000: U-Boot binary (but dummy) > - 0x150000-0x200000: U-Boot environment (but dummy) > + """ Test Case 1 > + Update U-Boot and U-Boot environment on SPI Flash > + but with an incorrect GUID value in the capsule > + No update should happen > + 0x100000-0x150000: U-Boot binary (but dummy) > + 0x150000-0x200000: U-Boot environment (but dummy) > """ > > # other tests might have run and the > @@ -106,12 +105,11 @@ class TestEfiCapsuleFirmwareRaw(object): > > def test_efi_capsule_fw2( > self, u_boot_config, u_boot_console, efi_capsule_data): > - """ > - Test Case 2 - Update U-Boot and U-Boot environment on SPI Flash > - but with OsIndications unset > - No update should happen > - 0x100000-0x150000: U-Boot binary (but dummy) > - 0x150000-0x200000: U-Boot environment (but dummy) > + """ Test Case 2 > + Update U-Boot and U-Boot environment on SPI Flash but with OsIndications unset > + No update should happen > + 0x100000-0x150000: U-Boot binary (but dummy) > + 0x150000-0x200000: U-Boot environment (but dummy) > """ > disk_img = efi_capsule_data > with u_boot_console.log.section('Test Case 2-a, before reboot'): > @@ -191,9 +189,9 @@ class TestEfiCapsuleFirmwareRaw(object): > > def test_efi_capsule_fw3( > self, u_boot_config, u_boot_console, efi_capsule_data): > - """ > - Test Case 3 - Update U-Boot on SPI Flash, raw image format > - 0x100000-0x150000: U-Boot binary (but dummy) > + """ Test Case 3 > + Update U-Boot on SPI Flash, raw image format > + 0x100000-0x150000: U-Boot binary (but dummy) > """ > disk_img = efi_capsule_data > with u_boot_console.log.section('Test Case 3-a, before reboot'): > -- > 2.34.1 >