All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [PATCH v2 07/26] block: add missing coroutine_fn annotations
Date: Mon,  9 May 2022 12:30:00 +0200	[thread overview]
Message-ID: <20220509103019.215041-8-pbonzini@redhat.com> (raw)
In-Reply-To: <20220509103019.215041-1-pbonzini@redhat.com>

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 block/block-backend.c | 18 +++++++++---------
 block/io.c            | 24 ++++++++++++------------
 2 files changed, 21 insertions(+), 21 deletions(-)

diff --git a/block/block-backend.c b/block/block-backend.c
index fedf2eca83..52009b8949 100644
--- a/block/block-backend.c
+++ b/block/block-backend.c
@@ -1413,8 +1413,8 @@ typedef struct BlkRwCo {
     BdrvRequestFlags flags;
 } BlkRwCo;
 
-int blk_pwrite_zeroes(BlockBackend *blk, int64_t offset,
-                      int64_t bytes, BdrvRequestFlags flags)
+int coroutine_fn blk_pwrite_zeroes(BlockBackend *blk, int64_t offset,
+                                   int64_t bytes, BdrvRequestFlags flags)
 {
     IO_OR_GS_CODE();
     return blk_pwritev_part(blk, offset, bytes, NULL, 0,
@@ -1534,7 +1534,7 @@ static BlockAIOCB *blk_aio_prwv(BlockBackend *blk, int64_t offset,
     return &acb->common;
 }
 
-static void blk_aio_read_entry(void *opaque)
+static void coroutine_fn blk_aio_read_entry(void *opaque)
 {
     BlkAioEmAIOCB *acb = opaque;
     BlkRwCo *rwco = &acb->rwco;
@@ -1546,7 +1546,7 @@ static void blk_aio_read_entry(void *opaque)
     blk_aio_complete(acb);
 }
 
-static void blk_aio_write_entry(void *opaque)
+static void coroutine_fn blk_aio_write_entry(void *opaque)
 {
     BlkAioEmAIOCB *acb = opaque;
     BlkRwCo *rwco = &acb->rwco;
@@ -1580,8 +1580,8 @@ int blk_pread(BlockBackend *blk, int64_t offset, void *buf, int bytes)
     return ret < 0 ? ret : bytes;
 }
 
-int blk_pwrite(BlockBackend *blk, int64_t offset, const void *buf, int bytes,
-               BdrvRequestFlags flags)
+int coroutine_fn blk_pwrite(BlockBackend *blk, int64_t offset, const void *buf, int bytes,
+                            BdrvRequestFlags flags)
 {
     int ret;
     QEMUIOVector qiov = QEMU_IOVEC_INIT_BUF(qiov, buf, bytes);
@@ -1681,7 +1681,7 @@ int blk_ioctl(BlockBackend *blk, unsigned long int req, void *buf)
     return ret;
 }
 
-static void blk_aio_ioctl_entry(void *opaque)
+static void coroutine_fn blk_aio_ioctl_entry(void *opaque)
 {
     BlkAioEmAIOCB *acb = opaque;
     BlkRwCo *rwco = &acb->rwco;
@@ -1715,7 +1715,7 @@ blk_co_do_pdiscard(BlockBackend *blk, int64_t offset, int64_t bytes)
     return bdrv_co_pdiscard(blk->root, offset, bytes);
 }
 
-static void blk_aio_pdiscard_entry(void *opaque)
+static void coroutine_fn blk_aio_pdiscard_entry(void *opaque)
 {
     BlkAioEmAIOCB *acb = opaque;
     BlkRwCo *rwco = &acb->rwco;
@@ -1771,7 +1771,7 @@ int coroutine_fn blk_co_do_flush(BlockBackend *blk)
     return bdrv_co_flush(blk_bs(blk));
 }
 
-static void blk_aio_flush_entry(void *opaque)
+static void coroutine_fn blk_aio_flush_entry(void *opaque)
 {
     BlkAioEmAIOCB *acb = opaque;
     BlkRwCo *rwco = &acb->rwco;
diff --git a/block/io.c b/block/io.c
index 9769ec53b0..7db9be3c03 100644
--- a/block/io.c
+++ b/block/io.c
@@ -751,7 +751,7 @@ void bdrv_drain_all(void)
  *
  * This function should be called when a tracked request is completing.
  */
-static void tracked_request_end(BdrvTrackedRequest *req)
+static void coroutine_fn tracked_request_end(BdrvTrackedRequest *req)
 {
     if (req->serialising) {
         qatomic_dec(&req->bs->serialising_in_flight);
@@ -766,11 +766,11 @@ static void tracked_request_end(BdrvTrackedRequest *req)
 /**
  * Add an active request to the tracked requests list
  */
-static void tracked_request_begin(BdrvTrackedRequest *req,
-                                  BlockDriverState *bs,
-                                  int64_t offset,
-                                  int64_t bytes,
-                                  enum BdrvTrackedRequestType type)
+static void coroutine_fn tracked_request_begin(BdrvTrackedRequest *req,
+                                               BlockDriverState *bs,
+                                               int64_t offset,
+                                               int64_t bytes,
+                                               enum BdrvTrackedRequestType type)
 {
     bdrv_check_request(offset, bytes, &error_abort);
 
@@ -809,7 +809,7 @@ static bool tracked_request_overlaps(BdrvTrackedRequest *req,
 }
 
 /* Called with self->bs->reqs_lock held */
-static BdrvTrackedRequest *
+static coroutine_fn BdrvTrackedRequest *
 bdrv_find_conflicting_request(BdrvTrackedRequest *self)
 {
     BdrvTrackedRequest *req;
@@ -1704,10 +1704,10 @@ static bool bdrv_init_padding(BlockDriverState *bs,
     return true;
 }
 
-static int bdrv_padding_rmw_read(BdrvChild *child,
-                                 BdrvTrackedRequest *req,
-                                 BdrvRequestPadding *pad,
-                                 bool zero_middle)
+static coroutine_fn int bdrv_padding_rmw_read(BdrvChild *child,
+                                              BdrvTrackedRequest *req,
+                                              BdrvRequestPadding *pad,
+                                              bool zero_middle)
 {
     QEMUIOVector local_qiov;
     BlockDriverState *bs = child->bs;
@@ -3228,7 +3228,7 @@ out:
     return ret;
 }
 
-int bdrv_co_ioctl(BlockDriverState *bs, int req, void *buf)
+int coroutine_fn bdrv_co_ioctl(BlockDriverState *bs, int req, void *buf)
 {
     BlockDriver *drv = bs->drv;
     CoroutineIOCompletion co = {
-- 
2.35.1



  parent reply	other threads:[~2022-05-09 10:39 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-09 10:29 [PATCH v2 00/26] block: fix coroutine_fn annotations Paolo Bonzini
2022-05-09 10:29 ` [PATCH v2 01/26] block: remove incorrect " Paolo Bonzini
2022-05-10 15:03   ` Eric Blake
2022-07-04 12:54   ` Alberto Faria
2022-05-09 10:29 ` [PATCH v2 02/26] qcow2: " Paolo Bonzini
2022-05-10 15:04   ` Eric Blake
2022-07-04 12:56   ` Alberto Faria
2022-05-09 10:29 ` [PATCH v2 03/26] nbd: " Paolo Bonzini
2022-05-10 15:05   ` Eric Blake
2022-07-04 12:56   ` Alberto Faria
2022-05-09 10:29 ` [PATCH v2 04/26] coroutine: " Paolo Bonzini
2022-05-10 15:12   ` Eric Blake
2022-07-04 12:57   ` Alberto Faria
2022-05-09 10:29 ` [PATCH v2 05/26] blkdebug: add missing " Paolo Bonzini
2022-05-10 15:30   ` Eric Blake
2022-05-09 10:29 ` [PATCH v2 06/26] blkverify: " Paolo Bonzini
2022-05-10 15:59   ` Eric Blake
2022-07-04 12:57   ` Alberto Faria
2022-05-09 10:30 ` Paolo Bonzini [this message]
2022-05-13 21:26   ` [PATCH v2 07/26] block: " Eric Blake
2022-05-14  9:54     ` Paolo Bonzini
2022-05-16 18:49       ` Alberto Faria
2022-05-17  9:51         ` Paolo Bonzini
2022-05-09 10:30 ` [PATCH v2 08/26] file-posix: " Paolo Bonzini
2022-05-13 21:52   ` Eric Blake
2022-07-04 12:57   ` Alberto Faria
2022-05-09 10:30 ` [PATCH v2 09/26] iscsi: " Paolo Bonzini
2022-05-18 14:44   ` Eric Blake
2022-07-04 12:58   ` Alberto Faria
2022-05-09 10:30 ` [PATCH v2 10/26] nbd: " Paolo Bonzini
2022-05-18 14:50   ` Eric Blake
2022-07-04 12:58   ` Alberto Faria
2022-05-09 10:30 ` [PATCH v2 11/26] nfs: " Paolo Bonzini
2022-07-04 12:59   ` Alberto Faria
2022-05-09 10:30 ` [PATCH v2 12/26] nvme: " Paolo Bonzini
2022-07-04 12:59   ` Alberto Faria
2022-05-09 10:30 ` [PATCH v2 13/26] parallels: " Paolo Bonzini
2022-07-04 12:59   ` Alberto Faria
2022-05-09 10:30 ` [PATCH v2 14/26] qcow2: " Paolo Bonzini
2022-07-04 12:59   ` Alberto Faria
2022-05-09 10:30 ` [PATCH v2 15/26] copy-before-write: " Paolo Bonzini
2022-07-04 12:59   ` Alberto Faria
2022-05-09 10:30 ` [PATCH v2 16/26] curl: " Paolo Bonzini
2022-07-04 13:00   ` Alberto Faria
2022-05-09 10:30 ` [PATCH v2 17/26] qed: " Paolo Bonzini
2022-07-04 13:01   ` Alberto Faria
2022-05-09 10:30 ` [PATCH v2 18/26] quorum: " Paolo Bonzini
2022-07-04 13:01   ` Alberto Faria
2022-05-09 10:30 ` [PATCH v2 19/26] throttle: " Paolo Bonzini
2022-07-04 13:02   ` Alberto Faria
2022-05-09 10:30 ` [PATCH v2 20/26] vmdk: " Paolo Bonzini
2022-07-04 13:02   ` Alberto Faria
2022-05-09 10:30 ` [PATCH v2 21/26] job: " Paolo Bonzini
2022-07-04 13:02   ` Alberto Faria
2022-05-09 10:30 ` [PATCH v2 22/26] coroutine-lock: " Paolo Bonzini
2022-07-04 13:03   ` Alberto Faria
2022-05-09 10:30 ` [PATCH v2 23/26] raw-format: " Paolo Bonzini
2022-07-04 13:03   ` Alberto Faria
2022-05-09 10:30 ` [PATCH v2 24/26] 9p: " Paolo Bonzini
2022-07-04 13:03   ` Alberto Faria
2022-05-09 10:30 ` [PATCH v2 25/26] migration: " Paolo Bonzini
2022-07-04 13:03   ` Alberto Faria
2022-05-09 10:30 ` [PATCH v2 26/26] test-coroutine: " Paolo Bonzini
2022-07-04 13:03   ` Alberto Faria
2022-05-09 11:53 ` [PATCH v2 00/26] block: fix " Daniel P. Berrangé
2022-05-09 13:30   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220509103019.215041-8-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.