All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denis@denix.org>
To: meta-ti@lists.yoctoproject.org
Subject: [master][PATCH 01/10] u-boot-ti: Use SRCPV instead of SRCREV for U_BOOT_LOCAL_VERSION
Date: Mon,  9 May 2022 17:59:38 +0000	[thread overview]
Message-ID: <20220509175947.1994132-2-denis@denix.org> (raw)
In-Reply-To: <20220509175947.1994132-1-denis@denix.org>

From: Nishanth Menon <nm@ti.com>

SRCREV works with fixed commits, but when we use AUTOREV for a
downstream distro bbappend, we will end up getting a bad local
revision.

Lets use SRCPV instead, which bitbake already deals with sensibly.

[1] https://www.yoctoproject.org/docs/2.5.1/dev-manual/dev-manual.html#automatically-incrementing-a-binary-package-revision-number

Fixes: 39fa0c1d3d02 ("u-boot-ti: Use SRCREV to get short commit ID")
Suggested-by: Denys Dmytriyenko <denys@konsulko.com>
Signed-off-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Ryan Eatmon <reatmon@ti.com>
Signed-off-by: Denys Dmytriyenko <denys@konsulko.com>
---
 meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc
index 5ddcaff7..dddf6284 100644
--- a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc
+++ b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc
@@ -1,6 +1,6 @@
 # UBOOT_LOCALVERSION can be set to add a tag to the end of the
 # U-boot version string.  such as the commit id
-UBOOT_LOCALVERSION = "-g${@d.getVar("SRCREV", False).__str__()[:10]}"
+UBOOT_LOCALVERSION = "-g${@d.getVar('SRCPV', True).split('+')[1]}"
 
 UBOOT_SUFFIX ?= "img"
 SPL_BINARY ?= "MLO"
-- 
2.25.1



  reply	other threads:[~2022-05-09 17:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-09 17:59 [master][PATCH 00/10] sync up with Dunfell 08.03.00.003 Denys Dmytriyenko
2022-05-09 17:59 ` Denys Dmytriyenko [this message]
2022-05-09 17:59 ` [master][PATCH 02/10] recipes-kernel: setup-defconfig: Use SRCPV to update KERNEL_LOCALVERSION Denys Dmytriyenko
2022-05-09 17:59 ` [master][PATCH 03/10] recipes-bsp: tifs-lpm-stub: Introduce new recipe Denys Dmytriyenko
2022-05-09 17:59 ` [master][PATCH 04/10] trusted-firmware-a: upgrade to v2.6+ Denys Dmytriyenko
2022-05-09 17:59 ` [master][PATCH 05/10] conf/machine: am62xx: Update build flag for low power mode Denys Dmytriyenko
2022-05-09 17:59 ` [master][PATCH 06/10] u-boot-ti-staging: Bump to 08.03.00.003 release Denys Dmytriyenko
2022-05-09 17:59 ` [master][PATCH 07/10] linux-ti-staging: " Denys Dmytriyenko
2022-05-09 17:59 ` [master][PATCH 08/10] linux-ti-staging-rt: " Denys Dmytriyenko
2022-05-09 17:59 ` [master][PATCH 09/10] libdce: upgrade to 3.00.15.00 and specify branch Denys Dmytriyenko
2022-05-09 17:59 ` [master][PATCH 10/10] dsptop: fix host contamination warning Denys Dmytriyenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220509175947.1994132-2-denis@denix.org \
    --to=denis@denix.org \
    --cc=meta-ti@lists.yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.