From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A63E1C433F5 for ; Tue, 10 May 2022 21:31:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234992AbiEJVbe (ORCPT ); Tue, 10 May 2022 17:31:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41578 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235348AbiEJVbJ (ORCPT ); Tue, 10 May 2022 17:31:09 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE4CF4B43E; Tue, 10 May 2022 14:31:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6ABF061694; Tue, 10 May 2022 21:31:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5728C385CA; Tue, 10 May 2022 21:31:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652218264; bh=qMN+5WDoS3UIEh8Xz7V+tC8QRCRZGmauwtSb43rY0QI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dbb4gITNAKvNAM2A7SQHuN4sjH0ThxDvf1mYtJsvVK8M9WSOtokL91cedxypRFt2G a8HN4fRmmy+PI8pJABzCSGpcPEISz3tdnM5ruPnfS12BZ0VGadXUzdbwQu9BnqBTrA e4PxJcV6XAaU/Su2GdYfC8RwXFIodXbm3YldBLJkWe1V+XuUpyuGG5Tg7qYdtn8Xig puIMhAAznC/E6xm8Vio1vMva2QHCr75oouro6gqs6xuNwKHPI+2mZC6sKErcVfZnOt LTbFjJQqMTLK7leDW1amQ7OE8PrtCHs5ubIsChp9DvZaTjBo2yYdK+qAL8+e1daem/ VYFh6wA8mD9Eg== Date: Tue, 10 May 2022 14:31:02 -0700 From: Jakub Kicinski To: Yury Norov Cc: Andy Shevchenko , David Laight , Greg Kroah-Hartman , Joe Perches , Julia Lawall , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Nicholas Piggin , Nicolas Palix , Peter Zijlstra , Rasmus Villemoes , Matti Vaittinen , linux-kernel@vger.kernel.org, "David S . Miller" , Eric Dumazet , Geetha sowjanya , Jerin Jacob , Linu Cherian , Paolo Abeni , Subbaraya Sundeep , Sunil Goutham , hariprasad , netdev@vger.kernel.org Subject: Re: [PATCH 06/22] octeontx2: use bitmap_empty() instead of bitmap_weight() Message-ID: <20220510143102.3da4498e@kernel.org> In-Reply-To: <20220510154750.212913-7-yury.norov@gmail.com> References: <20220510154750.212913-1-yury.norov@gmail.com> <20220510154750.212913-7-yury.norov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 10 May 2022 08:47:34 -0700 Yury Norov wrote: > bitmap_empty() is better than bitmap_weight() because it may return > earlier, and improves on readability. resend patches 6 and 9 separately please. if you CC the ML only on a portion of the patches our build bot will ignore it.