From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87CACC433F5 for ; Tue, 10 May 2022 15:47:23 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B631D192E; Tue, 10 May 2022 17:46:31 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B631D192E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1652197641; bh=eBC7r2zEJsCISV5SGvi7yf/yurad+4tTdXFlbCsj+X4=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=evlpL4PszRt+p+TsnET7rOBEEwxrHZ19oW+xvFozTxp3jY5h6ho/AW+FcirUm/xfi fp9FkijeGRk5Hpfr2+Flia/Ja0BmAMcwcklyyrKsf7MaS2IEBOfm3frBc3ghZZBhy+ lvEkNimnsUuF3uWmq+VyELI68enmXidqY1pOKFyM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 9E7E8F804BB; Tue, 10 May 2022 17:45:26 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B0A8AF80527; Tue, 10 May 2022 17:45:24 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 45C2DF80116 for ; Tue, 10 May 2022 17:45:21 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 45C2DF80116 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FMGnCwFB" Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CF38F614EC; Tue, 10 May 2022 15:45:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B25C8C385A6; Tue, 10 May 2022 15:45:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652197520; bh=eBC7r2zEJsCISV5SGvi7yf/yurad+4tTdXFlbCsj+X4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FMGnCwFBLQv+hSDAy6AUzn3pThfiYZyfiYrL0mxEHyzFIBe3gLWkOoDrPP8w/AFVC beZbUEdJeTK4k2+8r199A81tJb8nWPzNyySUlOa6AROW57qJNlzuA/PIQMmvWQatWu ptAiCfam/DaNGdEGPQZnwJ2Lx0JZTLuFeWU8IkyCLnAZ1irjRyNFDiBRzV8Of+LeFl +oBdDxiUuj3E6tYlm1tOYIymgPCmLvKdnZtjpWjLZWGnB1ALuTH8nMnZrQBERjw4KQ 5+5db7+YSRFWrGBHvtY6uYxa8Hfy+KoeRCCZVXn+OwRvgTeo5tdLJu8gB7H5FtJvPA p5z7bVvaPa0iQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH AUTOSEL 5.10 3/9] ASoC: max98090: Generate notifications on changes for custom control Date: Tue, 10 May 2022 11:45:06 -0400 Message-Id: <20220510154512.153945-3-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220510154512.153945-1-sashal@kernel.org> References: <20220510154512.153945-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Cc: Sasha Levin , alsa-devel@alsa-project.org, lgirdwood@gmail.com, pierre-louis.bossart@linux.intel.com, tiwai@suse.com, Mark Brown X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" From: Mark Brown [ Upstream commit 13fcf676d9e102594effc686d98521ff5c90b925 ] The max98090 driver has some custom controls which share a put() function which returns 0 unconditionally, meaning that events are not generated when the value changes. Fix that. Signed-off-by: Mark Brown Link: https://lore.kernel.org/r/20220420193454.2647908-2-broonie@kernel.org Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/max98090.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/max98090.c b/sound/soc/codecs/max98090.c index 779845e3a9e3..5b6405392f08 100644 --- a/sound/soc/codecs/max98090.c +++ b/sound/soc/codecs/max98090.c @@ -430,7 +430,7 @@ static int max98090_put_enab_tlv(struct snd_kcontrol *kcontrol, mask << mc->shift, sel << mc->shift); - return 0; + return *select != val; } static const char *max98090_perf_pwr_text[] = -- 2.35.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EE82C433FE for ; Tue, 10 May 2022 15:49:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346703AbiEJPxn (ORCPT ); Tue, 10 May 2022 11:53:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346569AbiEJPvF (ORCPT ); Tue, 10 May 2022 11:51:05 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD43D28BDDB; Tue, 10 May 2022 08:45:21 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3AEEB614AF; Tue, 10 May 2022 15:45:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B25C8C385A6; Tue, 10 May 2022 15:45:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652197520; bh=eBC7r2zEJsCISV5SGvi7yf/yurad+4tTdXFlbCsj+X4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FMGnCwFBLQv+hSDAy6AUzn3pThfiYZyfiYrL0mxEHyzFIBe3gLWkOoDrPP8w/AFVC beZbUEdJeTK4k2+8r199A81tJb8nWPzNyySUlOa6AROW57qJNlzuA/PIQMmvWQatWu ptAiCfam/DaNGdEGPQZnwJ2Lx0JZTLuFeWU8IkyCLnAZ1irjRyNFDiBRzV8Of+LeFl +oBdDxiUuj3E6tYlm1tOYIymgPCmLvKdnZtjpWjLZWGnB1ALuTH8nMnZrQBERjw4KQ 5+5db7+YSRFWrGBHvtY6uYxa8Hfy+KoeRCCZVXn+OwRvgTeo5tdLJu8gB7H5FtJvPA p5z7bVvaPa0iQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Mark Brown , Sasha Levin , lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, pierre-louis.bossart@linux.intel.com, alsa-devel@alsa-project.org Subject: [PATCH AUTOSEL 5.10 3/9] ASoC: max98090: Generate notifications on changes for custom control Date: Tue, 10 May 2022 11:45:06 -0400 Message-Id: <20220510154512.153945-3-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220510154512.153945-1-sashal@kernel.org> References: <20220510154512.153945-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mark Brown [ Upstream commit 13fcf676d9e102594effc686d98521ff5c90b925 ] The max98090 driver has some custom controls which share a put() function which returns 0 unconditionally, meaning that events are not generated when the value changes. Fix that. Signed-off-by: Mark Brown Link: https://lore.kernel.org/r/20220420193454.2647908-2-broonie@kernel.org Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/max98090.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/max98090.c b/sound/soc/codecs/max98090.c index 779845e3a9e3..5b6405392f08 100644 --- a/sound/soc/codecs/max98090.c +++ b/sound/soc/codecs/max98090.c @@ -430,7 +430,7 @@ static int max98090_put_enab_tlv(struct snd_kcontrol *kcontrol, mask << mc->shift, sel << mc->shift); - return 0; + return *select != val; } static const char *max98090_perf_pwr_text[] = -- 2.35.1